[hibernate-commits] [hibernate/hibernate-search] 2ae584: HSEARCH-2791 Introduce SearchITHelper, to make tes...

GitHub noreply at github.com
Thu Jun 29 08:53:28 EDT 2017 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 2ae5849d082f83ab10fab5019b3191828e7d2d43
      https://github.com/hibernate/hibernate-search/commit/2ae5849d082f83ab10fab5019b3191828e7d2d43
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    A engine/src/test/java/org/hibernate/search/testsupport/junit/SearchITHelper.java

  Log Message:
  -----------
  HSEARCH-2791 Introduce SearchITHelper, to make testing without ORM easier


  Commit: df843eb514b37e5389cdc3e03d691cb1fdec5324
      https://github.com/hibernate/hibernate-search/commit/df843eb514b37e5389cdc3e03d691cb1fdec5324
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/testsupport/setup/SearchConfigurationForTest.java

  Log Message:
  -----------
  HSEARCH-2791 Add method SearchConfigurationForTest.addClasses(Class<?>...)


  Commit: 9097321d8a346f5d2871f2a85892a235d3175a7b
      https://github.com/hibernate/hibernate-search/commit/9097321d8a346f5d2871f2a85892a235d3175a7b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchAnalysisDefinitionProviderIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchImplicitProvidedIdIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchMultitenancyIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchScrollingIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/bridge/DynamicMappingIT.java
    M engine/src/test/java/org/hibernate/search/test/analyzer/analyzerdef/AnalyzerDefInvalidTest.java
    M engine/src/test/java/org/hibernate/search/test/analyzer/analyzerdefinitionprovider/LuceneAnalysisDefinitionProviderTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/DeleteByQueryTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/AsyncBackendFlushTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/Quote.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/ResourcesClosedInOrderTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/ScheduledCommitPolicyTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/SharedReleasesLocksTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/SyncWorkProcessorShutDownTest.java
    M engine/src/test/java/org/hibernate/search/test/bridge/AppliedOnTypeAwareBridgeTest.java
    M engine/src/test/java/org/hibernate/search/test/bridge/PropertiesExampleBridgeTest.java
    M engine/src/test/java/org/hibernate/search/test/bridge/builtin/NullEncodingTwoWayFieldBridgeTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/ImplicitProvidedIdTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/IndexNameOverrideTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/EmptyQueryExceptionTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/LuceneSortDSLTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/NumericTypeGuessedTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/NumericTypeWithNullEncodingTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/SortDSLTest.java
    M engine/src/test/java/org/hibernate/search/test/filters/FreshReadersProvidedTest.java
    M engine/src/test/java/org/hibernate/search/test/id/NumericIdEncodingTest.java
    M engine/src/test/java/org/hibernate/search/test/id/providedId/ProvidedIdTest.java
    M engine/src/test/java/org/hibernate/search/test/indexmanager/DirectoryBasedIndexManagerTest.java
    M engine/src/test/java/org/hibernate/search/test/projection/ProjectionConversionTest.java
    M engine/src/test/java/org/hibernate/search/test/query/serialization/QuerySerializationTest.java
    M engine/src/test/java/org/hibernate/search/test/sharding/LogRotationExampleTest.java
    M engine/src/test/java/org/hibernate/search/test/sorting/CustomTypeMetadataSortingTest.java
    M engine/src/test/java/org/hibernate/search/test/sorting/SortingTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java
    M orm/src/test/java/org/hibernate/search/test/query/facet/MultiValuedFacetingTest.java

  Log Message:
  -----------
  HSEARCH-2791 Use SearchITHelper in non-ORM tests


  Commit: 5928378a97dba3fd464ef0f2d4cd68431162d68e
      https://github.com/hibernate/hibernate-search/commit/5928378a97dba3fd464ef0f2d4cd68431162d68e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/CheckCustomFieldDefaultsIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/Elasticsearch2JavaTimeIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/Elasticsearch5JavaTimeIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexNullAsIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaNamingErrorsIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSimpleQueryStringDSLIT.java
    M engine/src/test/java/org/hibernate/search/test/dsl/NumericTypeGuessedTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultAnalyzer.java
    M orm/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultsTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/tika/Book.java
    M orm/src/test/java/org/hibernate/search/test/bridge/tika/TikaBridgeInputTypeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/time/JavaTimeTest.java
    M orm/src/test/java/org/hibernate/search/test/embedded/path/DefaultPathsWithNestedIndexedEmbeddedTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/Coordinate.java
    M orm/src/test/java/org/hibernate/search/test/engine/Country.java
    M orm/src/test/java/org/hibernate/search/test/engine/Location.java
    M orm/src/test/java/org/hibernate/search/test/engine/LuceneNumericFieldTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/NumericDocumentIdIndexedEmbeddedTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/NumericFieldTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/PinPoint.java
    M orm/src/test/java/org/hibernate/search/test/engine/PointOfInterest.java
    M orm/src/test/java/org/hibernate/search/test/engine/Position.java
    M orm/src/test/java/org/hibernate/search/test/engine/TouristAttraction.java
    M orm/src/test/java/org/hibernate/search/test/id/MissingIdTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Animal.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Book.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Car.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Coffee.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/CoffeeBrand.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/DSLTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Day.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Month.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/MoreLikeThisTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/NumericEncodingQueriesTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/POI.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/POIHash.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/SimpleQueryStringDSLTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/SpatialDSLTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/SportsCar.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/ContainerEntity.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/DslEmbeddedSearchTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/EmbeddedEntity.java

  Log Message:
  -----------
  HSEARCH-2791 Do not rely on Hibernate ORM for ORM-unrelated tests

Using ORM brings more complexity to the tests, and with it a greater
potential for failures unrelated to the feature being tested.

For instance, time types are not supported as well, nor in the same way,
with all databases, so we may as well avoid the hassle.

So when we're testing features that are not related to ORM in any way,
let's avoid it.

The tests modified by this commit all failed with one database or
another, most of the time because of entity names that were too long or
because of time types that were not supported the same way as in H2.


  Commit: 6dfbb22d3dc3093f6c4231a7601fc08afc5c1476
      https://github.com/hibernate/hibernate-search/commit/6dfbb22d3dc3093f6c4231a7601fc08afc5c1476
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    A engine/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultAnalyzer.java
    A engine/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultsTest.java
    A engine/src/test/java/org/hibernate/search/test/bridge/builtin/Book.java
    A engine/src/test/java/org/hibernate/search/test/bridge/builtin/TikaBridgeInputTypeTest.java
    A engine/src/test/java/org/hibernate/search/test/bridge/time/JavaTimeTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Animal.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Book.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Car.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Coffee.java
    A engine/src/test/java/org/hibernate/search/test/dsl/CoffeeBrand.java
    A engine/src/test/java/org/hibernate/search/test/dsl/DSLTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Day.java
    A engine/src/test/java/org/hibernate/search/test/dsl/Month.java
    A engine/src/test/java/org/hibernate/search/test/dsl/MonthBase0FieldBridge.java
    A engine/src/test/java/org/hibernate/search/test/dsl/MonthClassBridge.java
    A engine/src/test/java/org/hibernate/search/test/dsl/MoreLikeThisTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/NumericEncodingQueriesTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/POI.java
    A engine/src/test/java/org/hibernate/search/test/dsl/POIHash.java
    A engine/src/test/java/org/hibernate/search/test/dsl/RomanNumberFieldBridge.java
    A engine/src/test/java/org/hibernate/search/test/dsl/SimpleQueryStringDSLTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/SpatialDSLTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/SportsCar.java
    A engine/src/test/java/org/hibernate/search/test/dsl/embedded/ContainerEntity.java
    A engine/src/test/java/org/hibernate/search/test/dsl/embedded/DslEmbeddedSearchTest.java
    A engine/src/test/java/org/hibernate/search/test/dsl/embedded/EmbeddedEntity.java
    A engine/src/test/java/org/hibernate/search/test/dsl/embedded/PaddedIntegerBridge.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/BigDecimalNumericFieldBridge.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/Coordinate.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/CoordinatesPairFieldBridge.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/Country.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/Location.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/LuceneNumericFieldTest.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/NumericDocumentIdIndexedEmbeddedTest.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/NumericFieldTest.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/PinPoint.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/PointOfInterest.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/Position.java
    A engine/src/test/java/org/hibernate/search/test/engine/numeric/TouristAttraction.java
    A engine/src/test/java/org/hibernate/search/test/id/MissingIdTest.java
    A engine/src/test/resources/org/hibernate/search/test/bridge/builtin/test-document-3.pdf
    R orm/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultAnalyzer.java
    R orm/src/test/java/org/hibernate/search/test/bridge/CheckCustomFieldDefaultsTest.java
    R orm/src/test/java/org/hibernate/search/test/bridge/tika/Book.java
    R orm/src/test/java/org/hibernate/search/test/bridge/tika/TikaBridgeInputTypeTest.java
    R orm/src/test/java/org/hibernate/search/test/bridge/time/JavaTimeTest.java
    R orm/src/test/java/org/hibernate/search/test/engine/BigDecimalNumericFieldBridge.java
    R orm/src/test/java/org/hibernate/search/test/engine/Coordinate.java
    R orm/src/test/java/org/hibernate/search/test/engine/CoordinatesPairFieldBridge.java
    R orm/src/test/java/org/hibernate/search/test/engine/Country.java
    R orm/src/test/java/org/hibernate/search/test/engine/Location.java
    R orm/src/test/java/org/hibernate/search/test/engine/LuceneNumericFieldTest.java
    R orm/src/test/java/org/hibernate/search/test/engine/NumericDocumentIdIndexedEmbeddedTest.java
    R orm/src/test/java/org/hibernate/search/test/engine/NumericFieldTest.java
    R orm/src/test/java/org/hibernate/search/test/engine/PinPoint.java
    R orm/src/test/java/org/hibernate/search/test/engine/PointOfInterest.java
    R orm/src/test/java/org/hibernate/search/test/engine/Position.java
    R orm/src/test/java/org/hibernate/search/test/engine/TouristAttraction.java
    R orm/src/test/java/org/hibernate/search/test/id/MissingIdTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Animal.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Book.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Car.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Coffee.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/CoffeeBrand.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/DSLTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Day.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/Month.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/MonthBase0FieldBridge.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/MonthClassBridge.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/MoreLikeThisTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/NumericEncodingQueriesTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/POI.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/POIHash.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/RomanNumberFieldBridge.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/SimpleQueryStringDSLTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/SpatialDSLTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/SportsCar.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/ContainerEntity.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/DslEmbeddedSearchTest.java
    R orm/src/test/java/org/hibernate/search/test/query/dsl/embedded/EmbeddedEntity.java

  Log Message:
  -----------
  HSEARCH-2791 Move ORM-unrelated tests from the -orm module to the -engine module

Doing this in a separate commit so that the renaming is correctly
detected and the git history is preserved.


  Commit: 18b49ea982516f9550e6c18d395e63d9ed06001b
      https://github.com/hibernate/hibernate-search/commit/18b49ea982516f9550e6c18d395e63d9ed06001b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/embedded/ContainedInEntityInheritanceTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/deletebyterm/DeleteByTermTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/mappedsuperclasscollection/EntityExtendingMappedSuperclassWithCollectionField.java
    M orm/src/test/java/org/hibernate/search/test/interceptor/ManualIndexingOnlyInterceptorTest.java
    M orm/src/test/java/org/hibernate/search/test/query/initandlookup/ObjectLookupAndDatabaseRetrievalConfigurationTest.java
    M orm/src/test/java/org/hibernate/search/test/shards/Animal.java
    M orm/src/test/java/org/hibernate/search/test/shards/DynamicShardingTest.java
    M orm/src/test/java/org/hibernate/search/test/spatial/SpatialSearchSortByDistanceAndPagingTest.java

  Log Message:
  -----------
  HSEARCH-2791 Avoid long table names in ORM-related tests

Oracle in particular only allows table names of 30 characters or less.


  Commit: b750817b19129b2ef5359d58352a99aedbcf8470
      https://github.com/hibernate/hibernate-search/commit/b750817b19129b2ef5359d58352a99aedbcf8470
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/query/timeout/TimeoutTest.java
    M pom.xml

  Log Message:
  -----------
  HSEARCH-2791 Upgrade open-source DB drivers to at least match the version used in Hibernate ORM tests

Proprietary drivers are much more difficult to upgrade, due to their
being unavailable on public maven repos.


  Commit: 29732ab6cfd86767837221bf0137723fc1119d99
      https://github.com/hibernate/hibernate-search/commit/29732ab6cfd86767837221bf0137723fc1119d99
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-2791 Use PostgreSQL82Dialect instead of the deprecated PostgreSQLDialect


  Commit: b6c40a3cdf71aa21fad30971b647629aae2ca584
      https://github.com/hibernate/hibernate-search/commit/b6c40a3cdf71aa21fad30971b647629aae2ca584
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/engine/worker/WorkerTestCase.java

  Log Message:
  -----------
  HSEARCH-2791 Use ConcurrentRunner in WorkerTestCase

This should make the stacktraces easier to read...


  Commit: a9c5f24f1b275641fe2ea51db35d94051b181369
      https://github.com/hibernate/hibernate-search/commit/a9c5f24f1b275641fe2ea51db35d94051b181369
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-2791 Mention explicitly that maven coordinates of proprietary DB drivers are fake

Because this really wasted my time.


Compare: https://github.com/hibernate/hibernate-search/compare/81082e086e9c...a9c5f24f1b27

More information about the hibernate-commits mailing list