[hibernate-commits] [hibernate/hibernate-search] df590b: HSEARCH-2541 Make protected some methods that have...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: df590b98ab3ab4ea9386fef969662ab07355ea16
      https://github.com/hibernate/hibernate-search/commit/df590b98ab3ab4ea9386fef969662ab07355ea16
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-03-06 (Mon, 06 Mar 2017)

  Changed paths:
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/AbstractLoader.java
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/MultiClassesQueryLoader.java
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/QueryLoader.java

  Log Message:
  -----------
  HSEARCH-2541 Make protected some methods that have no business being public


  Commit: 5007ece539d4468920167873b7963f08e3378072
      https://github.com/hibernate/hibernate-search/commit/5007ece539d4468920167873b7963f08e3378072
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-03-06 (Mon, 06 Mar 2017)

  Changed paths:
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/AbstractLoader.java
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/MultiClassesQueryLoader.java
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/QueryLoader.java

  Log Message:
  -----------
  HSEARCH-2541 Push up some bypass code from AbstractLoader.executeLoad to AbstractLoader.load


  Commit: 8d5932bb48761f11a693f47ec1352501937b97ac
      https://github.com/hibernate/hibernate-search/commit/8d5932bb48761f11a693f47ec1352501937b97ac
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-03-06 (Mon, 06 Mar 2017)

  Changed paths:
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/ObjectLoaderHelper.java

  Log Message:
  -----------
  HSEARCH-2541 Don't use Session.load to load objects, use Session.get() instead

Session.get() *actually* loads the object, while Session.load() only
creates a proxy. That's terrible naming, but it probably is legacy API.

In our case, we ultimately want fully initialized objects, so
Session.get() is more appropriate. On top of that, Hibernate ORM seems
to have issues with initializing proxies on entities with public fields,
so that's all the more reason to use Session.get() and bypass proxying
altogether.


  Commit: b4b7d8b3409c5d15a13ed1b2aac4452769323189
      https://github.com/hibernate/hibernate-search/commit/b4b7d8b3409c5d15a13ed1b2aac4452769323189
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-03-06 (Mon, 06 Mar 2017)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/query/ObjectLoadingPublicFieldTest.java

  Log Message:
  -----------
  HSEARCH-2541 Test case for entity loading when entities have public fields


Compare: https://github.com/hibernate/hibernate-search/compare/3a0493a7fcd9...b4b7d8b3409c