[hibernate-commits] [hibernate/hibernate-validator] 3ceafc: HV-1245 Move the extraction of the value to valida...

GitHub noreply at github.com
Fri Mar 10 09:10:21 EST 2017 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 3ceafc6cb7ec31faa34a82cb2b1b824a3dfca8ed
      https://github.com/hibernate/hibernate-validator/commit/3ceafc6cb7ec31faa34a82cb2b1b824a3dfca8ed
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraint.java

  Log Message:
  -----------
  HV-1245 Move the extraction of the value to validate to MetaConstraint

It simplifies ValidatorImpl and paves the way for the next steps.


  Commit: 6bba1d26220ba50276b5219cffa9cdd5b7f5e4e0
      https://github.com/hibernate/hibernate-validator/commit/6bba1d26220ba50276b5219cffa9cdd5b7f5e4e0
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraint.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraints.java

  Log Message:
  -----------
  HV-1245 Introduce ValueExtractionPathNode to be able to pass more
information in the extraction path


  Commit: 91c5a9ead92fe6c2ff5538c3d2817eb693a283c8
      https://github.com/hibernate/hibernate-validator/commit/91c5a9ead92fe6c2ff5538c3d2817eb693a283c8
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Remove PathImpl and NodeImpl from test utils


  Commit: c1baee9184d8ab35a7dd3b87180fa9a8806860be
      https://github.com/hibernate/hibernate-validator/commit/c1baee9184d8ab35a7dd3b87180fa9a8806860be
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValueContext.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraint.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraints.java
    A engine/src/main/java/org/hibernate/validator/internal/util/TypeVariables.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/NestedCascadedConstraintsTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/NestedTypeArgumentsValueExtractorTest.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/PropertyPathAndStringRepresentationTest.java
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Introduce the type parameter information in the path

Also introduce the TypeArgumentNode type.


  Commit: f9cf7c85e52214fb65489ac1641f7a689d4d8132
      https://github.com/hibernate/hibernate-validator/commit/f9cf7c85e52214fb65489ac1641f7a689d4d8132
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/CustomValueExtractorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/MapExtractorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/NestedCascadedConstraintsTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/NestedTypeArgumentsValueExtractorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/PropertyPathAndStringRepresentationTest.java

  Log Message:
  -----------
  HV-1245 Add the type parameter info to the Path string representation

This is a first very conservative implementation. It sacrifices
consistency for more readable string representation and compatibility
with HV 5.x.

Not sure it is the best move.

Note that the parsing of a string representation containing type
parameter information has not been implemented yet, mostly because, as
the information is not included every time, we cannot really extract it.


  Commit: 4da96eb78ba2e7afd9d960b4de33051a73047362
      https://github.com/hibernate/hibernate-validator/commit/4da96eb78ba2e7afd9d960b4de33051a73047362
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValueContext.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java
    A engine/src/main/java/org/hibernate/validator/internal/engine/path/TypeParameterImpl.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/NestedCascadedConstraintsTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/NestedTypeArgumentsValueExtractorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/PropertyPathAndStringRepresentationTest.java
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Rename TYPE_ARGUMENT to CONTAINER_ELEMENT


  Commit: c30c2b00cd2561187a245be0ac2de52d5c6bdb57
      https://github.com/hibernate/hibernate-validator/commit/c30c2b00cd2561187a245be0ac2de52d5c6bdb57
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Move getTypeParameter into the specific nodes instead of Node


  Commit: 81b65760ccaf43a60811ef791c9ac6e4e402fac1
      https://github.com/hibernate/hibernate-validator/commit/81b65760ccaf43a60811ef791c9ac6e4e402fac1
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValueContext.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/engine/path/TypeParameterImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/util/TypeVariables.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/NestedCascadedConstraintsTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/NestedTypeArgumentsValueExtractorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/PropertyPathAndStringRepresentationTest.java
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Prefer basic approach rather than introducing TypeParameter


  Commit: 37f57130b5901316f099ba584806d32e60a71529
      https://github.com/hibernate/hibernate-validator/commit/37f57130b5901316f099ba584806d32e60a71529
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java
    M test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

  Log Message:
  -----------
  HV-1245 Rename containerElementIndex to typeArgumentIndex


  Commit: a6407519d883c9d379bdd5877ef46c5e7f3a67b8
      https://github.com/hibernate/hibernate-validator/commit/a6407519d883c9d379bdd5877ef46c5e7f3a67b8
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java

  Log Message:
  -----------
  HV-1245 Simplify the filter on Map's V in NodeImpl string representation


  Commit: baba923a29cef05465d6cfbb7cd6b74fdb5df8a9
      https://github.com/hibernate/hibernate-validator/commit/baba923a29cef05465d6cfbb7cd6b74fdb5df8a9
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ValueExtractorManager.java

  Log Message:
  -----------
  HV-1245 Fix the ValueExtractor determination logic


  Commit: 085d118cfb01476488f959eb16f614cb429e962e
      https://github.com/hibernate/hibernate-validator/commit/085d118cfb01476488f959eb16f614cb429e962e
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValueContext.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ArrayElement.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ValueExtractorDescriptor.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/cascading/CascadingTypeParameter.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraint.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
    M engine/src/main/java/org/hibernate/validator/internal/util/TypeVariables.java
    M engine/src/test/java/org/hibernate/validator/test/constraints/ConstraintValidatorContextTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/NestedCascadedConstraintsTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/NestedTypeArgumentsValueExtractorTest.java

  Log Message:
  -----------
  HV-1245 Provide the containerClass information for arrays


  Commit: 0a9791c4c73b4f0afc2750abcf0ff9c72883f771
      https://github.com/hibernate/hibernate-validator/commit/0a9791c4c73b4f0afc2750abcf0ff9c72883f771
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ArrayElement.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/cascading/ValueExtractorManager.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/cascaded/CustomValueExtractorTest.java

  Log Message:
  -----------
  HV-1245 Misc. improvements:

* Avoiding repeated method call
* Simplifying handling of primitive array types
* Enabling test method missing @Test annotation


Compare: https://github.com/hibernate/hibernate-validator/compare/d1e56b40faac...0a9791c4c73b

More information about the hibernate-commits mailing list