[hibernate-commits] [hibernate/hibernate-validator] 7b82e2: HV-1300 Splitting number validators for for each n...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 7b82e267ea8c83cd23406eadc8174f8d6c7c666e
      https://github.com/hibernate/hibernate-validator/commit/7b82e267ea8c83cd23406eadc8174f8d6c7c666e
  Author: marko-bekhta <markob at prykladna.lviv.ua>
  Date:   2017-05-11 (Thu, 11 May 2017)

  Changed paths:
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/BaseNegativeValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/BasePositiveValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/DecimalMaxValidatorForNumber.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/DecimalMinValidatorForNumber.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/MaxValidatorForNumber.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/MinValidatorForNumber.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/NegativeValidatorForNumber.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/PositiveValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/NegativeValidatorForMonetaryAmount.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/PositiveValidatorForMonetaryAmount.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/BaseMaxValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/BaseMinValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/InfinityNumberComparatorHelper.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/NumberComparatorHelper.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/BaseDecimalMaxValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/BaseDecimalMinValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalNumberComparatorHelper.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/package-info.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/package-info.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/package-info.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/BaseNegativeValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/BasePositiveValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForShort.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NumberSignumHelper.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForBigDecimal.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForBigInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForDouble.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForFloat.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForLong.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForShort.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/package-info.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
    A engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/BaseMinMaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForStringTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinMaxValidatorBoundaryTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForStringTest.java
    A engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/SignValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/ConstraintValidatorCachingTest.java

  Log Message:
  -----------
  HV-1300 Splitting number validators for for each number type


  Commit: 4f023c975388230d6bcc67dda488def0fcb100a3
      https://github.com/hibernate/hibernate-validator/commit/4f023c975388230d6bcc67dda488def0fcb100a3
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-05-11 (Thu, 11 May 2017)

  Changed paths:
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/InfinityNumberComparatorHelper.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/InfinityNumberComparatorHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/NumberComparatorHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalNumberComparatorHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForByte.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForShort.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NumberSignHelper.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NumberSignumHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForByte.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForShort.java

  Log Message:
  -----------
  HV-1300 Avoid creating new Optionals for each comparison

Also use OptionalInt as it's exactly what it is for.


  Commit: 13171b559ed6a3ccd9f7111819ecde7c8f6bb1de
      https://github.com/hibernate/hibernate-validator/commit/13171b559ed6a3ccd9f7111819ecde7c8f6bb1de
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-05-11 (Thu, 11 May 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/NegativeValidatorForMonetaryAmount.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/PositiveValidatorForMonetaryAmount.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/AbstractMaxValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/AbstractMinValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/BaseMaxValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/BaseMinValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/AbstractDecimalMaxValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/AbstractDecimalMinValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/BaseDecimalMaxValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/BaseDecimalMinValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/AbstractNegativeValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/AbstractPositiveValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/BaseNegativeValidator.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/BasePositiveValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForByte.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/NegativeValidatorForShort.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForBigDecimal.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForBigInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForByte.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForDouble.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForFloat.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForLong.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForNumber.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/sign/PositiveValidatorForShort.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinMaxValidatorBoundaryTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/SignValidatorForNumberTest.java

  Log Message:
  -----------
  HV-1300 Rename Base* classes to Abstract* for consistency


Compare: https://github.com/hibernate/hibernate-validator/compare/136f998a63cc...13171b559ed6