[hibernate-commits] [hibernate/hibernate-search] a07350: HSEARCH-2736 Discovery_scheme not taken in account

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: a07350b49be3126e496df91f6a6e26258e3322a5
      https://github.com/hibernate/hibernate-search/commit/a07350b49be3126e496df91f6a6e26258e3322a5
  Author: mvincent <matthieu.vincent at soprasteria.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/client/impl/DefaultElasticsearchClientFactory.java

  Log Message:
  -----------
  HSEARCH-2736 Discovery_scheme not taken in account

Fix deprecation on flag discovery_scheme for https support


  Commit: 933072a2b6e6efac846dd0444ab1be3a9e765577
      https://github.com/hibernate/hibernate-search/commit/933072a2b6e6efac846dd0444ab1be3a9e765577
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/DefaultElasticsearchClientFactoryTest.java

  Log Message:
  -----------
  HSEARCH-2736 Add a *disabled* test for hibernate.search.default.elasticsearch.discovery.default_scheme

See HSEARCH-2481 for why it's disabled.
Byteman is probably our only solution here. We don't have a valid SSL
certificate to put in the Elasticsearch server mock, so every HTTPS call
will fail. Worse, the failure will be exactly the same when using HTTP
instead of HTTPS (ConnectionClosedException).


Compare: https://github.com/hibernate/hibernate-search/compare/b91605be16d5...933072a2b6e6