[hibernate-commits] [hibernate/hibernate-orm] fdfef4: HHH-12905 Fix error message tested in MySQL and Po...

[GitHub]

  Branch: refs/heads/5.3
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: fdfef4f5ce939de983aff446c8847af4d7993504
      https://github.com/hibernate/hibernate-orm/commit/fdfef4f5ce939de983aff446c8847af4d7993504
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M hibernate-core/src/test/java/org/hibernate/test/procedure/MySQLStoredProcedureTest.java
    M hibernate-core/src/test/java/org/hibernate/test/procedure/PostgreSQLStoredProcedureTest.java

  Log Message:
  -----------
  HHH-12905 Fix error message tested in MySQL and PostgreSQL tests


  Commit: 14f28df3bb175967a4270fee19fc83119ef64df9
      https://github.com/hibernate/hibernate-orm/commit/14f28df3bb175967a4270fee19fc83119ef64df9
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M gradle/databases.gradle

  Log Message:
  -----------
  Uncomment MariaDB dialect in gradle/databases.gradle

I don't know why it has been commmented out but it prevents from running
the tests with -Pdb=mariadb as no dialect is defined.


  Commit: 5b826c90621aefae4d05f64f6de5c73af20d85ca
      https://github.com/hibernate/hibernate-orm/commit/5b826c90621aefae4d05f64f6de5c73af20d85ca
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/procedure/internal/ParameterBindImpl.java
    M hibernate-core/src/test/java/org/hibernate/test/procedure/MySQLStoredProcedureTest.java
    M hibernate-core/src/test/java/org/hibernate/test/procedure/PostgreSQLStoredProcedureTest.java

  Log Message:
  -----------
  HHH-12905 Improve the error message and update the tests accordingly

Also fix a loose end in the MySQL test: at least with MariaDB, using
a bit(1) as datatype for boolean does not work: it always return true
even if you set it to 0. Using either boolean or tinyint(1) solves
the issue.

As I'm not sure older versions of MySQL supports a real boolean type I
used a tinyint(1).


Compare: https://github.com/hibernate/hibernate-orm/compare/99b93ae949b4...5b826c90621a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.