[hibernate-commits] [hibernate/hibernate-search] 49a1eb: HSEARCH-3267 Fix ability to run WildFly integratio...

[GitHub]

  Branch: refs/heads/5.10
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 49a1ebb56f6439cc7b7e3584e4d3a98f2135570b
      https://github.com/hibernate/hibernate-search/commit/49a1ebb56f6439cc7b7e3584e4d3a98f2135570b
  Author: Martin Simka <msimka at redhat.com>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M integrationtest/wildfly/README.md
    M integrationtest/wildfly/pom.xml

  Log Message:
  -----------
  HSEARCH-3267 Fix ability to run WildFly integration tests with clean WildFly from external location


  Commit: 86263a493c7a03115ea956c1fc435d58f6832dfc
      https://github.com/hibernate/hibernate-search/commit/86263a493c7a03115ea956c1fc435d58f6832dfc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M integrationtest/wildfly/README.md
    M integrationtest/wildfly/pom.xml

  Log Message:
  -----------
  HSEARCH-3267 Remove the (now useless) useBuiltinModules build option

We can't push modules to an external WildFly instance anymore, so
there's no point exposing the option: either we test against another
instance, in which case you use the built-in modules, or we provision
the instance ourselves, in which case we push our own modules.


  Commit: e53336040589ba9955cbe533e6ccc79823d9f3c1
      https://github.com/hibernate/hibernate-search/commit/e53336040589ba9955cbe533e6ccc79823d9f3c1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M integrationtest/performance/orm/src/test/java/org/hibernate/search/test/performance/TestRunnerArquillian.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/VersionTestHelper.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/arquillian/DataSourceConfigurator.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/arquillian/LoggingConfigurator.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/arquillian/WildFlyConfigurationExtension.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/cmp/ContainerManagedPersistenceWithMassIndexerIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/elasticsearch/ElasticsearchModuleMemberRegistrationIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jgroups/JGroupsDeploymentHelper.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jms/DeploymentJmsMasterSlave.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jsr352/massindexing/MultipleEntityManagerFactoriesNotRegisteredAsBeansIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jsr352/massindexing/MultipleEntityManagerFactoriesRegisteredAsBeansIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jsr352/massindexing/RemoteExecutionIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/jsr352/massindexing/RestartIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/BootstrapFailureIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/MemberRegistrationEarArchiveIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/MemberRegistrationIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/ModuleMemberRegistrationEarArchiveIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/ModuleMemberRegistrationEarArchiveWithJbossDeploymentIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/ModuleMemberRegistrationIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/cdi/CDIInjectionIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/cdi/CDIInjectionLifecycleEventsIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/massindexing/MassIndexingTimeoutIT.java

  Log Message:
  -----------
  HSEARCH-3267 Expose the data source name through WildFlyConfigurationExtension in WF tests

We may decide in the future to use a different datasource in WF tests
depending on build options; I almost had to do it to solve this issue.
So let's be ready for that by moving the DATA_SOURCE_JNDI_NAME constant
to WildFlyConfigurationExtension, which could initialize it differently
depending on various (static) methods, and could then decide to use the
DataSourceConfigurator or not.


  Commit: 2b00f2969392307eb5ccfba7abc87be6433b08d6
      https://github.com/hibernate/hibernate-search/commit/2b00f2969392307eb5ccfba7abc87be6433b08d6
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/VersionTestHelper.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/ModuleMemberRegistrationEarArchiveWithJbossDeploymentIT.java
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/ModuleMemberRegistrationIT.java

  Log Message:
  -----------
  HSEARCH-3267 Move code detecting whether we're using built-in WF modules or not to a dedicated method

I had to do that for a fix that I finally didn't have to apply, and it's
clearer, so let's merge it.


  Commit: d43891eb36fbe9085a48547ea8175982b5ca72c7
      https://github.com/hibernate/hibernate-search/commit/d43891eb36fbe9085a48547ea8175982b5ca72c7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/cdi/CDIInjectionLifecycleEventsIT.java

  Log Message:
  -----------
  HSEARCH-3267 Reset event counts *before* running CDIInjectionLifecycleEventsIT

This is important when using an external WF instance, because otherwise
a temporary file might be kept from one Maven execution to the other,
making this test fail without reason.


Compare: https://github.com/hibernate/hibernate-search/compare/992613408491...d43891eb36fb
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.