[hibernate-commits] [hibernate/hibernate-search] ff63e8: HSEARCH-2955 Detect missing facets in SearchITHelp...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: ff63e88e5f825c5ed69cf7826c5efad1685ac5fa
      https://github.com/hibernate/hibernate-search/commit/ff63e88e5f825c5ed69cf7826c5efad1685ac5fa
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/testsupport/junit/SearchITHelper.java

  Log Message:
  -----------
  HSEARCH-2955 Detect missing facets in SearchITHelper


  Commit: 145aea7b723b20367b8c3c75288762ba304e0a14
      https://github.com/hibernate/hibernate-search/commit/145aea7b723b20367b8c3c75288762ba304e0a14
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/query/engine/impl/LuceneHSQuery.java
    M engine/src/main/java/org/hibernate/search/query/engine/impl/QueryHits.java
    M engine/src/test/java/org/hibernate/search/test/id/providedId/ProvidedIdTest.java

  Log Message:
  -----------
  HSEARCH-2955 Always enable faceting collection if there are faceting requests, even on empty indexes


  Commit: 812a3fc0b95ddb0e9ca9c1b37dcca1752356f381
      https://github.com/hibernate/hibernate-search/commit/812a3fc0b95ddb0e9ca9c1b37dcca1752356f381
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/query/engine/impl/QueryHits.java

  Log Message:
  -----------
  HSEARCH-2955 Do not throw an exception when matched documents do not have any facet value

We used to rely on the metadata inside the Lucene index to determine
whether facets are correctly configured, but this is no longer
necessary: we can just check our own metadata. So now if we encounter a
case where Lucene tells us "there are no facets in this set of
documents!", we can simply infer that the documents do not have any
value for the requested facet field.


  Commit: 00ce99872be3dc7ee09adc67cd712d58d4ab6699
      https://github.com/hibernate/hibernate-search/commit/00ce99872be3dc7ee09adc67cd712d58d4ab6699
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    A engine/src/test/java/org/hibernate/search/test/facet/NoIndexedValueFacetingTest.java

  Log Message:
  -----------
  HSEARCH-2955 Test faceting requests on an index with no value for the targeted faceted field


Compare: https://github.com/hibernate/hibernate-search/compare/013e5fe4ed3c...00ce99872be3