[hibernate-commits] [hibernate/hibernate-orm] c52b83: HHH-12133 - Create ManagedBeanRegistry and Managed...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: c52b8389f23b92a7fa50d7b8edc6c3e2ab098c91
      https://github.com/hibernate/hibernate-orm/commit/c52b8389f23b92a7fa50d7b8edc6c3e2ab098c91
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-17 (Wed, 17 Jan 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/resource/beans/container/internal/ContainerManagedLifecycleStrategy.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/container/internal/JpaCompliantLifecycleStrategy.java
    M hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/NonRegistryManagedBeanConsumingIntegrator.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/TheFallbackBeanInstanceProducer.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/TheReflectionInstantiatedBean.java
    M hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/delayed/NonRegistryManagedDelayedCdiSupportTest.java
    M hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/extended/NonRegistryManagedExtendedCdiSupportTest.java
    M hibernate-core/src/test/java/org/hibernate/test/cdi/general/nonregistrymanaged/standard/NonRegistryManagedStandardCdiSupportTest.java

  Log Message:
  -----------
  HHH-12133 - Create ManagedBeanRegistry and ManagedBean

 - Add non-regression tests related to the fallback bean instance producer
 - Fix a bug where we would call beanInstanceProducer.produceBeanInstance(Class) even when a named bean was requested.
 - Do not call Instance#destroy on bean instances produced by the fallback bean producer.  We used to, because we expected the Instance resolution to fail when a bean could not be found. But Instance resolution will never fail in that case, it will just return an Instance whose #isUnsatisfied() method returns true. It happens that calling Instance#destroy did not fail with Weld, because Weld just ignores the call in that case, but other CDI implementations may behave differently: the javadoc, and probably also the CDI spec, are not explicit about what happens in that case.