[hibernate-commits] [hibernate/hibernate-orm] 84b82e: HHH-12133 Move CDI lifecycle management code to de...

[GitHub]

  Branch: refs/tags/cdi-20-patch-in-wildfly-integration-tests
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: 84b82ed043b9d1262707c8af6023d20a277d1634
      https://github.com/hibernate/hibernate-orm/commit/84b82ed043b9d1262707c8af6023d20a277d1634
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    A hibernate-core/src/main/java/org/hibernate/resource/beans/internal/CdiLifecycleManagementStrategy.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/Helper.java
    A hibernate-core/src/main/java/org/hibernate/resource/beans/internal/JpaCdiLifecycleManagementStrategy.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiDelayedImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiExtendedImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiStandardImpl.java
    A hibernate-core/src/main/java/org/hibernate/resource/beans/internal/StandardCdiLifecycleManagementStrategy.java
    A hibernate-core/src/main/java/org/hibernate/resource/beans/internal/UnnamedRegistryScopedManagedBeanImpl.java

  Log Message:
  -----------
  HHH-12133 Move CDI lifecycle management code to dedicated strategies

This commit should not change the current behavior, it is only about
moving code to separate classes to make the following changes clearer.


  Commit: c4d9f32c79a8b4fdd4e545fd05e693af7b6abb20
      https://github.com/hibernate/hibernate-orm/commit/c4d9f32c79a8b4fdd4e545fd05e693af7b6abb20
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/Helper.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/JpaCdiLifecycleManagementStrategy.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiDelayedImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiExtendedImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryCdiStandardImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/ManagedBeanRegistryDirectImpl.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/StandardCdiLifecycleManagementStrategy.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/spi/AbstractManagedBeanRegistry.java

  Log Message:
  -----------
  HHH-12133 Comply with API docs with respect to lifecycle management depending on the 'shouldRegistryManageLifecycle' parameter

The registry should not manage the bean lifecycle when
'shouldRegistryManageLifecycle' is false. The easiest way to do so is to
use BeanManager.createInstance to retrieve beans in the Standard CDI lifecycle
strategy: it correctly retrieves singletons from the CDI context instead
of instantiating them again.

Also, fix javax.enterprise.inject.spi.Bean-based instance destructions:
we used to only request destruction to the creational context, which is
wrong because it may skip the execution of @PostDestroy methods in
particular.


  Commit: 03561d2420759633cad3e6383c4ae7b846be0225
      https://github.com/hibernate/hibernate-orm/commit/03561d2420759633cad3e6383c4ae7b846be0225
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/Helper.java
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/JpaCdiLifecycleManagementStrategy.java

  Log Message:
  -----------
  HHH-12133 Use the BeanManager-provided ambiguous dependency resolution when possible

This should take care of @Alternative in particular.


  Commit: 4cdc392ada5fd7ab6c70dd08c771abc02474b060
      https://github.com/hibernate/hibernate-orm/commit/4cdc392ada5fd7ab6c70dd08c771abc02474b060
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/StandardCdiLifecycleManagementStrategy.java

  Log Message:
  -----------
  HHH-12133 Ignore managed bean release errors related to already released beans


  Commit: 55dfa7d9597bc53c1f025dceeeecba3ae6e14841
      https://github.com/hibernate/hibernate-orm/commit/55dfa7d9597bc53c1f025dceeeecba3ae6e14841
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/Monitor.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/NonRegistryManagedBeanConsumingIntegrator.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheAlternativeNamedApplicationScopedBeanImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheAlternativeNamedDependentBeanImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheApplicationScopedBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheDependentBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheEntity.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheMainNamedApplicationScopedBeanImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheMainNamedDependentBeanImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheNamedApplicationScopedBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheNamedDependentBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheNestedDependentBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheNonHibernateBeanConsumer.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/TheSharedApplicationScopedBean.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/delayed/NonRegistryManagedDelayedCdiSupportTest.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/extended/NonRegistryManagedExtendedCdiSupportTest.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/package-info.java
    A hibernate-core/src/test/java/org/hibernate/test/cdi/nonregistrymanaged/standard/NonRegistryManagedStandardCdiSupportTest.java

  Log Message:
  -----------
  HHH-12133 Add tests for uses of ManagedBeanRegistry with shouldRegistryManageLifecycle = false


  Commit: a4dfcc8f250f7fabcac121dbf9f16401d8744f15
      https://github.com/hibernate/hibernate-orm/commit/a4dfcc8f250f7fabcac121dbf9f16401d8744f15
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M hibernate-orm-modules/hibernate-orm-modules.gradle

  Log Message:
  -----------
  HHH-12171 Fix CDI version used in hibernate-orm-modules tests

We now require CDI 2.0, which is not included in WildFly 11.


Compare: https://github.com/hibernate/hibernate-orm/compare/84b82ed043b9^...a4dfcc8f250f