[hibernate-commits] [hibernate/hibernate-validator] c2b943: HV-1623 Extract class-level metadata from property...

GitHub noreply at github.com
Mon Jun 11 07:00:24 EDT 2018 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: c2b9432c6d91865d603ef8da3f7615ae86dbf616
      https://github.com/hibernate/hibernate-validator/commit/c2b9432c6d91865d603ef8da3f7615ae86dbf616
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/BeanMetaDataImpl.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ClassMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/descriptor/ClassDescriptorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java

  Log Message:
  -----------
  HV-1623 Extract class-level metadata from property metadata case


  Commit: 2714267e248917b930c5659b041d2abf4eb453a3
      https://github.com/hibernate/hibernate-validator/commit/2714267e248917b930c5659b041d2abf4eb453a3
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    A engine/src/main/java/org/hibernate/validator/internal/cfg/context/FieldPropertyConstraintMappingContextImpl.java
    A engine/src/main/java/org/hibernate/validator/internal/cfg/context/GetterPropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/PropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java

  Log Message:
  -----------
  HV-1623 Create different programmatic mapping contexts for getter and field

- create different implementations of PropertyConstraintMappingContextImpl
for getter and field to separate the logic.


  Commit: 088294218ef2059fc9a8c1e063a04ac13f177da5
      https://github.com/hibernate/hibernate-validator/commit/088294218ef2059fc9a8c1e063a04ac13f177da5
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConstructorConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/MethodConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanExecutable.java

  Log Message:
  -----------
  HV-1623 Make parameters more specific in programmatic API executable mapping contexts


  Commit: e6c9e485d5b93e6324575a1bd11feea8fb0be20f
      https://github.com/hibernate/hibernate-validator/commit/e6c9e485d5b93e6324575a1bd11feea8fb0be20f
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/cfg/context/PropertyTarget.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ContainerElementConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/PropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/test/java/org/hibernate/validator/test/cfg/ConstraintMappingTest.java

  Log Message:
  -----------
  HV-1623 Deprecate property() in programmatic API and introduce field() and getter() instead

- add two new methods field() and getter() to replace deprecated property()
- update property constraint mapping implementations to use generics and get rid of casting objects


  Commit: ba56ab3da36dc98ec10cab8564a4f8b484b8cc6d
      https://github.com/hibernate/hibernate-validator/commit/ba56ab3da36dc98ec10cab8564a4f8b484b8cc6d
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/util/Contracts.java

  Log Message:
  -----------
  HV-1623 Replace empty check in Contracts with null and empty check at the same time

- based on our usage of not empty check passed parameters should not be null as well hence the implementation of the check can use StringHelper.isNullOrEmptyString utility method.


  Commit: aa490b1fb96dacc2d1e5e15208f2f61db0360ccb
      https://github.com/hibernate/hibernate-validator/commit/aa490b1fb96dacc2d1e5e15208f2f61db0360ccb
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/descriptor/ConstraintDescriptorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/CrossParameterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterPropertyConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ParameterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ReturnValueConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/mapping/ConstrainedGetterStaxBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/mapping/CrossParameterStaxBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/mapping/ReturnValueStaxBuilder.java
    M engine/src/test/java/org/hibernate/validator/testutils/ConstraintValidatorInitializationHelper.java

  Log Message:
  -----------
  HV-1623 Introduce getter as a constraint location kind


  Commit: af0bb7b0f74843009357d9dfec7099910bc2a47b
      https://github.com/hibernate/hibernate-validator/commit/af0bb7b0f74843009357d9dfec7099910bc2a47b
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/BeanMetaDataImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/CrossParameterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ParameterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ReturnValueConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedElement.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedExecutable.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanGetter.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/mapping/CrossParameterStaxBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/mapping/ReturnValueStaxBuilder.java
    M engine/src/test/java/org/hibernate/validator/test/cfg/ConstraintMappingTest.java

  Log Message:
  -----------
  HV-1623 Introduce ConstrainedElementKind.GETTER


  Commit: 7740b9a4cf263271f823d098e18f0bd45d05c934
      https://github.com/hibernate/hibernate-validator/commit/7740b9a4cf263271f823d098e18f0bd45d05c934
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConfiguredConstraint.java
    A engine/src/main/java/org/hibernate/validator/internal/cfg/context/FieldConstraintMappingContextImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/cfg/context/FieldPropertyConstraintMappingContextImpl.java
    A engine/src/main/java/org/hibernate/validator/internal/cfg/context/GetterConstraintMappingContextImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/cfg/context/GetterPropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java
    R engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldPropertyConstraintLocation.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterConstraintLocation.java
    R engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterPropertyConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/PropertyConstraintLocation.java

  Log Message:
  -----------
  HV-1623 Stop the propagation of JavaBeanField/Getter

We don't need the elements to be typed so let's be looser to open the
gate for JSON properties (which will probably simply be treated as
fields).


  Commit: 34af9db3d15ebd804086516697b217cd9bac27d5
      https://github.com/hibernate/hibernate-validator/commit/34af9db3d15ebd804086516697b217cd9bac27d5
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    A engine/src/main/java/org/hibernate/validator/internal/cfg/context/AbstractPropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/FieldConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/GetterConstraintMappingContextImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/cfg/context/PropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/PropertyValidationContext.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/AbstractPropertyCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
    R engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/location/AbstractPropertyConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterConstraintLocation.java
    R engine/src/main/java/org/hibernate/validator/internal/metadata/location/PropertyConstraintLocation.java

  Log Message:
  -----------
  HV-1623 Rename a couple of classes to Abstract*


  Commit: 1355dceb2d024c962c2553c1c425ed73e0083c02
      https://github.com/hibernate/hibernate-validator/commit/1355dceb2d024c962c2553c1c425ed73e0083c02
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/AbstractPropertyConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/PropertyValidationContext.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/AbstractPropertyCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/AbstractPropertyConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedField.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/Callable.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/Constrainable.java
    A engine/src/main/java/org/hibernate/validator/internal/properties/Field.java
    A engine/src/main/java/org/hibernate/validator/internal/properties/Getter.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanField.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanGetter.java
    M engine/src/test/java/org/hibernate/validator/test/cfg/ConstraintMappingTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/metadata/provider/AnnotationMetaDataProviderTestBase.java

  Log Message:
  -----------
  HV-1623 Introduce Field and Getter as subclasses of Property


  Commit: 70f52adb38250083264a40863ea45a278659f415
      https://github.com/hibernate/hibernate-validator/commit/70f52adb38250083264a40863ea45a278659f415
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java

  Log Message:
  -----------
  HV-1623 Throw exception in case of unexpected constrainedElement class in property metadata

- need to throw an exception rather than just create it
- removed the usage of Optional as it isn't needed anymore


  Commit: 8130f3923201cc73bff7fcf093cf7de54ba5737c
      https://github.com/hibernate/hibernate-validator/commit/8130f3923201cc73bff7fcf093cf7de54ba5737c
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/AbstractPropertyCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/AbstractPropertyConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/Property.java
    A engine/src/main/java/org/hibernate/validator/internal/properties/PropertyAccessor.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanField.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanGetter.java

  Log Message:
  -----------
  HV-1623 Make the fields/getters accessible lazily


  Commit: c0bc36ad88407a0c617935942e17f4a18e3fde2d
      https://github.com/hibernate/hibernate-validator/commit/c0bc36ad88407a0c617935942e17f4a18e3fde2d
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanExecutable.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanField.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanParameter.java

  Log Message:
  -----------
  HV-1623 Reduce the memory footprint of the new reflection abstraction


  Commit: 20a8b1b1f8372c29a49f0bacfbdf672b1aed30ab
      https://github.com/hibernate/hibernate-validator/commit/20a8b1b1f8372c29a49f0bacfbdf672b1aed30ab
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/AnnotationProcessingOptionsImpl.java

  Log Message:
  -----------
  HV-1631 Avoid doing two lookups in the read methods of AnnotationProcessingOptionsImpl


  Commit: 2bf7f6373786805250d849b87c5741fae18826dd
      https://github.com/hibernate/hibernate-validator/commit/2bf7f6373786805250d849b87c5741fae18826dd
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/properties/javabean/JavaBeanConstructor.java

  Log Message:
  -----------
  HV-1623 Remove a useless usage of getDeclaringClass()


Compare: https://github.com/hibernate/hibernate-validator/compare/e42c4d94c41c...2bf7f6373786
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the hibernate-commits mailing list