[hibernate-commits] [hibernate/hibernate-validator] d44bfb: HV-1444 Adding additional performance test

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: d44bfb8949f1cd3f8c43070161d6cd280ddcaba5
      https://github.com/hibernate/hibernate-validator/commit/d44bfb8949f1cd3f8c43070161d6cd280ddcaba5
  Author: marko-bekhta <markob at prykladna.lviv.ua>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M performance/README.md
    M performance/src/main/java-bv2/org/hibernate/validator/performance/multilevel/MultiLevelContainerValidation.java

  Log Message:
  -----------
  HV-1444 Adding additional performance test


  Commit: 50df92430db8c1dc1a7c3c2697d194cecd4758c0
      https://github.com/hibernate/hibernate-validator/commit/50df92430db8c1dc1a7c3c2697d194cecd4758c0
  Author: marko-bekhta <markob at prykladna.lviv.ua>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/LegacyCollectionSupportValueExtractors.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    A engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/MultipleContainersAtTheSameTimeTest.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/CustomContainer.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/CustomContainerValueExtractor.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/ImprovedCustomContainer.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/ImprovedCustomContainerImpl.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/ImprovedCustomContainerValueExtractor.java

  Log Message:
  -----------
  HV-1444 Support container only detectable at runtime for cascaded
validation

Also introduce a cache for the value extractor resolution and unify the
resolution for the container element constraints and the cascading
validation.


  Commit: ff3c85166696e3a25e11d05ace18ef708392c878
      https://github.com/hibernate/hibernate-validator/commit/ff3c85166696e3a25e11d05ace18ef708392c878
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/MultipleContainersAtTheSameTimeTest.java

  Log Message:
  -----------
  HV-1444 Improvements to the comments and some minor cosmetic changes


  Commit: d6775816130a89d119721d70163498e624c631d5
      https://github.com/hibernate/hibernate-validator/commit/d6775816130a89d119721d70163498e624c631d5
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
    A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PotentiallyContainerCascadingMetaData.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/MultipleContainersAtTheSameTimeTest.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/ContainerWithAdditionalConstraints.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/ContainerWithAdditionalConstraintsExtractor.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/Pair.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/PairLeftValueExtractor.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/model/PairRightValueExtractor.java

  Log Message:
  -----------
  HV-1444 Adding potentially runtime container cascading metadata


  Commit: d884656915c4963f40a0d4d1dcdd653f1d971789
      https://github.com/hibernate/hibernate-validator/commit/d884656915c4963f40a0d4d1dcdd653f1d971789
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/valueextraction/MultipleContainersAtTheSameTimeTest.java

  Log Message:
  -----------
  HV-1444 Support having a global @Valid and @Valid on keys in a Map

Add some more comments to make things hopefully clearer.

Test fixes by Marko Bekhta:
- fixed the case with the Map - both global and local @Valid should be applied in that case and key/value should be validated
- fixed the case with custom container. As there are multiple extractors available we don't know to which a global @Valid should be applied hence an error is expected in such case.


  Commit: 4ff079d3b35983c9c80fd495f8362e470695cbd2
      https://github.com/hibernate/hibernate-validator/commit/4ff079d3b35983c9c80fd495f8362e470695cbd2
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PotentiallyContainerCascadingMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraints.java

  Log Message:
  -----------
  HV-1444 Expose the ValueExtractorResolver to avoid one level of indirection

We had the Javadoc in 2 copies which would have been a pain to maintain.

In passing, change the names of a few variables and methods for more
clarity.


  Commit: 535643a75128f20a2863afebea2b142e662ce259
      https://github.com/hibernate/hibernate-validator/commit/535643a75128f20a2863afebea2b142e662ce259
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1444 Removed an impossible case when getting maximally specific value extractor

- based on the logic and usage of this method we cannot have an empty set of candidates.


  Commit: 5e7d3d463b6d8e5cd89b9ab252f4c48488892297
      https://github.com/hibernate/hibernate-validator/commit/5e7d3d463b6d8e5cd89b9ab252f4c48488892297
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorFactoryImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1444 Clear the ValueExtractorResolver cache maps when closing the ValidatorFactory


  Commit: b73fe21f7f9a0e549a5231f3a9cb9bbbd9c120e9
      https://github.com/hibernate/hibernate-validator/commit/b73fe21f7f9a0e549a5231f3a9cb9bbbd9c120e9
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1444 Introduce a couple of micro optimizations


  Commit: 445b3e5c73168fb75ebb3ceb4ff54ab9dd921ee0
      https://github.com/hibernate/hibernate-validator/commit/445b3e5c73168fb75ebb3ceb4ff54ab9dd921ee0
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1444 Fix a typo in a method name


Compare: https://github.com/hibernate/hibernate-validator/compare/4845be714e00...445b3e5c7316