[hibernate-commits] [hibernate/hibernate-orm] 2a0b8f: HHH-12290 JPQL collection and positional broken

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: 2a0b8f24a9a706329fbdb3a0781601cd3cbb5929
      https://github.com/hibernate/hibernate-orm/commit/2a0b8f24a9a706329fbdb3a0781601cd3cbb5929
  Author: Laurent Almeras <laurent.almeras at kobalt-si.fr>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M hibernate-core/src/test/java/org/hibernate/jpa/test/query/QueryTest.java

  Log Message:
  -----------
  HHH-12290 JPQL collection and positional broken


  Commit: 7e77a6032b97633d2ca66cbd3b16bb9b55590902
      https://github.com/hibernate/hibernate-orm/commit/7e77a6032b97633d2ca66cbd3b16bb9b55590902
  Author: Dmitrii Bocharov <dbocharo at redhat.com>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java
    M hibernate-core/src/test/java/org/hibernate/jpa/test/query/QueryTest.java
    M hibernate-core/src/test/java/org/hibernate/test/jpa/ql/JPAQLComplianceTest.java

  Log Message:
  -----------
  HHH-12290 Add jpa compliance check for parameters mixture


  Commit: 0c8779e1ee6a8e93c44bc1969fc9cdafcc3b3757
      https://github.com/hibernate/hibernate-orm/commit/0c8779e1ee6a8e93c44bc1969fc9cdafcc3b3757
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/internal/util/StringHelper.java
    M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
    M hibernate-core/src/test/java/org/hibernate/test/util/StringHelperTest.java

  Log Message:
  -----------
  HHH-12290 Be stricter in how we find the first occurrence of a parameter

Currently, when looking for ?1, if would find the ?1 in ?13 if ?13 is
placed before ?1 in the parameter list.


  Commit: 4d9fb70114e8a3cd67a403901915a1e380a08377
      https://github.com/hibernate/hibernate-orm/commit/4d9fb70114e8a3cd67a403901915a1e380a08377
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/internal/util/StringHelper.java
    M hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
    M hibernate-core/src/test/java/org/hibernate/test/jpa/ql/JPAQLComplianceTest.java

  Log Message:
  -----------
  HHH-12290 Expand ordinal parameters to ordinal parameters

They used to be expanded to named parameters which causes problem with
strict JPA compliance as named and positional parameters cannot be
mixed.

The first value is replaced by the very same initial parameter position to avoid
gaps (these are not supported), then we replace the other values with max position
+ increment.


  Commit: 86da00d66f9d7a9f73556f9716b346c4276de581
      https://github.com/hibernate/hibernate-orm/commit/86da00d66f9d7a9f73556f9716b346c4276de581
  Author: Steve Ebersole <steve at hibernate.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M hibernate-core/src/test/java/org/hibernate/test/jpa/ql/JPAQLComplianceTest.java

  Log Message:
  -----------
  HHH-12290 - Failure with JPQL positional queries with collection parameter (IN statement for example)


Compare: https://github.com/hibernate/hibernate-orm/compare/07a0e1243a60...86da00d66f9d