[hibernate-commits] [hibernate/hibernate-search] 8b7b8e: HSEARCH-3163 Propagate exceptions to the environme...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 8b7b8ead5b3c25c4c77fc35d2fb1e0be561e21a9
      https://github.com/hibernate/hibernate-search/commit/8b7b8ead5b3c25c4c77fc35d2fb1e0be561e21a9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M orm/src/main/java/org/hibernate/search/hcore/impl/ExtendedBeanManagerSynchronizer.java
    M orm/src/main/java/org/hibernate/search/hcore/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3163 Propagate exceptions to the environment when bootstrap fails

This way, the environment synchronizer (WildFly for instance) is aware
that something went wrong.

Part of this change was copied from the Hibernate Search 6 POC, commit
9fbb02572f736707703eb5d475a0fe45d4514308.


  Commit: e9c9d537a288c82671e065eb4115affdb0f42b4d
      https://github.com/hibernate/hibernate-search/commit/e9c9d537a288c82671e065eb4115affdb0f42b4d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M orm/src/main/java/org/hibernate/search/hcore/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3163 Do not close the ORM SessionFactory upon bootstrap failure

As an integration into Hibernate ORM, this is simply not our job:

* when an environment synchronizer is used (WildFly), the synchronizer
should catch the exception and perform the appropriate shutdown
sequence, which should include shutting down Hibernate ORM.
* when no environment synchronizer is used, the session factory should
catch the exception and close itself. And it does: see the
SessionFactoryImpl constructor.


  Commit: 1c6b042f3fe1afee4454f2d4467eca806e0d46da
      https://github.com/hibernate/hibernate-search/commit/1c6b042f3fe1afee4454f2d4467eca806e0d46da
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    A integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/BootstrapFailureIT.java
    A integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/util/ManagementClientHelper.java

  Log Message:
  -----------
  HSEARCH-3163 Test that exceptions are propagated to WildFly when bootstrap fails


  Commit: c401e5b251435d6b2ecac8c971d7d36a21f7f2f7
      https://github.com/hibernate/hibernate-search/commit/c401e5b251435d6b2ecac8c971d7d36a21f7f2f7
  Author: Sanne Grinovero <sanne at hibernate.org>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/BootstrapFailureIT.java

  Log Message:
  -----------
  HSEARCH-3163 Remove some unnecessary resources from the testing deployment


Compare: https://github.com/hibernate/hibernate-search/compare/2dae5873e2d4...c401e5b25143
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.