[hibernate-commits] [hibernate/hibernate-search] c3de80: HSEARCH-3412 Move field projection tests to a dedi...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: c3de801af93fbe07bb9244ce603a6e1f07a6156d
      https://github.com/hibernate/hibernate-search/commit/c3de801af93fbe07bb9244ce603a6e1f07a6156d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java

  Log Message:
  -----------
  HSEARCH-3412 Move field projection tests to a dedicated test class

We're going to add even more tests, and the SearchProjectionIT class is
getting quite large... Let's do like we do for Sorts.


  Commit: 6463f43f67739e86b316069c650d9dbc405f1b3b
      https://github.com/hibernate/hibernate-search/commit/6463f43f67739e86b316069c650d9dbc405f1b3b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java

  Log Message:
  -----------
  HSEARCH-3412 Fix the "duplicated" test case in projection tests

It seems it was altered to only have one projection at some point, which
was obviously a mistake.


  Commit: 85f0471b31ca75e0d2ec5e7e593fa1dece45ae31
      https://github.com/hibernate/hibernate-search/commit/85f0471b31ca75e0d2ec5e7e593fa1dece45ae31
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M documentation/src/test/java/org/hibernate/search/documentation/gettingstarted/withhsearch/withanalysis/GettingStartedWithAnalysisIT.java
    M documentation/src/test/java/org/hibernate/search/documentation/gettingstarted/withhsearch/withoutanalysis/GettingStartedWithoutAnalysisIT.java
    M documentation/src/test/java/org/hibernate/search/documentation/gettingstarted/withouthsearch/GettingStartedWithoutHibernateSearchIT.java
    M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/OrmElasticsearchLibraryShowcaseIT.java
    M legacy/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/processor/impl/DefaultContextualErrorHandlerTest.java
    M legacy/engine/src/test/java/org/hibernate/search/test/analyzer/analyzerdef/AnalyzerDefAnnotationTest.java
    M legacy/engine/src/test/java/org/hibernate/search/test/configuration/IndexNameOverrideTest.java
    M legacy/engine/src/test/java/org/hibernate/search/test/configuration/TypeMetadataTest.java
    M legacy/engine/src/test/java/org/hibernate/search/test/engine/numeric/NumericFieldTest.java
    M legacy/engine/src/test/java/org/hibernate/search/testsupport/junit/SearchITHelper.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchClassBridgeIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchNullValueIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSpatialIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/deletebyquery/DeleteByQueryIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/deletebyquery/DeleteByQueryMultiTenancyIT.java
    M legacy/integrationtest/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/filter/ElasticsearchFilterIT.java
    M legacy/integrationtest/spring/src/test/java/org/hibernate/search/test/integration/spring/injection/SpringInjectionIT.java
    M legacy/integrationtest/wildfly/src/test/java/org/hibernate/search/test/integration/wildfly/cdi/CDIInjectionIT.java
    M legacy/jsr352/core/src/test/java/org/hibernate/search/jsr352/massindexing/impl/util/SerializationUtilTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/batchindexing/DatabaseMultitenancyTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/filter/fulltextfilterdef/FullTextFilterDefAnnotationTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/filter/fulltextfilterdefs/FullTextFilterDefsAnnotationTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/query/initandlookup/CriteriaObjectInitializerAndHierarchyInheritanceTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/query/objectloading/mixedhierarchy/ObjectLoadingCrossHierarchyTest.java
    M legacy/orm/src/test/java/org/hibernate/search/test/query/sorting/SortTest.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java

  Log Message:
  -----------
  HSEARCH-3412 Replace uses of containsOnly assertions in tests with containsExactlyInAnyOrder

Because that's what we actually meant: if there is the wrong number of
duplicates for a particular value, we want the assertion to fail.


  Commit: c9c65d96f54f14501b4c60eb8eb13484c287b96a
      https://github.com/hibernate/hibernate-search/commit/c9c65d96f54f14501b4c60eb8eb13484c287b96a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/converter/impl/ElasticsearchFieldConverter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/converter/impl/StandardFieldConverter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchFieldPredicateBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/StandardFieldPredicateBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/ElasticsearchFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/GeoPointFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/StandardFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchFieldSortBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/StandardFieldSortBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/AbstractFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/LuceneFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/StringFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/AbstractStandardLuceneFieldPredicateBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneFieldPredicateBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/GeoPointFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/LuceneFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/StandardFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractStandardLuceneFieldSortBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneFieldSortBuilderFactory.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/converter/FromIndexFieldValueConverter.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/converter/spi/PassThroughFromIndexFieldValueConverter.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/spi/UserIndexFieldConverter.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/ValueWrapper.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/ISBNBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/impl/DefaultEnumValueBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/impl/DefaultJavaUtilDateValueBridge.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/impl/StubSearchTargetModel.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/converter/impl/StubFieldConverter.java

  Log Message:
  -----------
  HSEARCH-3412 Correctly detect incompatible field types for projections on multiple indexes


  Commit: 5d2e1605b88c740c8eeb06aea98750e30906d274
      https://github.com/hibernate/hibernate-search/commit/5d2e1605b88c740c8eeb06aea98750e30906d274
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/ValueWrapper.java

  Log Message:
  -----------
  HSEARCH-3412 Test multi-index projections more thoroughly

The tests are still not perfect, but will be improved in
https://hibernate.atlassian.net/browse/HSEARCH-3307.


  Commit: 5fc32f2bd28883d470f583d04d5441b406efb0b3
      https://github.com/hibernate/hibernate-search/commit/5fc32f2bd28883d470f583d04d5441b406efb0b3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/MatchPredicateBuilderImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/RangePredicateBuilderImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/FieldSearchProjectionImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/FieldSortBuilderImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/converter/impl/ElasticsearchFieldConverter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/converter/impl/StandardFieldConverter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchFieldPredicateBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/StandardFieldPredicateBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/ElasticsearchFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/GeoPointFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/projection/impl/StandardFieldProjectionBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchFieldSortBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/StandardFieldSortBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractMatchPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractRangePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/FieldSearchProjectionImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/AbstractFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/BooleanFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/InstantFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/LocalDateFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/LuceneFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/StandardFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/converter/impl/StringFieldConverter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/AbstractStandardLuceneFieldPredicateBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneFieldPredicateBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/GeoPointFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/LuceneFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/projection/impl/StandardFieldProjectionBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractFieldSortBuilderImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractStandardLuceneFieldSortBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneFieldSortBuilderFactory.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/spi/IndexSchemaFieldDefinitionHelper.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/spi/UserIndexFieldConverter.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/impl/StubSearchTargetModel.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubFieldSearchProjection.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/converter/impl/StubFieldConverter.java

  Log Message:
  -----------
  HSEARCH-3412 Use clearer wording for DSL => Index and Index => Projection converter methods

As discussed here: https://github.com/hibernate/hibernate-search/pull/1823#discussion_r236331388


Compare: https://github.com/hibernate/hibernate-search/compare/a9fa126ecfd7...5fc32f2bd288
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.