[hibernate-commits] [hibernate/hibernate-search] b45d9c: HSEARCH-3384 Move environmnent-related code (servi...

Wed Oct 3 05:37:22 EDT 2018

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: b45d9c8a96588286f141503524b2c657f05bcad3
      https://github.com/hibernate/hibernate-search/commit/b45d9c8a96588286f141503524b2c657f05bcad3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendBuildContext.java
    R engine/src/main/java/org/hibernate/search/engine/common/BeanProvider.java
    R engine/src/main/java/org/hibernate/search/engine/common/BeanReference.java
    R engine/src/main/java/org/hibernate/search/engine/common/impl/BeanProviderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/DelegatingBuildContext.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/RootBuildContext.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationImpl.java
    R engine/src/main/java/org/hibernate/search/engine/common/impl/ServiceManagerImpl.java
    R engine/src/main/java/org/hibernate/search/engine/common/spi/BeanResolver.java
    R engine/src/main/java/org/hibernate/search/engine/common/spi/ImmutableBeanReference.java
    R engine/src/main/java/org/hibernate/search/engine/common/spi/ReflectionBeanResolver.java
    M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java
    R engine/src/main/java/org/hibernate/search/engine/common/spi/ServiceManager.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanProvider.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanProviderImpl.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/BeanResolver.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ImmutableBeanReference.java
    A engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ReflectionBeanResolver.java
    A engine/src/main/java/org/hibernate/search/engine/environment/service/impl/ServiceManagerImpl.java
    A engine/src/main/java/org/hibernate/search/engine/environment/service/spi/ServiceManager.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingBuildContext.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmBeanContainerBeanResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanResolverBridgeBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/BridgeBuildContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorBinder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BridgeBuildContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationMappingDefinitionImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorProvider.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyDocumentIdMappingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyFieldMappingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingContextImpl.java

  Log Message:
  -----------
  HSEARCH-3384 Move environmnent-related code (services, beans) to a dedicated package

  Commit: fe7c0ee703c8250ee544c66c8fb9dcc33d357867
      https://github.com/hibernate/hibernate-search/commit/fe7c0ee703c8250ee544c66c8fb9dcc33d357867
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    A engine/src/main/java/org/hibernate/search/engine/environment/service/spi/Service.java

  Log Message:
  -----------
  HSEARCH-3384 Copy the Service class from Search 5

  Commit: 3ffffbd0b9b0aae4bf5851eece799b238b8edf82
      https://github.com/hibernate/hibernate-search/commit/3ffffbd0b9b0aae4bf5851eece799b238b8edf82
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    A engine/src/main/java/org/hibernate/search/engine/environment/classloading/impl/AggregatedClassLoader.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoaderHelper.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoaderService.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoadingException.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/DefaultClassLoaderService.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/impl/ServiceManagerImpl.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/spi/ServiceManager.java
    M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java
    A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/DelegatingClassLoaderService.java

  Log Message:
  -----------
  HSEARCH-3384 Copy ClassLoaderService and related classes from Search 5

  Commit: ef2a8fab7866287e7e6db32d0fedf82406ce5647
      https://github.com/hibernate/hibernate-search/commit/ef2a8fab7866287e7e6db32d0fedf82406ce5647
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/impl/ServiceManagerImpl.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3384 Integrate ClassLoaderService into the bootstrap process

  Commit: 82a1c0125b36ef6dd513df70ac6d4971fd1edbb3
      https://github.com/hibernate/hibernate-search/commit/82a1c0125b36ef6dd513df70ac6d4971fd1edbb3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoaderHelper.java

  Log Message:
  -----------
  HSEARCH-3384 Use ClassLoaderService directly in ClassLoaderHelper

Instead of requiring to pass a ServiceManager which is only ever used to
retrieve the ClassLoaderService.

  Commit: ee791a34e1185ad847212e554fe71973eb44c253
      https://github.com/hibernate/hibernate-search/commit/ee791a34e1185ad847212e554fe71973eb44c253
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ReflectionBeanResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmBeanContainerBeanResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3384 Use the ClassLoaderService in ReflectionBeanResolver

  Commit: ba4d91bac63a55131a93391647259d24ea2be34c
      https://github.com/hibernate/hibernate-search/commit/ba4d91bac63a55131a93391647259d24ea2be34c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/DefaultElasticsearchClientFactory.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ReflectionBeanResolver.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classloading/impl/AggregatedClassLoader.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoaderHelper.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoaderService.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/ClassLoadingException.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classloading/spi/DefaultClassLoaderService.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/impl/AggregatedClassLoader.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoadingException.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassResolver.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/DefaultClassResolver.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/impl/ServiceManagerImpl.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/spi/ServiceManager.java
    R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/DelegatingClassLoaderService.java
    A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmClassLoaderServiceClassResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3384 Rename ClassLoaderService to ClassResolver

Reasons:

1) It's not a Service, at least not in the same way as other services in
Search. It cannot be loaded through the ServiceLoader, since it provides
access to the ServiceLoader.
2) Its purpose is not to load classes, but "resources" in general:
classes, files, services, ...
3) Renaming it to "ClassLoader", without the suffix, would obviously be
a mistake, and I can't think of another, meaningful suffix.
4) "ClassResolver" would be consistent with the "BeanResolver"
interface we already have.
5) "ClassResolver" fits the purpose of that interface: all of its
methods allow to load a class/resource/service or to get the URL of a
resource.
6) It's SPI, so this does not break APIs.

  Commit: 026b969bf8296b4a46e15682dd49c4f3b8c00319
      https://github.com/hibernate/hibernate-search/commit/026b969bf8296b4a46e15682dd49c4f3b8c00319
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassResolver.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/DefaultClassAndResourceResolver.java
    R engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/DefaultClassResolver.java
    A engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ResourceResolver.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/impl/ServiceManagerImpl.java
    M engine/src/main/java/org/hibernate/search/engine/environment/service/spi/ServiceManager.java
    A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmClassLoaderServiceClassAndResourceResolver.java
    R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmClassLoaderServiceClassResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3384 Split ClassResolver in two: ClassResolver and ResourceResolver

... so that ResourceResolver can more easily be overridden without
overridding the class-related features.

  Commit: 9221e155bdaef992778ebeb52e23880bc7c4cb19
      https://github.com/hibernate/hibernate-search/commit/9221e155bdaef992778ebeb52e23880bc7c4cb19
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmBeanContainerBeanResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java

  Log Message:
  -----------
  HSEARCH-3384 Sonar fix: unclosed resource

  Commit: e633149c293977eee1880428d8cdf82e320d6296
      https://github.com/hibernate/hibernate-search/commit/e633149c293977eee1880428d8cdf82e320d6296
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/impl/AggregatedClassLoader.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/DefaultClassAndResourceResolver.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmClassLoaderServiceClassAndResourceResolver.java

  Log Message:
  -----------
  HSEARCH-3384 Sonar fix: various code smells

  Commit: 62f495d1cb8bc5e83a45c20d430bb3306c4a5030
      https://github.com/hibernate/hibernate-search/commit/62f495d1cb8bc5e83a45c20d430bb3306c4a5030
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/impl/AggregatedClassLoader.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassResolver.java
    M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ResourceResolver.java
    M legacy/orm/src/main/java/org/hibernate/search/cfg/impl/DelegatingClassLoaderService.java

  Log Message:
  -----------
  HSEARCH-3384 Fix various comments in code imported from Search 5

Compare: https://github.com/hibernate/hibernate-search/compare/8917ca29c795...62f495d1cb8b
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.