[hibernate-commits] [hibernate/hibernate-search] fc24b4: HSEARCH-3335 Move the distribution module to the r...

GitHub noreply at github.com
Wed Oct 10 11:53:53 EDT 2018 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: fc24b4e30562426b408657113839e8c9812a4344
      https://github.com/hibernate/hibernate-search/commit/fc24b4e30562426b408657113839e8c9812a4344
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    A distribution/pom.xml
    A distribution/src/main/assembly/dist.xml
    R legacy/distribution/pom.xml
    R legacy/distribution/src/main/assembly/dist.xml
    M legacy/pom.xml

  Log Message:
  -----------
  HSEARCH-3335 Move the distribution module to the root of the project


  Commit: c7bd60a51febf61d70fa11667fe1de5e27bfa0d5
      https://github.com/hibernate/hibernate-search/commit/c7bd60a51febf61d70fa11667fe1de5e27bfa0d5
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3335 Pull most JavaEE provided dependencies from the legacy project to the root project

We know we will need those eventually, and we need to distribute these
dependencies in the distribution module, so let's do this now.


  Commit: 9a43b30aa79b9d34d5af962ebf2d37504e01ec36
      https://github.com/hibernate/hibernate-search/commit/9a43b30aa79b9d34d5af962ebf2d37504e01ec36
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M distribution/pom.xml
    M distribution/src/main/assembly/dist.xml
    M legacy/pom.xml
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3335 Distribute the Search 6 modules instead of the legacy modules


  Commit: d798b659f1d67f25f8608adb94e335e5f316109f
      https://github.com/hibernate/hibernate-search/commit/d798b659f1d67f25f8608adb94e335e5f316109f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M distribution/src/main/assembly/dist.xml

  Log Message:
  -----------
  HSEARCH-3335 Use strict filtering in the distribution module

So that we don't create incomplete assemblies by mistake.


  Commit: 83bcf221b1716402234860be65bbf2d39e51dfea
      https://github.com/hibernate/hibernate-search/commit/83bcf221b1716402234860be65bbf2d39e51dfea
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3335 Make sure the "reports" module will always be the last one

... in particular when we use the "dist" profile, which usually adds a
module at the very end. Now the distribution module will be added before
the "reports" module.


  Commit: ba1ddc7e9d14ef4689494f49048df971fbd202c1
      https://github.com/hibernate/hibernate-search/commit/ba1ddc7e9d14ef4689494f49048df971fbd202c1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M distribution/pom.xml
    M distribution/src/main/assembly/dist.xml

  Log Message:
  -----------
  HSEARCH-3335 Use moduleSets to organize the distribution bundles a bit without requiring to list dependencies explicitly

There are two main advantages of moduleSets over "root" dependencySets:

1. First and foremost, moduleSets don't suffer from the same "implicit
exclusion" as "root" dependencySets. With "root" dependencySets, each
dependencySet implicitly excludes any dependency that was included in
any of the previous dependencySets. Which currently is a nice "feature",
but it cannot be disabled it will cause problems at some point, for
example if we have two backends with a common dependency: the directory
for one of the backends will miss this dependency, and users may end up
with classpath issues.
2. With moduleSets, we can structure the bundle in such a way that our
modules are located in a given directory, while the dependencies are
located in another directory. We don't *have* to, but we can.


  Commit: b9bd8b5df30b9edbaa49642c538271a5229a09fc
      https://github.com/hibernate/hibernate-search/commit/b9bd8b5df30b9edbaa49642c538271a5229a09fc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M distribution/src/main/assembly/dist.xml

  Log Message:
  -----------
  HSEARCH-3335 Structure the distribution a bit more, separating external libraries from our own JARs

Not sure it's really an improvement, since the structure is
significantly more complex, and I don't think consumers of this bundle
will care much about which artifact comes from the Hibernate team and
which one comes from an external source.

But at least that's closer to what we used to offer...

After this patch, the structure is as follows:

$ tree hibernate-search-6.0.0-SNAPSHOT/dist
hibernate-search-6.0.0-SNAPSHOT/dist
├── backend
│   ├── elasticsearch
│   │   ├── hibernate-search-backend-elasticsearch-6.0.0-SNAPSHOT.jar
│   │   └── lib
│   │       └── required
│   │           ├── commons-codec-1.10.jar
│   │           ├── commons-logging-1.1.3.jar
│   │           ├── elasticsearch-rest-client-6.3.1.jar
│   │           ├── elasticsearch-rest-client-sniffer-6.3.1.jar
│   │           ├── gson-2.8.5.jar
│   │           ├── httpasyncclient-4.1.2.jar
│   │           ├── httpclient-4.5.2.jar
│   │           ├── httpcore-4.4.5.jar
│   │           ├── httpcore-nio-4.4.5.jar
│   │           └── jackson-core-2.8.10.jar
│   └── lucene
│       ├── hibernate-search-backend-lucene-6.0.0-SNAPSHOT.jar
│       └── lib
│           └── required
│               ├── lucene-analyzers-common-7.4.0.jar
│               ├── lucene-core-7.4.0.jar
│               ├── lucene-join-7.4.0.jar
│               └── lucene-sandbox-7.4.0.jar
├── engine
│   ├── hibernate-search-engine-6.0.0-SNAPSHOT.jar
│   ├── hibernate-search-util-internal-common-6.0.0-SNAPSHOT.jar
│   └── lib
│       └── required
│           └── jboss-logging-3.3.2.Final.jar
├── mapper
│   └── orm
│       ├── hibernate-search-mapper-pojo-6.0.0-SNAPSHOT.jar
│       ├── hibernate-search-orm-6.0.0-SNAPSHOT.jar
│       └── lib
│           └── required
│               ├── antlr-2.7.7.jar
│               ├── byte-buddy-1.8.17.jar
│               ├── classmate-1.3.4.jar
│               ├── dom4j-1.6.1.jar
│               ├── hibernate-commons-annotations-5.0.4.Final.jar
│               ├── hibernate-core-5.3.6.Final.jar
│               ├── jandex-2.0.5.Final.jar
│               ├── javassist-3.23.1-GA.jar
│               ├── javax.activation-api-1.2.0.jar
│               └── xml-apis-1.0.b2.jar
└── provided
    ├── cdi-api-2.0.jar
    ├── javax.batch-api-1.0.jar
    ├── javax.inject-1.jar
    ├── javax.persistence-api-2.2.jar
    ├── jboss-annotations-api_1.2_spec-1.0.2.Final.jar
    └── jboss-transaction-api_1.2_spec-1.1.1.Final.jar

For reference, before this patch, the structure was something like this:

$ tree hibernate-search-6.0.0-SNAPSHOT/dist
hibernate-search-6.0.0-SNAPSHOT/dist
├── backend
│   ├── elasticsearch
│   │   ├── commons-codec-1.10.jar
│   │   ├── commons-logging-1.1.3.jar
│   │   ├── elasticsearch-rest-client-6.3.1.jar
│   │   ├── elasticsearch-rest-client-sniffer-6.3.1.jar
│   │   ├── gson-2.8.5.jar
│   │   ├── hibernate-search-backend-elasticsearch-6.0.0-SNAPSHOT.jar
│   │   ├── httpasyncclient-4.1.2.jar
│   │   ├── httpclient-4.5.2.jar
│   │   ├── httpcore-4.4.5.jar
│   │   ├── httpcore-nio-4.4.5.jar
│   │   └── jackson-core-2.8.10.jar
│   └── lucene
│       ├── hibernate-search-backend-lucene-6.0.0-SNAPSHOT.jar
│       ├── lucene-analyzers-common-7.4.0.jar
│       ├── lucene-core-7.4.0.jar
│       ├── lucene-join-7.4.0.jar
│       └── lucene-sandbox-7.4.0.jar
├── engine
│   ├── hibernate-search-engine-6.0.0-SNAPSHOT.jar
│   ├── hibernate-search-util-internal-common-6.0.0-SNAPSHOT.jar
│   └── jboss-logging-3.3.2.Final.jar
├── mapper
│   └── orm
│       ├── antlr-2.7.7.jar
│       ├── byte-buddy-1.8.17.jar
│       ├── classmate-1.3.4.jar
│       ├── dom4j-1.6.1.jar
│       ├── hibernate-commons-annotations-5.0.4.Final.jar
│       ├── hibernate-core-5.3.6.Final.jar
│       ├── hibernate-search-mapper-pojo-6.0.0-SNAPSHOT.jar
│       ├── hibernate-search-orm-6.0.0-SNAPSHOT.jar
│       ├── jandex-2.0.5.Final.jar
│       ├── javassist-3.23.1-GA.jar
│       ├── javax.activation-api-1.2.0.jar
│       └── xml-apis-1.0.b2.jar
└── provided
    ├── cdi-api-2.0.jar
    ├── javax.batch-api-1.0.jar
    ├── javax.inject-1.jar
    ├── javax.persistence-api-2.2.jar
    ├── jboss-annotations-api_1.2_spec-1.0.2.Final.jar
    └── jboss-transaction-api_1.2_spec-1.1.1.Final.jar


  Commit: d4eeb025a1aa1f290ffae672c410b99d4bc2d33a
      https://github.com/hibernate/hibernate-search/commit/d4eeb025a1aa1f290ffae672c410b99d4bc2d33a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M distribution/src/main/assembly/dist.xml

  Log Message:
  -----------
  HSEARCH-3335 Move the provided libraries in the distribution bundle from dist/provided to dist/lib/provided

For consistency with the other subdirectories.


Compare: https://github.com/hibernate/hibernate-search/compare/418b573f2e25...d4eeb025a1aa
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the hibernate-commits mailing list