[hibernate-commits] [hibernate/hibernate-search] 96a6bd: HSEARCH-3563 Simplify the usage and implementation...

Yoann Rodière noreply at github.com
Wed Apr 17 03:52:54 EDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 96a6bde1cd78e0ee6ec35130c1d45874b83eab1a
      https://github.com/hibernate/hibernate-search/commit/96a6bde1cd78e0ee6ec35130c1d45874b83eab1a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-17 (Wed, 17 Apr 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchClientProvider.java

  Log Message:
  -----------
  HSEARCH-3563 Simplify the usage and implementation of ElasticsearchClientProvider

This class will get more complex in the next commits, so we'd better
clean up what we can now.


  Commit: 18009e5144e0532ae32ff073b75ebe2bb382fa17
      https://github.com/hibernate/hibernate-search/commit/18009e5144e0532ae32ff073b75ebe2bb382fa17
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-17 (Wed, 17 Apr 2019)

  Changed paths:
    M README.md
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchBackendSettings.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchDialectName.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchVersion.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchClientProvider.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    A backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchVersionTest.java
    M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactoryTest.java
    M documentation/src/main/asciidoc/backend-elasticsearch.asciidoc
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/bootstrap/ElasticsearchBootstrapIT.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/dialect/Elasticsearch5TestDialect.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/dialect/Elasticsearch60TestDialect.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/dialect/Elasticsearch67TestDialect.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/dialect/Elasticsearch7TestDialect.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/dialect/ElasticsearchTestDialect.java
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3563 Ask users to configure the Elasticsearch version instead of the dialect


  Commit: 427540957508171a183793cfeb1dc35aea8f3b9a
      https://github.com/hibernate/hibernate-search/commit/427540957508171a183793cfeb1dc35aea8f3b9a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-17 (Wed, 17 Apr 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchVersion.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchClientProvider.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchVersionTest.java
    M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientUtilsGetElasticsearchVersionTest.java
    M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactoryTest.java
    M documentation/src/main/asciidoc/backend-elasticsearch.asciidoc

  Log Message:
  -----------
  HSEARCH-3563 Introduce some leniency when interpreting the configured Elasticsearch version

E.g. allow "7" instead of forcing the user to pick "7.1.0" precisely.


  Commit: d24bec1897aa360f7ac05e49ea095712edc4e6f1
      https://github.com/hibernate/hibernate-search/commit/d24bec1897aa360f7ac05e49ea095712edc4e6f1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-17 (Wed, 17 Apr 2019)

  Changed paths:
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/Elasticsearch56Dialect.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/Elasticsearch60Dialect.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/Elasticsearch67Dialect.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/Elasticsearch7Dialect.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialect.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactory.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/model/impl/Elasticsearch56ModelDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/model/impl/Elasticsearch6ModelDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/model/impl/Elasticsearch7ModelDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/model/impl/ElasticsearchModelDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/protocol/impl/Elasticsearch56ProtocolDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/protocol/impl/Elasticsearch60ProtocolDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/protocol/impl/Elasticsearch67ProtocolDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/protocol/impl/Elasticsearch70ProtocolDialect.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/protocol/impl/ElasticsearchProtocolDialect.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchClientProvider.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchLinkImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchIndexAdministrationClient.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/IndexingBackendContext.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/link/impl/ElasticsearchLink.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/SearchBackendContext.java
    M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactoryTest.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/bootstrap/ElasticsearchBootstrapIT.java

  Log Message:
  -----------
  HSEARCH-3563 Split the Elasticsearch dialect in two: model dialect and protocol dialect

This way, users configuring the Elasticsearch version only have to be as
precise as necessary for the model dialect, and can leave it up to Search
to determine the protocol dialect.

In particular, this allows users to configure the version "6", and it
will work for both Elasticsearch 6.6 and 6.7.


Compare: https://github.com/hibernate/hibernate-search/compare/1dcd42fa9a0a...d24bec1897aa



More information about the hibernate-commits mailing list