[hibernate-commits] [hibernate/hibernate-search] 02f127: HSEARCH-3297 Remove unnecessary ceremony when appe...

Mon Apr 29 11:43:47 EDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 02f127a9f94ea8f435948f343a0891ced22efffb
      https://github.com/hibernate/hibernate-search/commit/02f127a9f94ea8f435948f343a0891ced22efffb
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/AbstractPojoImplicitReindexingResolverTypeNodeBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverter.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelNestedCompositeElement.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPathPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPathTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorTypeNodeBuilder.java
    M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverterTest.java

  Log Message:
  -----------
  HSEARCH-3297 Remove unnecessary ceremony when appending a property to a bound pojo model path

We used to fetch a handle, then pass it to the parent path to create
a new path. We can simply give the name to the parent path and let it
return the new path.

  Commit: e39182fdb484e6543817a79e3111783097b0c5ce
      https://github.com/hibernate/hibernate-search/commit/e39182fdb484e6543817a79e3111783097b0c5ce
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/AbstractPojoIndexingDependencyCollectorNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuildingHelper.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/binding/impl/PojoModelPathBinder.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/binding/impl/PojoModelPathWalker.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPath.java

  Log Message:
  -----------
  HSEARCH-3297 Introduce dedicated class for path walking algorithms

  Commit: 0ff40c543d790ca0ae8363b55d50be946eca564c
      https://github.com/hibernate/hibernate-search/commit/0ff40c543d790ca0ae8363b55d50be946eca564c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/lifecycle/CleanupIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorBaseIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/ProgrammaticMappingSmokeIT.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMetatadaContributor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverter.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/ContainerExtractorPath.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/PropertyAnnotationProcessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoPropertyAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoValueAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/PojoModelPath.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/PojoModelPathPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/PojoModelPathValueNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPath.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPathPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPathTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/path/impl/BoundPojoModelPathValueNode.java
    M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverterTest.java
    A mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/model/path/PojoModelPathTest.java

  Log Message:
  -----------
  HSEARCH-3297 Improve usability of PojoModelPath

We're going to use it more in the APIs, so it better be easy to use.

  Commit: 99ca71b376561be60eb05c9a67ac3d62748682e4
      https://github.com/hibernate/hibernate-search/commit/99ca71b376561be60eb05c9a67ac3d62748682e4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/IdentifierBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/PropertyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/RoutingKeyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/TypeBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/PropertyBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/RoutingKeyBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/TypeBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PropertyBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/RoutingKeyBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/TypeBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundPropertyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundRoutingKeyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundTypeBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoTypeDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorTypeNodeBuilder.java

  Log Message:
  -----------
  HSEARCH-3297 Allow bridges to declare dependencies explicitly instead of implicitly through accessors

  Commit: 41acb2241dfbda02edad48054faa4af2ba1729ba
      https://github.com/hibernate/hibernate-search/commit/41acb2241dfbda02edad48054faa4af2ba1729ba
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingEmbeddedBridgeIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingOverReindexingIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/AnnotationMappingDiscoveryIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/nonregression/automaticindexing/ContainedInThroughNonContainingIndexedType.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/bridge/CustomPropertyBridge.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/bridge/CustomTypeBridge.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AnnotationMappingDiscoveryIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/AnnotationMappingRoutingIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/ProgrammaticMappingRoutingIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/bridge/CustomPropertyBridge.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/bridge/CustomTypeBridge.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/testsupport/util/StartupStubBridge.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/AccountBorrowalSummaryBridge.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/MultiKeywordStringBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/PropertyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/RoutingKeyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/TypeBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/GeoPointBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/RoutingKeyBridgeRoutingKeyProvider.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/PojoElement.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/PojoElementAccessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/PojoModelCompositeElement.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/PojoModelElementAccessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoElementImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelNestedCompositeElement.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelPropertyElementAccessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelPropertyRootElement.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelRootElementAccessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelTypeRootElement.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoPropertyElementAccessor.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoRootElementAccessor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeNode.java

  Log Message:
  -----------
  HSEARCH-3297 Pass the bridged element directly to bridge "write" methods

So that users can declare dependencies explicitly and then use getters
directly to retrieve data from the bridged elements.

  Commit: 1b6017ccc1edfd1eba7207a3d003ae3e96891213
      https://github.com/hibernate/hibernate-search/commit/1b6017ccc1edfd1eba7207a3d003ae3e96891213
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AbstractAutomaticIndexingBridgeIT.java
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeAccessorsIT.java
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeExplicitDependenciesIT.java
    R integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/nonregression/automaticindexing/ContainedInThroughNonContainingIndexedType.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java

  Log Message:
  -----------
  HSEARCH-3297 Test bridges declaring dependencies explicitly

  Commit: 7b83bb56e352ecc6382a73b661969e108ada48f0
      https://github.com/hibernate/hibernate-search/commit/7b83bb56e352ecc6382a73b661969e108ada48f0
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/nonregression/automaticindexing/ContainedInThroughNonContainingIndexedType.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/AccountBorrowalSummaryBridge.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/MultiKeywordStringBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContext.java

  Log Message:
  -----------
  HSEARCH-3297 Use explicit dependency declaration in bridges where possible

That's likely to become the recommended way of implementing a bridge.

  Commit: 9a8a72a8751bab39291f9bd7d0c52c4730abcc46
      https://github.com/hibernate/hibernate-search/commit/9a8a72a8751bab39291f9bd7d0c52c4730abcc46
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AbstractAutomaticIndexingBridgeIT.java

  Log Message:
  -----------
  HSEARCH-3297 More clearly separate type and property bridge in automatic indexing ITs

  Commit: 460f6a48e8a9b2110d5e8bac6f723814b17d687d
      https://github.com/hibernate/hibernate-search/commit/460f6a48e8a9b2110d5e8bac6f723814b17d687d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmPathFilterFactory.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/PropertyBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/RoutingKeyBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/TypeBridgeBindingContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PropertyBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/RoutingKeyBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/TypeBridgeBindingContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundPropertyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundRoutingKeyBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundTypeBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoPropertyDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoTypeDependencyContext.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContextImpl.java
    R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoTypeDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoTypeDependencyContextImpl.java

  Log Message:
  -----------
  HSEARCH-3297 Allow property bridges to declare a dependency to *extracted elements* of the bridged property

I.e. basically allow bridges on container properties: List, Map, ...

  Commit: ef30129ae2874ea06cc4417b0a597b8f2c6830d3
      https://github.com/hibernate/hibernate-search/commit/ef30129ae2874ea06cc4417b0a597b8f2c6830d3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AbstractAutomaticIndexingBridgeIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeAccessorsIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeExplicitDependenciesIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java

  Log Message:
  -----------
  HSEARCH-3297 Test property bridges declaring a dependency to *extracted elements* of the bridged property

  Commit: 1cf74a49eec9a33966d4865a26f81758fd7682db
      https://github.com/hibernate/hibernate-search/commit/1cf74a49eec9a33966d4865a26f81758fd7682db
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java

  Log Message:
  -----------
  HSEARCH-3297 Move markForReindexing code from the value node to the type node

We're about to add a new feature, allowing users to mark paths for
reindexing explicitly, and this feature will also be available on type
bridges, which do not involve any "value" node. Thus we need to
reorganize the code a little bit.

  Commit: a0fd7aac1fafedb601aafc53c3856b374e05ae5a
      https://github.com/hibernate/hibernate-search/commit/a0fd7aac1fafedb601aafc53c3856b374e05ae5a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorPropertyNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java

  Log Message:
  -----------
  HSEARCH-3297 Remove modelPathFromRootEntityNode from dependency collector nodes

We're going to introduce nodes with no corresponding path, so there will
be no way to represent this path in such a node and below.

  Commit: 44bb7330d3ce46ba89305d15c778f9eb880103f3
      https://github.com/hibernate/hibernate-search/commit/44bb7330d3ce46ba89305d15c778f9eb880103f3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/AbstractPojoIndexingDependencyCollectorValueNode.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorDisjointValueNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoOtherEntityDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoPropertyDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoTypeDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/AbstractPojoBridgedElementDependencyContext.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoOtherEntityDependencyContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoTypeDependencyContextImpl.java

  Log Message:
  -----------
  HSEARCH-3297 Allow bridges to declare reindexing conditions explicitly

... instead of just implicitly by specifying the dependencies.

  Commit: b51632174f57630aab3fb397163471a5b0502f5f
      https://github.com/hibernate/hibernate-search/commit/b51632174f57630aab3fb397163471a5b0502f5f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeWorkPlan.java

  Log Message:
  -----------
  HSEARCH-3297 Force reindexing when entities contained in an indexed entity change

If we didn't, we would have a problem in the very exotic use case where
the indexed entity only depends on contained entities through bridges
that do not use the indexed entity directly, but use queries (see tests
in the next commits).

  Commit: 902c5b11e9faa368ba8de064b052a03248039744
      https://github.com/hibernate/hibernate-search/commit/902c5b11e9faa368ba8de064b052a03248039744
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeExplicitReindexingBaseIT.java
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingBridgeExplicitReindexingFunctionalIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoOtherEntityDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoPropertyDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoTypeDependencyContext.java

  Log Message:
  -----------
  HSEARCH-3297 Test bridges that declare reindexing explicitly

  Commit: 9657d89fc5661ca5fc2a4b36e2217fbbedaf6d78
      https://github.com/hibernate/hibernate-search/commit/9657d89fc5661ca5fc2a4b36e2217fbbedaf6d78
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/AnnotationMappingDiscoveryIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AnnotationMappingDiscoveryIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/testsupport/util/StartupStubBridge.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/MultiKeywordStringBridge.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoPropertyDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/PojoTypeDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/AbstractPojoBridgedElementDependencyContext.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoPropertyDependencyContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/dependency/impl/PojoTypeDependencyContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java

  Log Message:
  -----------
  HSEARCH-3297 Force bridge implementors to declare dependencies

That way, maybe they won't forget to call .getDependencies().use(...).

Compare: https://github.com/hibernate/hibernate-search/compare/53f25eb6ed9c...9657d89fc566