[hibernate-commits] [hibernate/hibernate-validator] 59372e: HV-1684 Fix value extraction logic to avoid stack ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 59372ef6b92138b0c6a347ea16cd655576715252
      https://github.com/hibernate/hibernate-validator/commit/59372ef6b92138b0c6a347ea16cd655576715252
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2019-01-04 (Fri, 04 Jan 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1684 Fix value extraction logic to avoid stack overflows

So as Gunnar discovered it, the issue is only triggered with constraints
on Maps as otherwise CollectionHelper#toImmutableSet() avoids the issue
when there is only one element. Maps have 2 value extractors.


  Commit: 5d056be276af7a1a7105f9cb7e56e1f475abf031
      https://github.com/hibernate/hibernate-validator/commit/5d056be276af7a1a7105f9cb7e56e1f475abf031
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2019-01-04 (Fri, 04 Jan 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1684 Fix lookup that was testing the value instead of the key

We used to have a non concurrent set and switched to a CHM but we were
still using contains() which was incorrect. Switching to a Set to avoid
this issue and have a clear contract.


Compare: https://github.com/hibernate/hibernate-validator/compare/7e18684fcc37...5d056be276af
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.