[hibernate-commits] [hibernate/hibernate-validator] d28812: HV-1684 Fix value extraction logic to avoid stack ...

GitHub noreply at github.com
Fri Jan 4 07:22:46 EST 2019


  Branch: refs/heads/6.0
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: d288122fa7a428e2348a5e8f20b50a18cbe2698e
      https://github.com/hibernate/hibernate-validator/commit/d288122fa7a428e2348a5e8f20b50a18cbe2698e
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2019-01-04 (Fri, 04 Jan 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1684 Fix value extraction logic to avoid stack overflows

So as Gunnar discovered it, the issue is only triggered with constraints
on Maps as otherwise CollectionHelper#toImmutableSet() avoids the issue
when there is only one element. Maps have 2 value extractors.


  Commit: 1a74a413d0e08030d17e87c047e16f370a9496b2
      https://github.com/hibernate/hibernate-validator/commit/1a74a413d0e08030d17e87c047e16f370a9496b2
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2019-01-04 (Fri, 04 Jan 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorResolver.java

  Log Message:
  -----------
  HV-1684 Fix lookup that was testing the value instead of the key

We used to have a non concurrent set and switched to a CHM but we were
still using contains() which was incorrect. Switching to a Set to avoid
this issue and have a clear contract.


  Commit: 014e27a7b43a4caa9bf9a7746ceb64c015eddf3a
      https://github.com/hibernate/hibernate-validator/commit/014e27a7b43a4caa9bf9a7746ceb64c015eddf3a
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2019-01-04 (Fri, 04 Jan 2019)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HV-1685 Upgrade the supported WildFly versions to 15.0.0 and 14.0.1


Compare: https://github.com/hibernate/hibernate-validator/compare/0ea0505e9225...014e27a7b43a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the hibernate-commits mailing list