[hibernate-commits] [hibernate/hibernate-search] b3766d: HSEARCH-3440 Define a proper SPI for the Directory...

Thu Jul 18 08:20:06 EDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: b3766d7a31ef48569fdb9d901b8df26595c1e0f4
      https://github.com/hibernate/hibernate-search/commit/b3766d7a31ef48569fdb9d901b8df26595c1e0f4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexingBackendContext.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryCreationContextImpl.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryHelper.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProvider.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProviderInitializationContextImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/MMapDirectoryProvider.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryCreationContext.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryHolder.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryProvider.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryProviderInitializationContext.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/SimpleDirectoryHolder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessor.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java
    M documentation/src/test/resources/META-INF/persistence.xml
    M documentation/src/test/resources/hibernate-test-backend-lucene.properties
    M integrationtest/backend/lucene/src/test/resources/backend-defaults.properties
    M integrationtest/jdk/java-modules/src/main/resources/hibernate.properties
    M integrationtest/showcase/library/src/main/resources/application-lucene.yaml
    M integrationtest/showcase/library/src/test/resources/application-test.yaml

  Log Message:
  -----------
  HSEARCH-3440 Define a proper SPI for the DirectoryProvider in the Lucene backend

  Commit: 1911d1c44cb5d1096611f35cdfc003b9167440af
      https://github.com/hibernate/hibernate-search/commit/1911d1c44cb5d1096611f35cdfc003b9167440af
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M documentation/src/test/resources/META-INF/persistence.xml
    M documentation/src/test/resources/hibernate-test-backend-lucene.properties
    M integrationtest/backend/lucene/src/test/resources/backend-defaults.properties
    M integrationtest/jdk/java-modules/src/main/resources/hibernate.properties
    M integrationtest/showcase/library/src/main/resources/application-lucene.yaml

  Log Message:
  -----------
  HSEARCH-3440 Rename the "local_directory" directory type to "local-directory"

Since we use dashes everywhere else for property values.

  Commit: 5551eb1b2443967458f7399a298b270097aea263
      https://github.com/hibernate/hibernate-search/commit/5551eb1b2443967458f7399a298b270097aea263
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M documentation/src/main/asciidoc/getting-started.asciidoc
    M documentation/src/test/resources/META-INF/persistence.xml
    M documentation/src/test/resources/hibernate-test-backend-lucene.properties
    M integrationtest/backend/lucene/src/test/resources/backend-defaults.properties
    M integrationtest/jdk/java-modules/src/main/resources/hibernate.properties
    M integrationtest/showcase/library/src/main/resources/application-lucene.yaml

  Log Message:
  -----------
  HSEARCH-3440 Set the default value of directory.type to "local-directory"

  Commit: d3c06788ad2d5d91af3d014eee19a90c2bc0554a
      https://github.com/hibernate/hibernate-search/commit/d3c06788ad2d5d91af3d014eee19a90c2bc0554a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Test the "local-directory" directory provider

  Commit: ce441b6a0f73b904de710313f26eb25325dcb5a2
      https://github.com/hibernate/hibernate-search/commit/ce441b6a0f73b904de710313f26eb25325dcb5a2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/FileSystemAccessStrategyName.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/FileSystemAccessStrategy.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalDirectoryProvider.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/MMapDirectoryProvider.java

  Log Message:
  -----------
  HSEARCH-3440 Restore support for configuring the filesystem access strategy

It was named "filesystem access type" or "FSDirectoryType" in Search 5.

  Commit: 1be2c63878f5cfb883ceee991df95d5a238b4353
      https://github.com/hibernate/hibernate-search/commit/1be2c63878f5cfb883ceee991df95d5a238b4353
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessor.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingIndexManager.java

  Log Message:
  -----------
  HSEARCH-3440 Add accessors to the Lucene index manager for testing purposes

  Commit: 8ac5fff928f4c7aaf9a4a0d67a87304f64a3a66c
      https://github.com/hibernate/hibernate-search/commit/8ac5fff928f4c7aaf9a4a0d67a87304f64a3a66c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalDirectoryIT.java
    M legacy/orm/src/test/java/org/hibernate/search/test/directoryProvider/FSDirectorySelectionTest.java

  Log Message:
  -----------
  HSEARCH-3440 Test filesystem access strategies with the "local-directory" directory provider

  Commit: 37585242cfe2637fbffc94ef516f06acf8f75626
      https://github.com/hibernate/hibernate-search/commit/37585242cfe2637fbffc94ef516f06acf8f75626
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBeanConfigurer.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProviderInitializationContextImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalDirectoryProvider.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryProviderInitializationContext.java

  Log Message:
  -----------
  HSEARCH-3440 Allow third parties to make their own DirectoryProvider available to users

  Commit: f248c639a576d2ee4aa2e20496657ddb97c7db2d
      https://github.com/hibernate/hibernate-search/commit/f248c639a576d2ee4aa2e20496657ddb97c7db2d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Move some test methods from LuceneLocalDirectoryIT to an abstract class

  Commit: b72eac86f1211e6c01462b7e5c2dd72dde10f9c3
      https://github.com/hibernate/hibernate-search/commit/b72eac86f1211e6c01462b7e5c2dd72dde10f9c3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractDirectoryIT.java
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/CustomDirectoryIT.java
    M legacy/orm/src/test/java/org/hibernate/search/test/directoryProvider/DirectoryLifecycleTest.java

  Log Message:
  -----------
  HSEARCH-3440 Test support for custom directory providers

  Commit: 714846d24ba69f83826ec4cae55b19bb4ff2ba4c
      https://github.com/hibernate/hibernate-search/commit/714846d24ba69f83826ec4cae55b19bb4ff2ba4c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBeanConfigurer.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalHeapDirectoryProvider.java

  Log Message:
  -----------
  HSEARCH-3440 Restore support for the local-heap directory provider

  Commit: 14df5c45e0496bb2352196941362f51a294e1a68
      https://github.com/hibernate/hibernate-search/commit/14df5c45e0496bb2352196941362f51a294e1a68
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalHeapDirectoryIT.java
    M legacy/orm/src/test/java/org/hibernate/search/test/directoryProvider/RamDirectoryTest.java

  Log Message:
  -----------
  HSEARCH-3440 Test the "local-heap" directory provider

  Commit: 1b1a0ff317c83c96619180cab37aebb9c3f53751
      https://github.com/hibernate/hibernate-search/commit/1b1a0ff317c83c96619180cab37aebb9c3f53751
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/LockingStrategyName.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProviderInitializationContextImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalDirectoryProvider.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalHeapDirectoryProvider.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/spi/DirectoryProviderInitializationContext.java

  Log Message:
  -----------
  HSEARCH-3440 Restore support for configuring lock factories in Lucene directories

  Commit: 00a61102f5bdd2b20c6e2300b03fd441f7e78497
      https://github.com/hibernate/hibernate-search/commit/00a61102f5bdd2b20c6e2300b03fd441f7e78497
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/LockingStrategyName.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProviderInitializationContextImpl.java

  Log Message:
  -----------
  HSEARCH-3440 Add a "filesystem" suffix to the name of the "simple" and "native" locking strategies

Because they can only be used with an FS-based directory, and the
corresponding lock factories even have the "FS" keyword in their name.

  Commit: 27e31495c76c07de293f38ff21120b0977211f30
      https://github.com/hibernate/hibernate-search/commit/27e31495c76c07de293f38ff21120b0977211f30
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractBuiltInDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalHeapDirectoryIT.java
    M legacy/orm/src/test/java/org/hibernate/search/test/directoryProvider/CustomLockProviderTest.java

  Log Message:
  -----------
  HSEARCH-3440 Test locking strategies with builtin directory providers

  Commit: dece0c0d4f1760ce60cefca2448e2c4ff3d77746
      https://github.com/hibernate/hibernate-search/commit/dece0c0d4f1760ce60cefca2448e2c4ff3d77746
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/LockingStrategyName.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryProviderInitializationContextImpl.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractBuiltInDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Rename the "single" locking strategy to "single-instance"

Because it doesn't make any sense without the suffix: it's about having
a single instance of the factory. In particular it's not about having a
single lock, since multiple locks can be created with the same factory,
just for different indexes.

  Commit: 0e22adba5057eeb56a1e88b981f8728e6c3e2691
      https://github.com/hibernate/hibernate-search/commit/0e22adba5057eeb56a1e88b981f8728e6c3e2691
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBeanConfigurer.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalDirectoryProvider.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalFileSystemDirectoryProvider.java
    R integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalDirectoryIT.java
    A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalFileSystemDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Rename the "local-directory" directory provider type to "local-filesystem"

To avoid confusion between filesystem directories and Lucene
directories.

  Commit: e7a8bb284734d2ceb8e30e0bf542ecfbacb907a7
      https://github.com/hibernate/hibernate-search/commit/e7a8bb284734d2ceb8e30e0bf542ecfbacb907a7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M documentation/src/main/asciidoc/backend-lucene.asciidoc

  Log Message:
  -----------
  HSEARCH-3440 Document directory providers in the Lucene backend

  Commit: 17aa46f7e1711102b280e28738fbf1c7dc4d9a5d
      https://github.com/hibernate/hibernate-search/commit/17aa46f7e1711102b280e28738fbf1c7dc4d9a5d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M documentation/src/main/asciidoc/backend-lucene.asciidoc

  Log Message:
  -----------
  HSEARCH-3440 Fix an outdated example in the Lucene backend documentation

  Commit: a6170b27e6765f38ce0a144e8b32b491f98811bf
      https://github.com/hibernate/hibernate-search/commit/a6170b27e6765f38ce0a144e8b32b491f98811bf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexingBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalFileSystemDirectoryProvider.java

  Log Message:
  -----------
  HSEARCH-3440 Factorize, clarify and harmonize error messages when initializing index directories

  Commit: 29585aef24825ed105205800c782103e20873aff
      https://github.com/hibernate/hibernate-search/commit/29585aef24825ed105205800c782103e20873aff
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractBuiltInDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/CustomDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Test setting the Lucene directory type to an invalid value

  Commit: 814f8e9f48794f125d949bc22711fa9901d65d06
      https://github.com/hibernate/hibernate-search/commit/814f8e9f48794f125d949bc22711fa9901d65d06
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractBuiltInDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/AbstractDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalFileSystemDirectoryIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/directory/LuceneLocalHeapDirectoryIT.java

  Log Message:
  -----------
  HSEARCH-3440 Test error messages when setting an FS-only locking factory on non-FS directory providers

Compare: https://github.com/hibernate/hibernate-search/compare/87b8f7a0dfbf...814f8e9f4879