[hibernate-commits] [hibernate/hibernate-validator] 8dc67c: HV-1701 Add integer type specific min/max validators

Marko Bekhta noreply at github.com
Thu Mar 7 11:55:00 EST 2019


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 8dc67c44e5ceb7e7435c09c3e5e956fe508bcfa4
      https://github.com/hibernate/hibernate-validator/commit/8dc67c44e5ceb7e7435c09c3e5e956fe508bcfa4
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2019-03-03 (Sun, 03 Mar 2019)

  Changed paths:
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MaxValidatorForShort.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForInteger.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/MinValidatorForShort.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/NumberComparatorHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/BaseMinMaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/engine/ConstraintValidatorCachingTest.java

  Log Message:
  -----------
  HV-1701 Add integer type specific min/max validators

- Add specific validators for min/max constraints and byte/short/integer
types as the existing common number one makes additional actions that can
be omitted in this case.


  Commit: c92d43cbe34bb4fb1321657acf2b1f5382899f69
      https://github.com/hibernate/hibernate-validator/commit/c92d43cbe34bb4fb1321657acf2b1f5382899f69
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2019-03-03 (Sun, 03 Mar 2019)

  Changed paths:
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMaxValidatorForShort.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForByte.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForInteger.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForNumber.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalMinValidatorForShort.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/number/bound/decimal/DecimalNumberComparatorHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java

  Log Message:
  -----------
  HV-1701 Add integer type specific DecimalMin/DecimalMax validators

- Make checks in Number validator for DecimalMin/DecimalMax to check for
double/float to capture infinity situation correctly. Also direct a check
of Big* types to corresponding methods
- Add specific validators for DecimalMin/DecimalMax constraints and
byte/short/integer types as the existing common number one makes
additional actions that can be omitted in this case.


  Commit: 3c80b5a3f95307618c5d305c0b27b4954b8e6366
      https://github.com/hibernate/hibernate-validator/commit/3c80b5a3f95307618c5d305c0b27b4954b8e6366
  Author: marko-bekhta <marko.prykladna at gmail.com>
  Date:   2019-03-07 (Thu, 07 Mar 2019)

  Changed paths:
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/BaseMinMaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java

  Log Message:
  -----------
  HV-1701 Add a couple more test cases

- for number test add more number types to cover the logic of
`compare(Number...)` and all ifs in it
- For DecimalM?? constraints added a case with decimal fraction in
constraint value. "integer" values should be already covered.


Compare: https://github.com/hibernate/hibernate-validator/compare/6a0aa4059ea7...3c80b5a3f953


More information about the hibernate-commits mailing list