[hibernate-commits] [hibernate/hibernate-search] e2d8ff: HSEARCH-3353 Move some scope information to the (E...

Yoann Rodière noreply at github.com
Wed May 15 02:46:00 EDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: e2d8fff2526d3649ae5b2099828cf2b6193356d2
      https://github.com/hibernate/hibernate-search/commit/e2d8fff2526d3649ae5b2099828cf2b6193356d2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/impl/ElasticsearchSearchContext.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/impl/ElasticsearchSearchScopeModel.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchIndexSearchScope.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryBuilderFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/SearchBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/impl/LuceneSearchContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneIndexSearchScope.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilderFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcher.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/SearchBackendContext.java

  Log Message:
  -----------
  HSEARCH-3353 Move some scope information to the (Elasticsearch|Lucene)SearchContext

Just to regroup all scope information used in search queries, because we
will need to add more information in the next few commits.


  Commit: c211b9b62c4c97464b5720a913a31fc50ab776ff
      https://github.com/hibernate/hibernate-search/commit/c211b9b62c4c97464b5720a913a31fc50ab776ff
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/ElasticsearchSearchQuery.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/builder/impl/ExplainWorkBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/ExplainWork.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ElasticsearchExtensionIT.java

  Log Message:
  -----------
  HSEARCH-3353 Add explain() methods to ElasticsearchSearchQuery


  Commit: e61ad62c552b79ded45d3e80854e172eef387ab1
      https://github.com/hibernate/hibernate-search/commit/e61ad62c552b79ded45d3e80854e172eef387ab1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java

  Log Message:
  -----------
  HSEARCH-3353 Rely on Futures.unwrappedExceptionJoin rather than join() in LuceneSearchQueryImpl

Not really related, just a problem I noticed and that I don't want to
reproduce for explain().


  Commit: d691c4e4e9bc0007a482bc4435a24301bdc926ee
      https://github.com/hibernate/hibernate-search/commit/d691c4e4e9bc0007a482bc4435a24301bdc926ee
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneQueryWorkOrchestrator.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubQueryWorkExecutionContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubQueryWorkOrchestrator.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcher.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneExecuteQueryWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneQueryWorkExecutionContext.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneSearchWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneStubWorkFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactory.java

  Log Message:
  -----------
  HSEARCH-3353 Remove LuceneSearcher and split its logic between orchestrator and work

The "explain" work will have to share the orchestrator logic, but not
the work logic, so it will be cleaner that way.
Also, this makes the query works more consistent with the index works:
the execution context contains the index writer for index works, and the
index reader for query works.


  Commit: 28d3f28d839c019d372fcbbf7d4db6976a4f4dbf
      https://github.com/hibernate/hibernate-search/commit/28d3f28d839c019d372fcbbf7d4db6976a4f4dbf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexingBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexDocumentWorkExecutor.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexWorkExecutor.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexWorkPlan.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/MultiTenancyStrategy.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneIndexWorkOrchestrator.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneQueryWorkOrchestrator.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneReadWorkOrchestrator.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubIndexWorkExecutionContext.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubIndexWorkOrchestrator.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubQueryWorkOrchestrator.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubReadWorkOrchestrator.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubWriteWorkExecutionContext.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneStubWriteWorkOrchestrator.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkOrchestrator.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/SearchBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneDeleteAllEntriesWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneDeleteEntryWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneUpdateEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneWriteWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneAddEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneCommitIndexWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneCommitWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneFlushIndexWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneFlushWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneIndexWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneIndexWorkExecutionContext.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneOptimizeIndexWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneOptimizeWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneQueryWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneReadWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneSearchWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneStubWorkFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactory.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWriteWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWriteWorkExecutionContext.java

  Log Message:
  -----------
  HSEARCH-3353 Rename LuceneIndexWork to LuceneWriteWork and LuceneQueryWork to LuceneReadWork

Just to make it clear what the difference between these works is.
LuceneIndexWork in particular was a bit ambiguous: it meant "a work that
performs indexing", but it could be understood as "a work about an
index".


  Commit: 6c080dd4ec6a008a49782406f703d2db6782b226
      https://github.com/hibernate/hibernate-search/commit/6c080dd4ec6a008a49782406f703d2db6782b226
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/LuceneSearchQuery.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneExplainWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneStubWorkFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactory.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/LuceneExtensionIT.java

  Log Message:
  -----------
  HSEARCH-3353 Add explain() methods to LuceneSearchQuery


Compare: https://github.com/hibernate/hibernate-search/compare/becc6c449940...6c080dd4ec6a



More information about the hibernate-commits mailing list