[hibernate-commits] [hibernate/hibernate-search] f4513b: HSEARCH-3757 Rename the (internal) constant HOST t...

Yoann Rodière noreply at github.com
Tue Nov 19 11:40:18 EST 2019 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: f4513b50a7ad5f944ee0ce6e465220dd35602857
      https://github.com/hibernate/hibernate-search/commit/f4513b50a7ad5f944ee0ce6e465220dd35602857
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java

  Log Message:
  -----------
  HSEARCH-3757 Rename the (internal) constant HOST to HOSTS in ElasticsearchClientFactoryImpl

Because it can provide multiple hosts.


  Commit: 6799405c7f3f0f0c040e4d9d754d2ad2023f3f56
      https://github.com/hibernate/hibernate-search/commit/6799405c7f3f0f0c040e4d9d754d2ad2023f3f56
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M Jenkinsfile
    M README.md
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3757 Remove the need for explicitly specifying that the Elasticsearch server is provided when running tests

If test.elasticsearch.host.url is set, the server is provided. If it's
not, then it's not provided.


  Commit: 3573167c62f1163657814752afb3a0861e30a43c
      https://github.com/hibernate/hibernate-search/commit/3573167c62f1163657814752afb3a0861e30a43c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M Jenkinsfile
    M README.md
    M documentation/src/test/resources/META-INF/persistence.xml
    M documentation/src/test/resources/hibernate-test-backend-elasticsearch.properties
    M integrationtest/backend/elasticsearch/pom.xml
    M integrationtest/jdk/java-modules/src/main/resources/hibernate.properties
    M integrationtest/showcase/library/pom.xml
    M pom.xml
    M util/internal/integrationtest/backend/elasticsearch/src/main/java/org/hibernate/search/util/impl/integrationtest/backend/elasticsearch/ElasticsearchTestHostConnectionConfiguration.java

  Log Message:
  -----------
  HSEARCH-3757 Refactor properties related to Elasticsearch tests used in POM

1. Because we're about to change the "hosts" property so that it doesn't
refer to a URL anymore, so test.elasticsearch.host.url doesn't make
sense.
2. Because test.elasticsearch.host.url doesn't match the actual
underlying property, which ends with "hosts" because there might be
*multiple* hosts.
3. To improve consistency.


  Commit: 61b3fb240dde943cd84d7e38aff6a5681d3c1e7f
      https://github.com/hibernate/hibernate-search/commit/61b3fb240dde943cd84d7e38aff6a5681d3c1e7f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M Jenkinsfile
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchBackendSettings.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ServerUris.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M documentation/src/main/asciidoc/backend-elasticsearch.asciidoc
    M documentation/src/test/resources/META-INF/persistence.xml
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/bootstrap/ElasticsearchBootstrapFailureIT.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchContentLengthIT.java
    M integrationtest/showcase/library/pom.xml
    M integrationtest/showcase/library/src/main/resources/application-elasticsearch.yaml
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3757 Specify the protocol for Elasticsearch connections in a dedicated configuration property


  Commit: 6e2a8982ef391c2bd04a4e1bd937e998e11450e6
      https://github.com/hibernate/hibernate-search/commit/6e2a8982ef391c2bd04a4e1bd937e998e11450e6
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchBackendSettings.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java
    M documentation/src/main/asciidoc/backend-elasticsearch.asciidoc

  Log Message:
  -----------
  HSEARCH-3757 Use the same protocol for discovered Elasticsearch nodes as for explicitly configured nodes


  Commit: ee09f8b72fbbf4ab705b1bdcf89c64bc4ec52d35
      https://github.com/hibernate/hibernate-search/commit/ee09f8b72fbbf4ab705b1bdcf89c64bc4ec52d35
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M integrationtest/backend/elasticsearch/pom.xml
    A integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchClientFactoryImplIT.java
    A integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/categories/RequiresNoAutomaticAuthenticationHeader.java
    M legacy/elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/DefaultElasticsearchClientFactoryTest.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/TestConfigurationProvider.java

  Log Message:
  -----------
  HSEARCH-3757 Copy DefaultElasticsearchClientFactoryTest from Search 5

So that we correctly test https support, in particular.


  Commit: 9c5dec0b234b0588d41415492a6b06ce7bc33b07
      https://github.com/hibernate/hibernate-search/commit/9c5dec0b234b0588d41415492a6b06ce7bc33b07
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3757 Upgrade Wiremock to 2.25.1

Hopefully this will rid us of this strange, transient error in
ElasticsearchClientFactoryImplIT:

java.lang.RuntimeException: java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 30000/30000 ms


  Commit: bb851de97450d7ea63365bf8154a6f729fd9313b
      https://github.com/hibernate/hibernate-search/commit/bb851de97450d7ea63365bf8154a6f729fd9313b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchBackendSettings.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/ExplicitShardingStrategy.java
    M documentation/src/main/asciidoc/backend-elasticsearch.asciidoc
    M documentation/src/main/asciidoc/configuration.asciidoc
    M engine/src/main/java/org/hibernate/search/engine/cfg/impl/OptionalPropertyContextImpl.java
    M engine/src/main/java/org/hibernate/search/engine/cfg/package-info.java
    M engine/src/main/java/org/hibernate/search/engine/cfg/spi/OptionalPropertyContext.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/ConfiguredBeanResolver.java
    M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java
    M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyInvalidSimpleValuesTest.java
    M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidMissingValuesTest.java
    M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidSimpleValuesTest.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchClientFactoryImplIT.java

  Log Message:
  -----------
  HSEARCH-3756 Use commas instead of string as a separator in multi-valued properties

Note that commas are illegal in hostnames, and even in
International Domain Names (IDNs).

See this page:

https://unicode.org/reports/tr36/idn-chars.html

Commas are listed under the "Illegal" section.


Compare: https://github.com/hibernate/hibernate-search/compare/d2643f833add...bb851de97450

More information about the hibernate-commits mailing list