[hibernate-commits] [hibernate/hibernate-search] 72bd77: HSEARCH-3739 Clean up org.hibernate.search.util.co...

Yoann Rodière noreply at github.com
Fri Oct 25 03:31:14 EDT 2019 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 72bd77635356678e52ebde1c37f706dc1e68c7a9
      https://github.com/hibernate/hibernate-search/commit/72bd77635356678e52ebde1c37f706dc1e68c7a9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M util/common/src/main/java/org/hibernate/search/util/common/impl/Executors.java

  Log Message:
  -----------
  HSEARCH-3739 Clean up org.hibernate.search.util.common.impl.Executors


  Commit: 8e74e2c6992f8daf9c745494ce88d6b039bdb49e
      https://github.com/hibernate/hibernate-search/commit/8e74e2c6992f8daf9c745494ce88d6b039bdb49e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/cfg/spi/EngineSpiSettings.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/ConfiguredBeanResolver.java
    M engine/src/test/java/org/hibernate/search/engine/environment/bean/impl/ConfiguredBeanResolverTest.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/lifecycle/CleanupIT.java

  Log Message:
  -----------
  HSEARCH-3739 Add the missing prefix to EngineSpiSettings constants


  Commit: 1ae13a6f5a8446ba0b4f30323f90f5c6bdc25f4b
      https://github.com/hibernate/hibernate-search/commit/1ae13a6f5a8446ba0b4f30323f90f5c6bdc25f4b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/spi/ElasticsearchClientFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchLinkImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchBatchingWorkOrchestrator.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessor.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/HibernateSearchConcurrentMergeScheduler.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneBatchingWriteWorkOrchestrator.java
    M engine/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java
    M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendBuildContext.java
    M engine/src/main/java/org/hibernate/search/engine/cfg/spi/EngineSpiSettings.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/DelegatingBuildContext.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/RootBuildContext.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationImpl.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationPartialBuildStateImpl.java
    A engine/src/main/java/org/hibernate/search/engine/environment/thread/impl/DefaultThreadProvider.java
    A engine/src/main/java/org/hibernate/search/engine/environment/thread/impl/SimpleThreadFactory.java
    A engine/src/main/java/org/hibernate/search/engine/environment/thread/impl/ThreadPoolProviderImpl.java
    A engine/src/main/java/org/hibernate/search/engine/environment/thread/spi/ThreadPoolProvider.java
    A engine/src/main/java/org/hibernate/search/engine/environment/thread/spi/ThreadProvider.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingBuildContext.java
    M engine/src/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchContentLengthIT.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchClientSpy.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/HibernateOrmMassIndexingMappingContext.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoMappingDelegateImpl.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingDelegate.java
    R util/common/src/main/java/org/hibernate/search/util/common/impl/Executors.java
    R util/common/src/main/java/org/hibernate/search/util/common/impl/SearchThreadFactory.java
    M util/internal/integrationtest/backend/elasticsearch/src/main/java/org/hibernate/search/util/impl/integrationtest/backend/elasticsearch/rule/TestElasticsearchClient.java

  Log Message:
  -----------
  HSEARCH-3739 Move Executors' static methods to an instantiated, customizable component

So that we can change the thread provider to spy on thread
instantiations.


  Commit: bb971d31bb8da1dceb4c849bdfc038da8cf55772
      https://github.com/hibernate/hibernate-search/commit/bb971d31bb8da1dceb4c849bdfc038da8cf55772
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java

  Log Message:
  -----------
  HSEARCH-3739 Use more sensible names for MassIndexer threads

It's necessary to be able to properly retrieve threads by their name in
tests, and it won't hurt that the names will be more clear for users.


  Commit: 117d51dabcf9c20faec95f9342f97aba2b2c0b9c
      https://github.com/hibernate/hibernate-search/commit/117d51dabcf9c20faec95f9342f97aba2b2c0b9c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/ThreadSpy.java

  Log Message:
  -----------
  HSEARCH-3739 Add ThreadSpy to execute assertions on threads created by Hibernate Search


  Commit: cb1c8512682bbacdeda16e3758894fbf954b2d5d
      https://github.com/hibernate/hibernate-search/commit/cb1c8512682bbacdeda16e3758894fbf954b2d5d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java
    M util/common/src/main/java/org/hibernate/search/util/common/impl/Futures.java

  Log Message:
  -----------
  HSEARCH-3739 Use CompletableFuture.get() instead of .join() to synchronize MassIndexer threads

So that the threads can be interrupted.


  Commit: 91bb052c49577a038e39c6b2134f544fc3c936af
      https://github.com/hibernate/hibernate-search/commit/91bb052c49577a038e39c6b2134f544fc3c936af
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    A util/common/src/main/java/org/hibernate/search/util/common/impl/CancellableExecutionCompletableFuture.java
    M util/common/src/main/java/org/hibernate/search/util/common/impl/Futures.java
    A util/common/src/test/java/org/hibernate/search/util/common/impl/CancellableExecutionCompletableFutureTest.java
    M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/FutureAssert.java

  Log Message:
  -----------
  HSEARCH-3739 Add an improved version of CompletableFuture.runAsync with cancellation


  Commit: 83ef321bdf3a025d18862eb66b47214031fb9764
      https://github.com/hibernate/hibernate-search/commit/83ef321bdf3a025d18862eb66b47214031fb9764
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java

  Log Message:
  -----------
  HSEARCH-3739 Avoid the use of CompletableFuture.runAsync


  Commit: 2e9ccf837f26b8d68dcfd541bfdbb2ad36059bbc
      https://github.com/hibernate/hibernate-search/commit/2e9ccf837f26b8d68dcfd541bfdbb2ad36059bbc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M build-config/src/main/resources/forbidden-runtime.txt

  Log Message:
  -----------
  HSEARCH-3739 Add CompletableFuture.runAsync to forbidden APIs


  Commit: d448dcab4b8b839161f8aeea18dd77c69cb26e95
      https://github.com/hibernate/hibernate-search/commit/d448dcab4b8b839161f8aeea18dd77c69cb26e95
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java

  Log Message:
  -----------
  HSEARCH-3739 Use a ThreadPool instead of a ForkJoinPool for asynchronous mass indexing

The ForkJoinPool does not use interruption to cancel tasks, which makes
it hard to integrate to the current implementation of MassIndexer where
everything uses interruptions for cancellation.


  Commit: 19c1ce73a82ad61082c39d7b0529e39b9f36359f
      https://github.com/hibernate/hibernate-search/commit/19c1ce73a82ad61082c39d7b0529e39b9f36359f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java

  Log Message:
  -----------
  HSEARCH-3739 Reset the interrupt flag when throwing InterruptedException


  Commit: 2674589742cec696de80c5df455d8721bff419ca
      https://github.com/hibernate/hibernate-search/commit/2674589742cec696de80c5df455d8721bff419ca
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureIT.java
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingInterruptionIT.java

  Log Message:
  -----------
  HSEARCH-3739 Test interruption and cancelling of mass indexing


Compare: https://github.com/hibernate/hibernate-search/compare/d9a2e393f97a...2674589742ce

More information about the hibernate-commits mailing list