[hibernate-commits] [hibernate/hibernate-search] f738f7: HSEARCH-3748 Remove the bridge-based programmatic ...

[Yoann Rodière]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: f738f716d2246f28175fd348ab80dd41ebc05a4c
      https://github.com/hibernate/hibernate-search/commit/f738f716d2246f28175fd348ab80dd41ebc05a4c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-10-30 (Wed, 30 Oct 2019)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/impl/BeanBinder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/TypeMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/DelegatingPropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java

  Log Message:
  -----------
  HSEARCH-3748 Remove the bridge-based programmatic mapping APIs for TypeBridge, PropertyBridge and RoutingKeyBridge

I.e. the APIs where we don't specify a binder, but a bridge directly.

These APIs are not documented, not tested, but more importantly they
are pointless: defining a brige this way simply cannot work, because
there would be no binder to define the dependencies of the bridge,
so Hibernate Search would simply throw an exception on bootstrap
because of the unknown dependencies.

Even more critical, for the TypeBridge and PropertyBridge, applying a
bridge without a binder would mean that the bridge does not have any
index field reference to work with, so it effectively cannot write to
the index.