[hibernate-commits] [hibernate/hibernate-search] f9eca3: HSEARCH-3705 Simplify some code in the engine

Yoann Rodière noreply at github.com
Tue Sep 17 11:08:45 EDT 2019 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: f9eca3eaa95295a4f55e4b9ae707e16639109463
      https://github.com/hibernate/hibernate-search/commit/f9eca3eaa95295a4f55e4b9ae707e16639109463
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java

  Log Message:
  -----------
  HSEARCH-3705 Simplify some code in the engine


  Commit: 8aeab96bcd8834d82bd1182efffa8c4600ff6d4b
      https://github.com/hibernate/hibernate-search/commit/8aeab96bcd8834d82bd1182efffa8c4600ff6d4b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M documentation/src/test/resources/META-INF/persistence.xml

  Log Message:
  -----------
  HSEARCH-3705 Use distinct Lucene index roots for tests of the getting started guide

Otherwise, the changes we're about to make will lead to tests reusing
the same index directory (because the entity names are the same).


  Commit: 1b3ff22e580805210f6d684731309d244d1afe29
      https://github.com/hibernate/hibernate-search/commit/1b3ff22e580805210f6d684731309d244d1afe29
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanEntityTypeContributor.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanTypeConfigurationContributor.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmEntityTypeMetadataContributor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/spi/PojoAdditionalMetadataCollectorTypeNode.java

  Log Message:
  -----------
  HSEARCH-3705 Make sure entity metadata is not inherited

Because a child class of an entity is not always itself an entity;
in Hibernate ORM, it could be a mapped superclass, for example.


  Commit: b2c6bd5f6d2779ad32afb0745fd661de719e100f
      https://github.com/hibernate/hibernate-search/commit/b2c6bd5f6d2779ad32afb0745fd661de719e100f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/spi/OptionalEmptyAsDefaultFormatter.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorProvider.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/IndexedMetadataContributor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoIndexedTypeAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataBuilder.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/spi/PojoAdditionalMetadataCollectorIndexedTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/spi/PojoAdditionalMetadataCollectorTypeNode.java
    A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/impl/PojoIndexedTypeAdditionalMetadata.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/impl/PojoTypeAdditionalMetadata.java

  Log Message:
  -----------
  HSEARCH-3705 Add backend and index name to the POJO additional metadata

For now the metadata is useless, but it will find its use in the next
commits.


  Commit: be929dfca72583e5cef800af2f97727e75184a76
      https://github.com/hibernate/hibernate-search/commit/be929dfca72583e5cef800af2f97727e75184a76
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java
    M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java
    A engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexManagerBuildingStateProvider.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/Mapper.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingConfigurationCollector.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/model/spi/MappableTypeModel.java
    M engine/src/test/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolderTest.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedIT.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationMappingConfigurationContextImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/AbstractPojoMappingInitiator.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingInitiator.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubTypeMetadataContributor.java

  Log Message:
  -----------
  HSEARCH-3705 Move the assignment of index names to a later step in the bootstrapping process

... so that we can rely on metadata such as the entity name (see next
commits).


  Commit: 397bf0e1f63a9892b09f6ff514b8a31a770856f1
      https://github.com/hibernate/hibernate-search/commit/397bf0e1f63a9892b09f6ff514b8a31a770856f1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanEntityTypeContributor.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanMappingInitiator.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanTypeConfigurationContributor.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/log/impl/Log.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/SearchMappingBuilder.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmEntityTypeMetadataContributor.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoEntityTypeAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataBuilder.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/spi/PojoAdditionalMetadataCollectorTypeNode.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/impl/PojoEntityTypeAdditionalMetadata.java

  Log Message:
  -----------
  HSEARCH-3705 Include the entity name in the POJO entity type metadata

To be used later as a default for index names.


  Commit: 72fcac12a401ff6c39f98d453c04092862aa759c
      https://github.com/hibernate/hibernate-search/commit/72fcac12a401ff6c39f98d453c04092862aa759c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/AnnotationMappingDiscoveryIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AnnotationMappingDiscoveryIT.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java

  Log Message:
  -----------
  HSEARCH-3705 Fail fast if a non-entity type is mapped to an index


  Commit: c667407f762c340cc7992267aabe3fe12394b84b
      https://github.com/hibernate/hibernate-search/commit/c667407f762c340cc7992267aabe3fe12394b84b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc
    M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/entityindexmapping/Author.java
    M documentation/src/test/java/org/hibernate/search/documentation/search/projection/ProjectionDslIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedIT.java
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/model/ImplementedInterfaceIT.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
    M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/Indexed.java

  Log Message:
  -----------
  HSEARCH-3705 Use the entity name as default index name instead of the FQCN


  Commit: d8c839801e991c254d299ca89623564d49b56b73
      https://github.com/hibernate/hibernate-search/commit/d8c839801e991c254d299ca89623564d49b56b73
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedIT.java

  Log Message:
  -----------
  HSEARCH-3705 Test that indexed entity types use the entity name as default index name


  Commit: 06ec5411b90df81dab84c72f45f2f8859ad02536
      https://github.com/hibernate/hibernate-search/commit/06ec5411b90df81dab84c72f45f2f8859ad02536
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M documentation/src/test/java/org/hibernate/search/documentation/analysis/AnalysisIT.java
    M documentation/src/test/java/org/hibernate/search/documentation/search/query/Book.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/model/Book.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/model/Library.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/model/Person.java
    M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/model/Video.java

  Log Message:
  -----------
  HSEARCH-3705 Remove a few unnecessary uses of @Indexed.index


Compare: https://github.com/hibernate/hibernate-search/compare/6ced99c42e47...06ec5411b90d

More information about the hibernate-commits mailing list