[hibernate-commits] [hibernate/hibernate-search] bf57ef: HSEARCH-3885 Pass the inner predicate to the neste...

[Yoann Rodière]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: bf57ef2c1c700afeb93d6434be29ff88de33e56e
      https://github.com/hibernate/hibernate-search/commit/bf57ef2c1c700afeb93d6434be29ff88de33e56e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/search/predicate/dsl/impl/NestedPredicateFieldStepImpl.java

  Log Message:
  -----------
  HSEARCH-3885 Pass the inner predicate to the nested predicate builder immediately

... instead of delaying until the call to toImplementation().
Because:

1. We no longer need this delay, like we did when the DSL was more
   complicated.
2. Removing this delay allows us to throw exceptions in the nested()
   method if the given predicate is not compatible with the nested
   predicate, leading to a clearer stacktrace for users.


  Commit: f8fb68375dd0d25dd9097aba50b38cf754236183
      https://github.com/hibernate/hibernate-search/commit/f8fb68375dd0d25dd9097aba50b38cf754236183
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/AbstractElasticsearchNestablePredicateBuilder.java
    R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/AbstractElasticsearchSearchNestedPredicateBuilder.java
    A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/AbstractElasticsearchSingleFieldPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchBooleanPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchExistsPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchAllPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchIdPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchNestedPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchRangePredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchSearchPredicate.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchSearchPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchSearchPredicateBuilderFactoryImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchSearchPredicateContext.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchSimpleQueryStringPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchUserProvidedJsonPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinBoundingBoxPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinCirclePredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinPolygonPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchStandardMatchPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchTextPhrasePredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchTextWildcardPredicateBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/AbstractElasticsearchDocumentValueSortBuilder.java

  Log Message:
  -----------
  HSEARCH-3885 Throw exceptions when attempting to use predicate with incompatible nested path hierarchy in a nested predicate for Elasticsearch


  Commit: ba348ecb9674dc0a36d73ebd04e84fcb4d8bd11f
      https://github.com/hibernate/hibernate-search/commit/ba348ecb9674dc0a36d73ebd04e84fcb4d8bd11f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/NestedSearchPredicateIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/DistanceSearchSortTypeFilteringSpecificsIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortTypeFilteringSpecificsIT.java

  Log Message:
  -----------
  HSEARCH-3885 Test exceptions when attempting to use predicate with incompatible nested path hierarchy in a nested predicate


  Commit: bc8611c6944b0c71e3414e9ba14b0e4e8bee68d3
      https://github.com/hibernate/hibernate-search/commit/bc8611c6944b0c71e3414e9ba14b0e4e8bee68d3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSearchNestedPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSearchPredicateBuilder.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSingleFieldPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinBoundingBoxPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinCirclePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinPolygonPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneStandardMatchPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneStandardRangePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneBooleanPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneMatchAllPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneMatchIdPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneNestedPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneSearchPredicate.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneSearchPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneSearchPredicateBuilderFactoryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneSimpleQueryStringPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneUserProvidedLuceneQueryPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneExistsCompositePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneExistsPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneObjectPredicateBuilderFactoryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextPhrasePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextWildcardPredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractLuceneDocumentValueSortBuilder.java

  Log Message:
  -----------
  HSEARCH-3885 Throw exceptions when attempting to use predicate with incompatible nested path hierarchy in a nested predicate for Lucene


  Commit: 73f107a9a1e475830b0bb3cd20091b5248607e6c
      https://github.com/hibernate/hibernate-search/commit/73f107a9a1e475830b0bb3cd20091b5248607e6c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/ImplicitNestedSearchPredicateIT.java

  Log Message:
  -----------
  HSEARCH-3885 Use queries instead of lists of hits in ImplicitNestedSearchPredicateIT

So that the error message includes the query when an assertion fails.


  Commit: 71582e27d71eb4e44cbb757537fc3970136ababb
      https://github.com/hibernate/hibernate-search/commit/71582e27d71eb4e44cbb757537fc3970136ababb
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneNestedPredicateBuilder.java

  Log Message:
  -----------
  HSEARCH-3885 Clarify the purpose of the parent path passed to LuceneNestedPredicateBuilder.doBuild


  Commit: 03f6bd5d4468882d33bc3070c627ac4b049b32b4
      https://github.com/hibernate/hibernate-search/commit/03f6bd5d4468882d33bc3070c627ac4b049b32b4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/AbstractElasticsearchNestablePredicateBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java

  Log Message:
  -----------
  HSEARCH-3885 Simplify some loops traversing the hierarchy of nested paths


Compare: https://github.com/hibernate/hibernate-search/compare/2a4fbaafe46a...03f6bd5d4468