[hibernate-commits] [hibernate/hibernate-search] 599733: HSEARCH-3881 Filtering multi values for aggregations

Yoann Rodière noreply at github.com
Thu Apr 16 06:58:36 EDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 5997333bfca20e01687c7026f094dfe7c83da1ff
      https://github.com/hibernate/hibernate-search/commit/5997333bfca20e01687c7026f094dfe7c83da1ff
  Author: Waldemar Kłaczyński <wklaczynski at sabaservice.pl>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/aggregation/impl/AggregationExtractContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneFacetsBasedTermsAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/scope/impl/MappedIndexScopeImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationOptionsStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/TermsAggregationOptionsStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationFieldStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationRangeStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/SearchAggregationDslContextImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationFieldStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationOptionsStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/spi/SearchAggregationDslContext.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/RangeAggregationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/SearchAggregationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/TermsAggregationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractSearchQueryOptionsStep.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubRangeAggregationBuilder.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubTermsAggregationBuilder.java

  Log Message:
  -----------
  HSEARCH-3881 Filtering multi values for aggregations


  Commit: 03efa7ceb4ca85d5939e4532ebcfa2aac2c5a72a
      https://github.com/hibernate/hibernate-search/commit/03efa7ceb4ca85d5939e4532ebcfa2aac2c5a72a
  Author: Waldemar Kłaczyński <wklaczynski at sabaservice.pl>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneFacetsBasedTermsAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java

  Log Message:
  -----------
  HSEARCH-3881 Fix automatic recognition of nested filters for aggregation filters


  Commit: ae4b76eec5a7ec40f7f2b6f53b390643075145db
      https://github.com/hibernate/hibernate-search/commit/ae4b76eec5a7ec40f7f2b6f53b390643075145db
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationRangeStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationOptionsStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/spi/SearchAggregationDslContext.java

  Log Message:
  -----------
  HSEARCH-3881 Code cleanup for aggregation filters


  Commit: ec26bbb157ee78ea7c61ecbdf8c7f301090e279e
      https://github.com/hibernate/hibernate-search/commit/ec26bbb157ee78ea7c61ecbdf8c7f301090e279e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchAggregation.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchNestableAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneFacetsBasedTermsAggregation.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneNestableAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/RangeAggregationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/SearchAggregationBuilder.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/TermsAggregationBuilder.java

  Log Message:
  -----------
  HSEARCH-3881 Move filter() methods to more appropriate classes in SearchAggregationBuilder inheritance tree


  Commit: ca499599e4d3f032bedf1dccb91547cb078a6e95
      https://github.com/hibernate/hibernate-search/commit/ca499599e4d3f032bedf1dccb91547cb078a6e95
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneNestableAggregation.java

  Log Message:
  -----------
  HSEARCH-3881 Throw exceptions when attempting to use predicate with incompatible nested path hierarchy in an aggregation filter for Lucene


  Commit: f2df176ee4ab9584d9b614dcc7f8d520148e4c95
      https://github.com/hibernate/hibernate-search/commit/f2df176ee4ab9584d9b614dcc7f8d520148e4c95
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/ElasticsearchExtension.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/dsl/ElasticsearchSearchAggregationFactory.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/dsl/impl/ElasticsearchSearchAggregationFactoryImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/LuceneExtension.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/aggregation/dsl/LuceneSearchAggregationFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/aggregation/dsl/impl/LuceneSearchAggregationFactoryImpl.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/scope/impl/MappedIndexScopeImpl.java
    A engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/AggregationFilterStep.java
    A engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/ExtendedSearchAggregationFactory.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationFieldStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationOptionsStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationRangeMoreStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationRangeStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/SearchAggregationFactory.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/SearchAggregationFactoryExtension.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/TermsAggregationFieldStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/TermsAggregationOptionsStep.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/DefaultSearchAggregationFactory.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationFieldStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationRangeStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/SearchAggregationDslContextImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationFieldStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationOptionsStepImpl.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/spi/DelegatingSearchAggregationFactory.java
    M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/spi/SearchAggregationDslContext.java
    M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractSearchQueryOptionsStep.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/AggregationBaseIT.java

  Log Message:
  -----------
  HSEARCH-3881 Expose the extended search predicate factory in extended search aggregation factories

I.e. make sure that this works:

    .search( ... ).extension( LuceneExtension.get() )
        .where( ... )
        .aggregation( f -> f.terms()...
                .filter( pf -> pf.fromLuceneQuery( ... ) ) )

... and that we don't have to call .extension() again on "pf", because
the provided factory is already extended.


  Commit: 496f8711230cbdb04cb6eb459d0079cfdcc11f07
      https://github.com/hibernate/hibernate-search/commit/496f8711230cbdb04cb6eb459d0079cfdcc11f07
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchBucketAggregation.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchNestableAggregation.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AggregationRequestContext.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchRangeAggregation.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchTermsAggregation.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryRequestContext.java

  Log Message:
  -----------
  HSEARCH-3881 Filtering multi values for aggregations in Elasticsearch


  Commit: 7ee587ff37b18071fb880498cee49ff521042700
      https://github.com/hibernate/hibernate-search/commit/7ee587ff37b18071fb880498cee49ff521042700
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ElasticsearchExtensionIT.java
    M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/LuceneExtensionIT.java

  Log Message:
  -----------
  HSEARCH-3881 Test backend-specific extensions in aggregation filters


  Commit: 2030f670482cc867a89fae641557624d602502c7
      https://github.com/hibernate/hibernate-search/commit/2030f670482cc867a89fae641557624d602502c7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java

  Log Message:
  -----------
  HSEARCH-3881 Reduce the init batch size in SingleFieldAggregationBaseIT

To avoid errors caused by too many requests being sent to Elasticsearch
simultaneously.


  Commit: d3e6e09a508c935a7f5d4421734b9cc27e30fe67
      https://github.com/hibernate/hibernate-search/commit/d3e6e09a508c935a7f5d4421734b9cc27e30fe67
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/RangeAggregationDescriptor.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/TermsAggregationDescriptor.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/expectations/AggregationScenario.java

  Log Message:
  -----------
  HSEARCH-3881 Test filters for aggregations on nested fields


  Commit: 12736a7a069110a83540eb8b2330dd343ce18028
      https://github.com/hibernate/hibernate-search/commit/12736a7a069110a83540eb8b2330dd343ce18028
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/DistanceSearchSortFilteringSpecificsIT.java
    R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/DistanceSearchSortTypeFilteringSpecificsIT.java
    A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortFilteringSpecificsIT.java
    R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortTypeFilteringSpecificsIT.java

  Log Message:
  -----------
  HSEARCH-3881 Rename a few tests whose name included a typo


  Commit: bd9bce17009f061bafbb3c56b970ca84862306e0
      https://github.com/hibernate/hibernate-search/commit/bd9bce17009f061bafbb3c56b970ca84862306e0
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/DistanceSearchSortFilteringSpecificsIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortFilteringSpecificsIT.java

  Log Message:
  -----------
  HSEARCH-3881 Fix typos in some pre-existing exception messages


  Commit: 3cd0f9ce34c287efbf8bb2e0abe39490abd59355
      https://github.com/hibernate/hibernate-search/commit/3cd0f9ce34c287efbf8bb2e0abe39490abd59355
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationFilteringSpecificsIT.java

  Log Message:
  -----------
  HSEARCH-3881 Test aggregation filtering with invalid field paths


  Commit: df72f30c37fea9596ae6379219dffa1426d61b08
      https://github.com/hibernate/hibernate-search/commit/df72f30c37fea9596ae6379219dffa1426d61b08
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M documentation/src/main/asciidoc/search-dsl-aggregation.asciidoc
    M documentation/src/test/java/org/hibernate/search/documentation/search/aggregation/AggregationDslIT.java
    M documentation/src/test/java/org/hibernate/search/documentation/search/aggregation/Book.java
    A documentation/src/test/java/org/hibernate/search/documentation/search/aggregation/BookEdition.java

  Log Message:
  -----------
  HSEARCH-3881 Document aggregation filters


Compare: https://github.com/hibernate/hibernate-search/compare/feccb0b245bd...df72f30c37fe



More information about the hibernate-commits mailing list