[hibernate-commits] [hibernate/hibernate-search] 0baf79: HSEARCH-3836 Move filter handling for purge works ...

Yoann Rodière noreply at github.com
Fri Feb 21 08:14:28 EST 2020


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 0baf7946dfd653233559ba7cbd8967c32622c8a0
      https://github.com/hibernate/hibernate-search/commit/0baf7946dfd653233559ba7cbd8967c32622c8a0
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegator.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/DiscriminatorMultiTenancyStrategy.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/MultiTenancyStrategy.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/NoMultiTenancyStrategy.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneDeleteAllEntriesWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneDeleteAllEntriesWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneDeleteEntriesByQueryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneQueryBasedDeleteWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactoryImpl.java

  Log Message:
  -----------
  HSEARCH-3836 Move filter handling for purge works out of MultiTenancyStrategy to LuceneWorkFactoryImpl

Because we're going to need more filters.

Note the removal of the two separate work types does not affect performance:
Lucene's IndexWriter.deleteDocuments(Query) redirects to deleteAll()
when the query is a MatchAllQuery.


  Commit: 6dc8c8a39f676fee80005a86a7ac3cb9b14981e9
      https://github.com/hibernate/hibernate-search/commit/6dc8c8a39f676fee80005a86a7ac3cb9b14981e9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/query/impl/Queries.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/DiscriminatorMultiTenancyStrategy.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/MultiTenancyStrategy.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/multitenancy/impl/NoMultiTenancyStrategy.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneDeleteEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/AbstractLuceneUpdateEntryWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneDeleteEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneQueryBasedDeleteEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneQueryBasedUpdateEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneTermBasedDeleteEntryWork.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneTermBasedUpdateEntryWork.java
    A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneUpdateEntryWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactoryImpl.java

  Log Message:
  -----------
  HSEARCH-3836 Simplify update/delete works in Lucene multitenancy strategies

This is not strictly necessary, but makes the code simpler and more
consistent.


  Commit: ad6a679824bd23e625b71db47c5fc5e6bf08e9b3
      https://github.com/hibernate/hibernate-search/commit/ad6a679824bd23e625b71db47c5fc5e6bf08e9b3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/lowlevel/query/impl/Queries.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/builder/impl/DeleteByQueryWorkBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/execution/impl/ElasticsearchIndexWorkspace.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DeleteByQueryWork.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/SearchWork.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/ShardHolder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/query/impl/Queries.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/execution/impl/LuceneIndexWorkspace.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/execution/impl/WorkExecutionIndexManagerContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactory.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactoryImpl.java
    M engine/src/main/java/org/hibernate/search/engine/backend/work/execution/spi/IndexWorkspace.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspaceIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspacePurgeIT.java
    M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/IndexInitializer.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoScopeWorkspaceImpl.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/StubIndexScaleWorkAssert.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/StubIndexScaleWork.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexWorkspace.java

  Log Message:
  -----------
  HSEARCH-3836 Accept routing keys in IndexWorkspace.purge()


  Commit: feb5b7ca3ef60af5225552121ccbd6d2687855cc
      https://github.com/hibernate/hibernate-search/commit/feb5b7ca3ef60af5225552121ccbd6d2687855cc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/sharding/AbstractShardingIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/sharding/AbstractShardingRoutingKeyIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/sharding/ShardingHashDocumentIdIT.java

  Log Message:
  -----------
  HSEARCH-3836 Test purging with explicit routing keys in backends


  Commit: e94e4e182998988961aac7d07d4ce87aa07ae46d
      https://github.com/hibernate/hibernate-search/commit/e94e4e182998988961aac7d07d4ce87aa07ae46d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-indexing-manual.asciidoc
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/work/SearchWorkspace.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/work/impl/SearchWorkspaceImpl.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoScopeWorkspaceImpl.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/spi/PojoScopeWorkspace.java

  Log Message:
  -----------
  HSEARCH-3836 Accept routing keys in PojoScopeWorkspace.purge() and SearchWorkspace.purge()


  Commit: 8022a6fe857857b4f1f5d5b6cdb8b67756575c7d
      https://github.com/hibernate/hibernate-search/commit/8022a6fe857857b4f1f5d5b6cdb8b67756575c7d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java

  Log Message:
  -----------
  HSEARCH-3836 Fix an incomplete assertion in BackendMock


  Commit: be05f5cfa902e4539dd21f5ee06c398c9b39118c
      https://github.com/hibernate/hibernate-search/commit/be05f5cfa902e4539dd21f5ee06c398c9b39118c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/workspace/SearchWorkspacePurgeBaseIT.java
    R integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/workspace/SearchWorkspacePurgeIT.java
    A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/workspace/SearchWorkspacePurgeRoutingKeyIT.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/work/impl/SearchWorkspaceImpl.java
    M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java

  Log Message:
  -----------
  HSEARCH-3836 Test passing routing keys to PojoScopeWorkspace.purge() and SearchWorkspace.purge()


Compare: https://github.com/hibernate/hibernate-search/compare/6655846f95a4...be05f5cfa902



More information about the hibernate-commits mailing list