[hibernate-commits] [hibernate/hibernate-search] 3ba4b0: HSEARCH-3811 Avoid capturing lambdas in Elasticsea...

Wed Jan 22 06:48:46 EST 2020

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 3ba4b03373611f27e258496ad8376ea8dc123642
      https://github.com/hibernate/hibernate-search/commit/3ba4b03373611f27e258496ad8376ea8dc123642
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java

  Log Message:
  -----------
  HSEARCH-3811 Avoid capturing lambdas in ElasticsearchDefaultWorkSequenceBuilder

  Commit: 1a4584c36e5ce9c3d38d6620e48c469bfd2a467b
      https://github.com/hibernate/hibernate-search/commit/1a4584c36e5ce9c3d38d6620e48c469bfd2a467b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmClassRawTypeModel.java

  Log Message:
  -----------
  HSEARCH-3811 Cache ascending/descending supertypes in ORM RawTypeModel

  Commit: c873b3fc148938639c2d5f251bc9750bf6c145f1
      https://github.com/hibernate/hibernate-search/commit/c873b3fc148938639c2d5f251bc9750bf6c145f1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationMappingConfigurationContextImpl.java

  Log Message:
  -----------
  HSEARCH-3811 Avoid capturing lambdas in AnnotationMappingConfigurationContextImpl#configure

  Commit: cdee5c8b8541c988add57e37f0fa7c35506ea44e
      https://github.com/hibernate/hibernate-search/commit/cdee5c8b8541c988add57e37f0fa7c35506ea44e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/impl/PropertyComparator.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMetatadaContributor.java

  Log Message:
  -----------
  HSEARCH-3811 Avoid creating many comparator instances using Comparator.comparing

  Commit: 27394175e1af19e29dbc6213369fdbde39208582
      https://github.com/hibernate/hibernate-search/commit/27394175e1af19e29dbc6213369fdbde39208582
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    R engine/src/main/java/org/hibernate/search/engine/logging/spi/MappingKeyFormatter.java

  Log Message:
  -----------
  HSEARCH-3810 Remove unused class MappingKeyFormatter

  Commit: faaa6cbf693dee1b5e47a5391dcd4735f813d8de
      https://github.com/hibernate/hibernate-search/commit/faaa6cbf693dee1b5e47a5391dcd4735f813d8de
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/ElasticsearchJsonObjectFormatter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/ElasticsearchRequestFormatter.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/ElasticsearchResponseFormatter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/DurationFormatter.java
    M engine/src/main/java/org/hibernate/search/engine/logging/spi/AggregationKeyFormatter.java
    M engine/src/main/java/org/hibernate/search/engine/logging/spi/MappableTypeModelFormatter.java
    M engine/src/main/java/org/hibernate/search/engine/logging/spi/SimpleNameClassFormatter.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/spi/OptionalEmptyAsDefaultFormatter.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/spi/PojoModelPathFormatter.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/spi/PojoTypeModelFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/ClassFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/EnumFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/EventContextFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/ToStringTreeAppendableMultilineFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/TypeFormatter.java

  Log Message:
  -----------
  HSEARCH-3810 Rework JBoss logging formatters: execute computationally intensive operations in toString rather than the constructor

  Commit: 0a2b158e9e5b7a5c8589729b93cccc6a36024734
      https://github.com/hibernate/hibernate-search/commit/0a2b158e9e5b7a5c8589729b93cccc6a36024734
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java
    R engine/src/main/java/org/hibernate/search/engine/logging/spi/SimpleNameClassFormatter.java
    A util/common/src/main/java/org/hibernate/search/util/common/logging/impl/SimpleNameClassFormatter.java

  Log Message:
  -----------
  HSEARCH-3810 Move SimpleNameClassFormatter to a more appropriate module

There's nothing specific to the engine in this class.

  Commit: 2340d6ee679db5ac235f57cc8504e4faacd94db2
      https://github.com/hibernate/hibernate-search/commit/2340d6ee679db5ac235f57cc8504e4faacd94db2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java

  Log Message:
  -----------
  HSEARCH-3812 Use the appropriate formatter to format Elasticsearch requests in the timeout exception

  Commit: 63f54431596b50a2272fc1ed672278768ac64d2e
      https://github.com/hibernate/hibernate-search/commit/63f54431596b50a2272fc1ed672278768ac64d2e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/DurationFormatter.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/timeout/impl/TimeoutManager.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchClientFactoryImplIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryTimeoutIT.java
    A util/common/src/main/java/org/hibernate/search/util/common/logging/impl/DurationInSecondsAndFractionsFormatter.java

  Log Message:
  -----------
  HSEARCH-3812 Align the exceptions thrown by Lucene and Elasticsearch when a Search query times out

1. Display the timeouti value, not the actual elapsed time. The actual elapsed
time does not mean anything, since we stopped the query before it
finished: there could be 2 milliseconds or 2 millenia left before the
query finishes executing, we simply don't know.
2. Display the timeout value in Elasticsearch, too (not just in Lucene).

  Commit: 986230824d1a226cf27b0763d7fffd4b0d3c1cca
      https://github.com/hibernate/hibernate-search/commit/986230824d1a226cf27b0763d7fffd4b0d3c1cca
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchClientFactoryImplIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryTimeoutIT.java

  Log Message:
  -----------
  HSEARCH-3812 Adapt the timeout message to be relevant even for ES requests that are not queries

For example a PUT /.../_mapping could time out too, and in that case
the exception message should not mention a "search query".

  Commit: 3604ba5a1a5cd406300115542e63dd7432ac97c5
      https://github.com/hibernate/hibernate-search/commit/3604ba5a1a5cd406300115542e63dd7432ac97c5
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchClientFactoryImplIT.java
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryTimeoutIT.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/DurationInSecondsAndFractionsFormatter.java

  Log Message:
  -----------
  HSEARCH-3812 Display milliseconds as well in formatted durations

Because "0 seconds and 3423923 nanoseconds is not as clear as
"0s, 3ms and 423923ns". Most of the time, the durations will be in
milliseconds anyway.

  Commit: 4277dfc9f8528a3598ce5468c5c047540f2a0eac
      https://github.com/hibernate/hibernate-search/commit/4277dfc9f8528a3598ce5468c5c047540f2a0eac
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/ElasticsearchRequestFormatter.java
    M engine/src/main/java/org/hibernate/search/engine/logging/spi/AggregationKeyFormatter.java
    M engine/src/main/java/org/hibernate/search/engine/logging/spi/MappableTypeModelFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/ClassFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/DurationInSecondsAndFractionsFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/EnumFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/SimpleNameClassFormatter.java
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/TypeFormatter.java

  Log Message:
  -----------
  HSEARCH-3810 Fix a few null-safety issues with JBoss logging formatters

Reported by Sonar.

Compare: https://github.com/hibernate/hibernate-search/compare/c205046e4e22...4277dfc9f852