[hibernate-commits] [hibernate/hibernate-search] f55965: HSEARCH-3816 Sonar: "throws" declarations should n...

Yoann Rodière noreply at github.com
Mon Jan 27 04:05:27 EST 2020


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: f55965adf5daa5f879a8712207caac2a330fa11b
      https://github.com/hibernate/hibernate-search/commit/f55965adf5daa5f879a8712207caac2a330fa11b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractCrawlingJsonAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractTypingJsonAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonArrayAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonArrayAccessorImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonCompositeAccessor.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonObjectAccessorImpl.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/RootJsonAccessor.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: "throws" declarations should not be superfluous


  Commit: e2a1454e727c5e9fc43828cc5dadd1a0a300ea92
      https://github.com/hibernate/hibernate-search/commit/e2a1454e727c5e9fc43828cc5dadd1a0a300ea92
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/AbstractElasticsearchSearchNestedSortBuilder.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/AbstractElasticsearchSearchSortBuilder.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/LocalFileSystemDirectoryProvider.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Methods and field names should not be the same or differ only by capitalization


  Commit: 993910be67769e972e48431ad896561562de211d
      https://github.com/hibernate/hibernate-search/commit/993910be67769e972e48431ad896561562de211d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ServerUris.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: "indexOf" checks should not be for positive numbers


  Commit: a4d2e5b39bb53fefd2c31be404a6682af6c3a5bb
      https://github.com/hibernate/hibernate-search/commit/a4d2e5b39bb53fefd2c31be404a6682af6c3a5bb
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/ExtractionRequirements.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmClassRawTypeModel.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmPathFilterFactory.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/typepattern/impl/TypePatternMatcherFactory.java
    M util/common/src/main/java/org/hibernate/search/util/common/impl/ToStringTreeBuilder.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Cognitive Complexity of methods should not be too high


  Commit: 15910be10eb384c7618f3c79758c6d6b64cb6f8f
      https://github.com/hibernate/hibernate-search/commit/15910be10eb384c7618f3c79758c6d6b64cb6f8f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/impl/LuceneIndexFieldReference.java
    M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/PassThroughFromDocumentFieldValueConverter.java
    M engine/src/main/java/org/hibernate/search/engine/backend/types/converter/spi/PassThroughToDocumentFieldValueConverter.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/processing/impl/MappingAnnotationProcessorContextImpl.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Methods should not be empty


  Commit: 48cdd4a819bef9604f4eeb20204553a66f9dfb49
      https://github.com/hibernate/hibernate-search/commit/48cdd4a819bef9604f4eeb20204553a66f9dfb49
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/collector/impl/CollectorKey.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/ExtractionRequirements.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/LuceneCollectors.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Constants should not be defined in interfaces


  Commit: 316d8cd4c364b8733b0de864899e22ee01dd7029
      https://github.com/hibernate/hibernate-search/commit/316d8cd4c364b8733b0de864899e22ee01dd7029
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientImpl.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Unused method parameters should be removed


  Commit: d2e8fc7366a70f32229f40105ba4f88a4cf2e190
      https://github.com/hibernate/hibernate-search/commit/d2e8fc7366a70f32229f40105ba4f88a4cf2e190
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanContainedTypeContext.java
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanMapperDelegate.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Unused type parameters should be removed


  Commit: 3853f803c46d0ffc3dfe6f337aeaf2786adc0865
      https://github.com/hibernate/hibernate-search/commit/3853f803c46d0ffc3dfe6f337aeaf2786adc0865
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientUtils.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Try-catch blocks should not be nested


  Commit: bbabef59f3ecc22559fd6dfa91939dee518fc3ae
      https://github.com/hibernate/hibernate-search/commit/bbabef59f3ecc22559fd6dfa91939dee518fc3ae
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/Shard.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/DirectoryCreationContextImpl.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Unused "private" fields should be removed


  Commit: 40e6e034d3d0a8a964f8c6f97a6d814aedcd72a2
      https://github.com/hibernate/hibernate-search/commit/40e6e034d3d0a8a964f8c6f97a6d814aedcd72a2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/spatial/NestedDocumentDistanceProjectionIT.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Assertion arguments should be passed in the correct order


  Commit: b71cd7be8c012d0fe6d8e514924d1be2b34b40a1
      https://github.com/hibernate/hibernate-search/commit/b71cd7be8c012d0fe6d8e514924d1be2b34b40a1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/directory/impl/FileSystemUtils.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Java 8's "Files.exists" should not be used


  Commit: c5daf80f3ff29f8ba3ca870f437e56bea41586c2
      https://github.com/hibernate/hibernate-search/commit/c5daf80f3ff29f8ba3ca870f437e56bea41586c2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcherImpl.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Collapsible "if" statements should be merged


  Commit: e928c0c7f2b0adedc68ff89b9f17ef8e6a8db464
      https://github.com/hibernate/hibernate-search/commit/e928c0c7f2b0adedc68ff89b9f17ef8e6a8db464
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Generic exceptions should never be thrown


  Commit: e9d9d4cdcf510217cbc8876071ea286f346e8904
      https://github.com/hibernate/hibernate-search/commit/e9d9d4cdcf510217cbc8876071ea286f346e8904
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ServerUris.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: String function use should be optimized for single characters


  Commit: af42729308edadee35109ce0ce44bd075bea82b3
      https://github.com/hibernate/hibernate-search/commit/af42729308edadee35109ce0ce44bd075bea82b3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilder.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Unused assignments should be removed


  Commit: 2f8f7c2e1c72db274c3b085740dd7d19068afe64
      https://github.com/hibernate/hibernate-search/commit/2f8f7c2e1c72db274c3b085740dd7d19068afe64
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  HSEARCH-3816 Sonar: Sections of code should not be commented out


  Commit: 00d5f92687b8bc4ba19b8425a2678c4e87ba8d24
      https://github.com/hibernate/hibernate-search/commit/00d5f92687b8bc4ba19b8425a2678c4e87ba8d24
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoAssociationPathInverter.java

  Log Message:
  -----------
  HSEARCH-3816 Sonar: "static" base class members should not be accessed via derived types


Compare: https://github.com/hibernate/hibernate-search/compare/8f823077213a...00d5f92687b8



More information about the hibernate-commits mailing list