[hibernate-commits] [hibernate/hibernate-search] 8301e9: HSEARCH-3097 Add @IndexedEmbedded.name()

[Yoann Rodière]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 8301e943a9bf5edd56040f76ed85826f30556730
      https://github.com/hibernate/hibernate-search/commit/8301e943a9bf5edd56040f76ed85826f30556730
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/backend/common/spi/FieldPaths.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/IndexedEmbedded.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/processing/impl/IndexedEmbeddedProcessor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/DelegatingPropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java

  Log Message:
  -----------
  HSEARCH-3097 Add @IndexedEmbedded.name()


  Commit: 7945fecc865a0b0a51dc6b0edb7472a506200d4b
      https://github.com/hibernate/hibernate-search/commit/7945fecc865a0b0a51dc6b0edb7472a506200d4b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/backend/common/spi/FieldPaths.java
    M engine/src/main/java/org/hibernate/search/engine/backend/document/model/dsl/impl/IndexSchemaElementImpl.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AbstractPropertyMappingFieldOptionsStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java

  Log Message:
  -----------
  HSEARCH-3097 Throw exceptions early when defining index fields containing a dot ('.')

We already do, but later.
This is important in particular for @IndexedEmbedded, where
@IndexedEmbedded.name will be transformed into a prefix,
which actually allows dots at the moment, even if we would like to
forbid this eventually.


  Commit: ebd13518ed7faf3a1fe0967ff2c91c8c6a2f1362
      https://github.com/hibernate/hibernate-search/commit/ebd13518ed7faf3a1fe0967ff2c91c8c6a2f1362
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FullTextFieldIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/GenericFieldIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/KeywordFieldIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/NonStandardFieldIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/ScaledNumberFieldIT.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AbstractPropertyMappingFieldOptionsStep.java

  Log Message:
  -----------
  HSEARCH-3097 Test the 'name' attribute of all @*Field annotations

Not directly related to this PR, but the tests were missing.


  Commit: d81c7c3f648afdd5d7431ee97052e54a50724482
      https://github.com/hibernate/hibernate-search/commit/d81c7c3f648afdd5d7431ee97052e54a50724482
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java

  Log Message:
  -----------
  HSEARCH-3097 Test @IndexedEmbedded.name


  Commit: 3bb469291e53bcb4e7a1377b68f70d856d523e6d
      https://github.com/hibernate/hibernate-search/commit/3bb469291e53bcb4e7a1377b68f70d856d523e6d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc

  Log Message:
  -----------
  HSEARCH-3097 Document @IndexedEmbedded.name


  Commit: d768a9082e1b2dca2ad13a3e545e3ab4f4990a1b
      https://github.com/hibernate/hibernate-search/commit/d768a9082e1b2dca2ad13a3e545e3ab4f4990a1b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc

  Log Message:
  -----------
  HSEARCH-3097 Document that field names must not contain a dot ('.')


  Commit: 52482fa910d64356c5cc075b1954e09ebca1b393
      https://github.com/hibernate/hibernate-search/commit/52482fa910d64356c5cc075b1954e09ebca1b393
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java

  Log Message:
  -----------
  HSEARCH-3097 Test multi-valued @IndexedEmbedded separately from @IndexedEmbedded.prefix

Because multi-valued @IndexedEmbedded make sense independently from
@IndexedEmbedded.prefix.

Also, since the prefix is going to be removed in the future,
tests that use the prefix will be removed at some point.


  Commit: 847e5672ece78f186e74be188a468c4cb0826a20
      https://github.com/hibernate/hibernate-search/commit/847e5672ece78f186e74be188a468c4cb0826a20
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/IndexedEmbedded.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyMappingIndexedEmbeddedStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java

  Log Message:
  -----------
  HSEARCH-3097 Deprecate @IndexedEmbedded.prefix


  Commit: 748fc8e05ae5bb0eb02401d4dd38502301ff0df1
      https://github.com/hibernate/hibernate-search/commit/748fc8e05ae5bb0eb02401d4dd38502301ff0df1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/reindexing/associationinverseside/Book.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/AnnotationMappingSmokeIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/ProgrammaticMappingSmokeIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/AnnotationMappingSmokeIT.java
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/ProgrammaticMappingSmokeIT.java

  Log Message:
  -----------
  HSEARCH-3097 Use @IndexedEmbedded.name instead of @IndexedEmbedded.prefix where relevant


Compare: https://github.com/hibernate/hibernate-search/compare/0c1466ac05ba...748fc8e05ae5