[hibernate-commits] [hibernate/hibernate-search] 8b6b64: HSEARCH-3855 Add a multiline, YAML-like, indent-ba...

Yoann Rodière noreply at github.com
Tue May 26 10:32:12 EDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 8b6b6431b19b866d84073bc6c55107be569fa828
      https://github.com/hibernate/hibernate-search/commit/8b6b6431b19b866d84073bc6c55107be569fa828
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M util/common/src/main/java/org/hibernate/search/util/common/impl/ToStringStyle.java
    M util/common/src/test/java/org/hibernate/search/util/common/impl/ToStringTreeBuilderTest.java

  Log Message:
  -----------
  HSEARCH-3855 Add a multiline, YAML-like, indent-based ToStringTree style with hardcoded parameters


  Commit: a6212daad3d2e3d6405278fb60dc9d99d4b9b9f8
      https://github.com/hibernate/hibernate-search/commit/a6212daad3d2e3d6405278fb60dc9d99d4b9b9f8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/ToStringTreeAppendableMultilineFormatter.java

  Log Message:
  -----------
  HSEARCH-3855 Switch to YAML-like formatting when logging indexing processors and reindexing resolvers

I.e. this:

09:11:47,299 (main) DEBUG PojoIndexedTypeManagerBuilder:143 - HSEARCH700017: Created POJO indexed type manager: {
	typeIdentifier=org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity
	indexManager=org.hibernate.search.engine.mapper.mapping.impl.MappedIndexManagerImpl at 4912d525
	identifierMapping=org.hibernate.search.mapper.pojo.bridge.runtime.impl.PropertyIdentifierMapping at 2bfbffb2
	routingKeyProvider=org.hibernate.search.mapper.pojo.bridge.runtime.impl.RoutingKeyProvider$$Lambda$208/832066800 at 765df79d
	processor={
		class=PojoIndexingProcessorTypeNode
		parentIndexObjectReferences=[]
		bridges=[
		]
		propertyNodes=[
			{
				class=PojoIndexingProcessorPropertyNode
				handle=MethodHandleValueReadHandle[private java.util.List org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedElementCollectionField]
				bridges=[
				]
				nestedNodes=[
					{
						class=PojoIndexingProcessorContainerElementNode
						extractor=org.hibernate.search.mapper.pojo.extractor.builtin.impl.CollectionElementExtractor at 151335cb
						nestedNodes=[
							{
								class=PojoIndexingProcessorValueBridgeNode
								bridge=org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 4a7761b1
								indexFieldReference=StubIndexFieldReference[indexedElementCollectionField]
							}
						]
					}
				]
			}
			{
				class=PojoIndexingProcessorPropertyNode
				handle=MethodHandleValueReadHandle[private java.lang.String org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedField]
				bridges=[
				]
				nestedNodes=[
					{
						class=PojoIndexingProcessorValueBridgeNode
						bridge=org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 3e850122
						indexFieldReference=StubIndexFieldReference[indexedField]
					}
				]
			}
			{
				class=PojoIndexingProcessorPropertyNode
				handle=MethodHandleValueReadHandle[private java.util.List org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.noReindexOnUpdateElementCollectionField]
				bridges=[
				]
				nestedNodes=[
					{
						class=PojoIndexingProcessorContainerElementNode
						extractor=org.hibernate.search.mapper.pojo.extractor.builtin.impl.CollectionElementExtractor at 27fde870
						nestedNodes=[
							{
								class=PojoIndexingProcessorValueBridgeNode
								bridge=org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 2b4c3c29
								indexFieldReference=StubIndexFieldReference[noReindexOnUpdateElementCollectionField]
							}
						]
					}
				]
			}
			{
				class=PojoIndexingProcessorPropertyNode
				handle=MethodHandleValueReadHandle[private java.lang.String org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.noReindexOnUpdateField]
				bridges=[
				]
				nestedNodes=[
					{
						class=PojoIndexingProcessorValueBridgeNode
						bridge=org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 5ac7aa18
						indexFieldReference=StubIndexFieldReference[noReindexOnUpdateField]
					}
				]
			}
		]
	}
	reindexingResolver={
		class=DefaultPojoImplicitReindexingResolver
		dirtyPathsTriggeringSelfReindexing=StringSetPojoPathFilter[[indexedElementCollectionField, org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedElementCollectionField, indexedField]]
		containingEntitiesResolverRoot={
			class=NoOpPojoImplicitReindexingResolverNode
		}
	}
}

Becomes this:

09:07:37,830 (main) DEBUG PojoIndexedTypeManagerBuilder:143 - HSEARCH700017: Created POJO indexed type manager:
  typeIdentifier: org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity
  indexManager: org.hibernate.search.engine.mapper.mapping.impl.MappedIndexManagerImpl at 4912d525
  identifierMapping: org.hibernate.search.mapper.pojo.bridge.runtime.impl.PropertyIdentifierMapping at 2bfbffb2
  routingKeyProvider: org.hibernate.search.mapper.pojo.bridge.runtime.impl.RoutingKeyProvider$$Lambda$208/832066800 at 765df79d
  processor:
    class: PojoIndexingProcessorTypeNode
    parentIndexObjectReferences: []
    bridges:
    propertyNodes:
      * class: PojoIndexingProcessorPropertyNode
        handle: MethodHandleValueReadHandle[private java.util.List org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedElementCollectionField]
        bridges:
        nestedNodes:
          * class: PojoIndexingProcessorContainerElementNode
            extractor: org.hibernate.search.mapper.pojo.extractor.builtin.impl.CollectionElementExtractor at 151335cb
            nestedNodes:
              * class: PojoIndexingProcessorValueBridgeNode
                bridge: org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 4a7761b1
                indexFieldReference: StubIndexFieldReference[indexedElementCollectionField]
      * class: PojoIndexingProcessorPropertyNode
        handle: MethodHandleValueReadHandle[private java.lang.String org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedField]
        bridges:
        nestedNodes:
          * class: PojoIndexingProcessorValueBridgeNode
            bridge: org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 3e850122
            indexFieldReference: StubIndexFieldReference[indexedField]
      * class: PojoIndexingProcessorPropertyNode
        handle: MethodHandleValueReadHandle[private java.util.List org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.noReindexOnUpdateElementCollectionField]
        bridges:
        nestedNodes:
          * class: PojoIndexingProcessorContainerElementNode
            extractor: org.hibernate.search.mapper.pojo.extractor.builtin.impl.CollectionElementExtractor at 27fde870
            nestedNodes:
              * class: PojoIndexingProcessorValueBridgeNode
                bridge: org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 2b4c3c29
                indexFieldReference: StubIndexFieldReference[noReindexOnUpdateElementCollectionField]
      * class: PojoIndexingProcessorPropertyNode
        handle: MethodHandleValueReadHandle[private java.lang.String org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.noReindexOnUpdateField]
        bridges:
        nestedNodes:
          * class: PojoIndexingProcessorValueBridgeNode
            bridge: org.hibernate.search.engine.environment.bean.SimpleBeanHolder at 5ac7aa18
            indexFieldReference: StubIndexFieldReference[noReindexOnUpdateField]
  reindexingResolver:
    class: DefaultPojoImplicitReindexingResolver
    dirtyPathsTriggeringSelfReindexing: StringSetPojoPathFilter[[indexedElementCollectionField, org.hibernate.search.integrationtest.mapper.orm.automaticindexing.AutomaticIndexingBasicIT$IndexedEntity.indexedElementCollectionField, indexedField]]
    containingEntitiesResolverRoot:
      class: NoOpPojoImplicitReindexingResolverNode


  Commit: 3e1e77b833a873706e3440acd91651a457be1f61
      https://github.com/hibernate/hibernate-search/commit/3e1e77b833a873706e3440acd91651a457be1f61
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/impl/ElasticsearchIndexFieldReference.java
    M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/impl/ElasticsearchIndexObjectFieldReference.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/impl/LuceneIndexFieldReference.java
    M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/impl/LuceneIndexObjectFieldReference.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/CompositeBeanHolder.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/DependencyClosingBeanHolder.java
    M engine/src/main/java/org/hibernate/search/engine/environment/bean/SimpleBeanHolder.java
    M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/impl/MappedIndexManagerImpl.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmContainedBeanBeanHolderAdapter.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/AlwaysNullRoutingKeyProvider.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/PropertyIdentifierMapping.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/ProvidedIdentifierMapping.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/RoutingKeyBridgeRoutingKeyProvider.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/RoutingKeyProvider.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/ArrayElementExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/CollectionElementExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/IterableElementExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/MapKeyExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/MapValueExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalDoubleValueExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalIntValueExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalLongValueExtractor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalValueExtractor.java

  Log Message:
  -----------
  HSEARCH-3855 Add a few missing toString() implementations

Spotted while looking at logged indexing processors


  Commit: e66059c34fe543c207d92ccb0b49d2296e54c432
      https://github.com/hibernate/hibernate-search/commit/e66059c34fe543c207d92ccb0b49d2296e54c432
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/DefaultPojoImplicitReindexingResolver.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/NoOpPojoImplicitReindexingResolver.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/NoOpPojoImplicitReindexingResolverNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverCastedTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverContainerElementNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverDirtinessFilterNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverMarkingNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverOriginalTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverPropertyNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/NoOpPojoIndexingProcessor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorContainerElementNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorValueBridgeNode.java

  Log Message:
  -----------
  HSEARCH-3855 Rename a few attributes in indexing processors and reindexing resolvers

To make them clearer when rendered as strings.


  Commit: 87dd99fdb38128f752e12237f353dd9bbd5af8f4
      https://github.com/hibernate/hibernate-search/commit/87dd99fdb38128f752e12237f353dd9bbd5af8f4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/AbstractPojoProcessorNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorContainerElementNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorContainerElementNode.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorMultiNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeNode.java

  Log Message:
  -----------
  HSEARCH-3855 Use a dedicated node type to represent sequences of nodes in indexing processors


  Commit: f102783e46b9ebbca902d22649a29391200537cf
      https://github.com/hibernate/hibernate-search/commit/f102783e46b9ebbca902d22649a29391200537cf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverBuildingHelper.java
    R mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/DefaultPojoImplicitReindexingResolver.java
    R mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/NoOpPojoImplicitReindexingResolver.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolver.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverImpl.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java

  Log Message:
  -----------
  HSEARCH-3855 Remove the unnecessary NoOpPojoImplicitReindexingResolver

It can simply be implemented with the usual
PojoImplicitReindexingResolver and no-op components.


  Commit: 4ab5e375f3161cb4119edbc0f361cb9e64ff0718
      https://github.com/hibernate/hibernate-search/commit/4ab5e375f3161cb4119edbc0f361cb9e64ff0718
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/AbstractPojoImplicitReindexingResolverNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/AbstractPojoImplicitReindexingResolverTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverCastedTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverContainerElementNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverOriginalTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverCastedTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverContainerElementNode.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverMultiNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverOriginalTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverPropertyNode.java

  Log Message:
  -----------
  HSEARCH-3855 Use a dedicated node type to represent sequences of nodes in reindexing resolvers


Compare: https://github.com/hibernate/hibernate-search/compare/6fa684d4cab2...4ab5e375f316



More information about the hibernate-commits mailing list