[hibernate-commits] [hibernate/hibernate-search] 6ad697: HSEARCH-3072 Remove an unnecessary unchecked cast ...

Yoann Rodière noreply at github.com
Wed May 27 09:48:03 EDT 2020 

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 6ad697e43b5ae07db2c4ab22eae0ae0210f320ed
      https://github.com/hibernate/hibernate-search/commit/6ad697e43b5ae07db2c4ab22eae0ae0210f320ed
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/AbstractPojoImplicitReindexingResolverTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverCastedTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoImplicitReindexingResolverOriginalTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverCastedTypeNode.java

  Log Message:
  -----------
  HSEARCH-3072 Remove an unnecessary unchecked cast from PojoImplicitReindexingResolverCastedTypeNode


  Commit: 828d7f3436fce1911b43efae3ac14de035536640
      https://github.com/hibernate/hibernate-search/commit/828d7f3436fce1911b43efae3ac14de035536640
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/model/impl/JavaBeanTypeModel.java
    M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/AbstractHibernateOrmRawTypeModel.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/spi/PojoRawTypeModel.java

  Log Message:
  -----------
  HSEARCH-3072 Clarify that PojoTypeModel.rawType() is idempotent


  Commit: 80c062c38621cabb6cf2328647d64f61a345ba12
      https://github.com/hibernate/hibernate-search/commit/80c062c38621cabb6cf2328647d64f61a345ba12
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/IndexedEmbedded.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/processing/impl/IndexedEmbeddedProcessor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyMappingIndexedEmbeddedStep.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java

  Log Message:
  -----------
  HSEARCH-3072 Add API for IndexedEmbedded.targetType


  Commit: b40c09122c44cfcac4f6895a6c76876c52f282ac
      https://github.com/hibernate/hibernate-search/commit/b40c09122c44cfcac4f6895a6c76876c52f282ac
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M documentation/src/main/asciidoc/internals.asciidoc
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/building/impl/PojoIndexingDependencyCollectorValueNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMappingHelper.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/PojoMappingCollectorValueNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/processing/impl/IndexedEmbeddedProcessor.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/AbstractPojoIndexingProcessorTypeNodeBuilder.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorCastedTypeNodeBuilder.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorOriginalTypeNodeBuilder.java
    R mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorCastedTypeNode.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorOriginalTypeNode.java
    R mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeNode.java

  Log Message:
  -----------
  HSEARCH-3072 Implement IndexedEmbedded.targetType


  Commit: c388f21c521d02a43721b4ddd0ce85b2b330effd
      https://github.com/hibernate/hibernate-search/commit/c388f21c521d02a43721b4ddd0ce85b2b330effd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java

  Log Message:
  -----------
  HSEARCH-3072 Test IndexedEmbedded.targetType


  Commit: 3ec0eb0736b55212e363cba7da1bc75b223be2e4
      https://github.com/hibernate/hibernate-search/commit/3ec0eb0736b55212e363cba7da1bc75b223be2e4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingListAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingMapKeysAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingMapValuesAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingSortedMapValuesAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingSortedSetAssociationIT.java

  Log Message:
  -----------
  HSEARCH-3072 Remove a few unused methods in integration tests


  Commit: b2411d1ea3d9d0010726c76b22d6c63fabb518d8
      https://github.com/hibernate/hibernate-search/commit/b2411d1ea3d9d0010726c76b22d6c63fabb518d8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AbstractAutomaticIndexingAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AbstractAutomaticIndexingMultiAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingListAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingMapKeysAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingMapValuesAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingSingleAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingSortedMapValuesAssociationIT.java
    M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingSortedSetAssociationIT.java

  Log Message:
  -----------
  HSEARCH-3072 Test automatic indexing when using @IndexedEmbedded.targetType


  Commit: 6a3806f721af62a42ae6d8b9c842178d2843cb0e
      https://github.com/hibernate/hibernate-search/commit/6a3806f721af62a42ae6d8b9c842178d2843cb0e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc

  Log Message:
  -----------
  HSEARCH-3072 Document @IndexedEmbedded.targetType


  Commit: 5095c6f324361e8fb1b07cd1cdc1f664d3d8ee74
      https://github.com/hibernate/hibernate-search/commit/5095c6f324361e8fb1b07cd1cdc1f664d3d8ee74
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M jqassistant/rules.xml

  Log Message:
  -----------
  HSEARCH-3072 Ignore test types in JQAssistant rule hsearch:TypesShouldUseImplSuffixWithRestraint

The rule got violated by the types defined in
org.hibernate.search.integrationtest.mapper.pojo.mapping.definition.IndexedEmbeddedBaseIT#targetType,
but frankly we don't care about these violations.


  Commit: 3dfab2d8c3f7df849a641bbc06960d3ae1eccc5e
      https://github.com/hibernate/hibernate-search/commit/3dfab2d8c3f7df849a641bbc06960d3ae1eccc5e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverCastedTypeNode.java

  Log Message:
  -----------
  HSEARCH-3072 Clarify that the cast in PojoImplicitReindexingResolverCastedTypeNode is optional


  Commit: 6ffe6f5b5b4d860c18a0ede1546572b4ab964f0e
      https://github.com/hibernate/hibernate-search/commit/6ffe6f5b5b4d860c18a0ede1546572b4ab964f0e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/AbstractPojoIndexingProcessorTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorCastedTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorOriginalTypeNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorCastedTypeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorOriginalTypeNode.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyBridgeNode.java
    M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java
    A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeBridgeNode.java

  Log Message:
  -----------
  HSEARCH-3072 Use dedicated indexing processor nodes to apply type bridges and property bridges

This should make the indexing processor tree clearer and reduce code
duplication: type bridges are no longer applied by both the original
type nodes and casted type nodes, they delegate to another node.


Compare: https://github.com/hibernate/hibernate-search/compare/52fe817a9253...6ffe6f5b5b4d

More information about the hibernate-commits mailing list