[hibernate-dev] HSQLDialect - sequences - problems with white space

[David Balazic]

Created JIRA issue HHH-2839
 
Regards,
David

________________________________

From: Steve Ebersole on behalf of Steve Ebersole
Sent: Mon 10-Sep-07 20:41
To: hibernate-dev at lists.jboss.org
Cc: David Balazic
Subject: Re: [hibernate-dev] HSQLDialect - sequences - problems with white space



On Monday 10 September 2007 11:29:36 am David Balazic wrote:
> (since the mod did not approve my prevoius message, neither did Steve
> reply, I subscribed and send it again) (I bet 5 seconds after I push SEND,
> the moderator will approve my pending message and we will have two
> copies...) Hi!
Sorry, I generally do not reply to these type of emails sent directly to me. 
If you want to discuss Hibernate development, joining the development mailing
list is not an undue hardship.

> I see 3 solutions:
>  - declare blank characters in <param name="sequence"> as illegal and be
> done with it :-( - trim blank characters from the sequenceName argument in
> method
>    org.hibernate.dialect.HSQLDialect.getCreateSequenceStrings(String) (and
> others) or maybe before, when it is read from Configuration, in
> org.hibernate.id.SequenceGenerator.configure - do not create a table for
> each sequence. As I see it they are not really used, just needed as a dummy
> table for the "SELECT NEXT VALUE FOR sequenceName FROM ..." statement. A
> single table could be used for all sequences. Some "MY_COMMON_DUAL" thing.

Hibernate historically has not handled xml text very well imo.  We used to
have this same issue with stuff in cfg.xml, although I changed all that to
use the trimmed text.  However, blindly using trimmed text from a mapping
file is not as viable.

So certainly we could have SequenceGenerator account for trimming the sequence
name.  I obviously have no objections to that.

As for not not creating the dual_* tables:
1) I do not like (and will not code for) a "MY_COMMON_DUAL" approach; this is
a simple oversight in HSQLDB (at least "back then", #2 alleviates that
shortcoming)
2) since when was the "call NEXT VALUE FOR [sequence_name]" syntax available? 
Depending on the answer to that, I have no issues with going this route;
create a patch and attach to a JIRA request.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-dev/attachments/20070913/d323d467/attachment.html