[hibernate-dev] Code Review: ANN-778
Hardy Ferentschik
hibernate at ferentschik.de
Thu Oct 23 04:49:15 EDT 2008
On Wed, 22 Oct 2008 17:11:01 +0200, Juraci Costa <jcosta at redhat.com> wrote:
> Guys,
>
> This is the one which originated the changes in the parent Test class
> for Entity Manager, but somehow we managed to forget it :-) So, after
> discussing the approaches, I did a new diff to replace the old one,
> which uses the parent's capabilities on handling the sessions and
> exceptions.
>
> Nothing exciting in this diff, maybe the only noticeable thing here is
> that I removed the teardown method and moved the "session.close();"
> method call to the tests, because the runTest checks for unclosed
> sessions (and it runs before the teardown).
>
> So, please take a look and let me know if you spot something wrong.
Looks good to me and the tests pass again. Good stuff ;-)
--Hardy
More information about the hibernate-dev
mailing list