[hibernate-dev] release
Steve Ebersole
steve at hibernate.org
Thu Mar 11 11:37:46 EST 2010
Yeah we will need to do a 2.2.23 release of this to move forward with
the hibernate release :(
On 03/11/2010 10:07 AM, Steve Ebersole wrote:
> Hardy asked where the dtds are kept in our source. I was pointing him
> to them.
>
> The change here was just to use the local dtd resolution strategy i
> added in 2.2.2 to this inclusion helper process. I just missed this
> usage when making the addition.
>
> On 03/11/2010 10:00 AM, Strong Liu wrote:
>> No, i don't think so, and also it is not because of that docbook.dtd
>> cant be access.
>> basically, that XIncludeHelper.locateInclusions method will be called
>> many times when you build docs, every time it tries to get that dtd
>> from web.
>> so in Gail's case, it was running but busy on resolve dtd :D
>>
>> and no relates to those ent files, because i have excluded those non
>> xml files from this method
>>
>>
>>
>> On Mar 11, 2010, at 11:55 PM, Steve Ebersole wrote:
>>
>>> You mean like these:
>>> http://fisheye.jboss.org/browse/Maven/plugins/jdocbook/maven-jdocbook-plugin/trunk/src/main/resources/docbook/xml/4.5/ent
>>>
>>> ?
>>>
>>> ;)
>>>
>>> On 03/11/2010 09:49 AM, Hardy Ferentschik wrote:
>>>> I remember the days when my Struts application wouldn't start up,
>>>> because on startup it validated the
>>>> xml and always downloaded the dtd via the web. If the website was down,
>>>> the app would not start up.
>>>> I guess something similar happened here.
>>>>
>>>> Using a local resolver seem to be a good idea, but I don't see the dtd
>>>> checked into our sources, so
>>>> I think the only reason it works now again is because
>>>> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
>>>> is accessible again.
>>>>
>>>> my 0.02$
>>>>
>>>> --Hardy
>>>>
>>>> On Thu, 11 Mar 2010 12:32:55 -0300, Strong Liu<stliu at redhat.com> wrote:
>>>>
>>>>> IMO, this is the point, XIncludeHelper.locateInclusions use
>>>>> FileUtil.createSAXSource to create a Source object, after you enabled
>>>>> this loading feature, it will tries to resolve the dtd from remote
>>>>> here is what i changed.
>>>>>
>>>>> http://fisheye.jboss.org/browse/Maven/plugins/jdocbook/maven-jdocbook-plugin/trunk/src/main/java/org/jboss/jdocbook/util/XIncludeHelper.java?r1=428&r2=442
>>>>>
>>>>>
>>>>>
>>>>> 428 442 442 XIncludeHelper.java
>>>>> 37 37
>>>>> 38 38 import org.apache.xerces.jaxp.SAXParserFactoryImpl;
>>>>> 39 39 import org.jboss.jdocbook.JDocBookProcessException;
>>>>> 40 + import
>>>>> org.jboss.jdocbook.xslt.resolve.entity.EntityResolverChain;
>>>>> 41 + import
>>>>> org.jboss.jdocbook.xslt.resolve.entity.LocalDocBookEntityResolver;
>>>>> 40 42 import org.xml.sax.EntityResolver;
>>>>> 41 43 import org.xml.sax.InputSource;
>>>>> 42 44 import org.xml.sax.SAXException;
>>>>>
>>>>> …
>>>>> 72 74 return null;
>>>>> 73 75 }
>>>>> 74 76 };
>>>>> 77 +
>>>>> 78 + EntityResolverChain entityResolverChain = new
>>>>> EntityResolverChain(entityResolver);
>>>>> 79 + entityResolverChain.addEntityResolver(new
>>>>> LocalDocBookEntityResolver());
>>>>> 75 80
>>>>> 76 81 try {
>>>>> 77 82 SAXParserFactory parserFactory = new SAXParserFactoryImpl();
>>>>> 78 83 parserFactory.setXIncludeAware( true );
>>>>> 79 84
>>>>> 80 - Source transformationSource = FileUtils.createSAXSource( root,
>>>>> entityResolver, true, null );
>>>>> 85 + Source transformationSource = FileUtils.createSAXSource( root,
>>>>> entityResolverChain, true, null );
>>>>> 81 86 Result transformationResult = new StreamResult( new
>>>>> NoOpWriter() );
>>>>> 82 87
>>>>> 83 88 javax.xml.transform.TransformerFactory transformerFactory = new
>>>>> com.icl.saxon.TransformerFactoryImpl();
>>>>>
>>>>>
>>>>> On Mar 11, 2010, at 11:26 PM, Steve Ebersole wrote:
>>>>>
>>>>>> That's not true afaik:
>>>>>> reader.setFeature( Constants.DTD_LOADING_FEATURE, true );
>>>>>> reader.setFeature( Constants.DTD_VALIDATION_FEATURE, false );
>>>>>>
>>>>>> Loading *needs* to happen.
>>>>>>
>>>>>> Anyway that code was the same before I updated and after I updated.
>>>>>> This is in FileUtils#createSAXSource. So where is it that you
>>>>>> changed?
>>>>>>
>>>>>> On 03/11/2010 08:49 AM, Strong Liu wrote:
>>>>>>> I have fixed this issue
>>>>>>> https://jira.jboss.org/jira/browse/MPJDOCBOOK-52, and released a
>>>>>>> 2.2.3-SNAPSHOT
>>>>>>>
>>>>>>> i'd think this is because Steve enabled the dtd validation in this
>>>>>>> 2.2.3 release
>>>>>>>
>>>>>>> i will try to build hibernate trunk later (for the sync) with this
>>>>>>> snapshot release
>>>>>>> Steve, would you consider release a 2.2.3?
>>>>>>>
>>>>>>>
>>>>>>> -------------------------------
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Strong Liu
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mar 11, 2010, at 12:12 PM, Gail Badner wrote:
>>>>>>>
>>>>>>>> The build seems to hang while building the doc, so this is not
>>>>>>>> going to
>>>>>>>> happen tonight.
>>>>>>>>
>>>>>>>> Here is the build log when it stops:
>>>>>>>>
>>>>>>>> [INFO] Building Hibernate Manual
>>>>>>>> [INFO] task-segment: [clean, test]
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] [clean:clean {execution: default-clean}]
>>>>>>>> [INFO] Deleting directory
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] [enforcer:enforce {execution: enforce-java}]
>>>>>>>> [INFO] [jdocbook:resources {execution: default-resources}]
>>>>>>>> [INFO] Expanding:
>>>>>>>> /home/gbadner/NotBackedUp/.m2/repository-trunk/org/jboss/jbossorg-jdocbook-style/1.1.0/jbossorg-jdocbook-style-1.1.0.jdocbook-style
>>>>>>>>
>>>>>>>>
>>>>>>>> into
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target/docbook/staging
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] Expanding:
>>>>>>>> /home/gbadner/NotBackedUp/.m2/repository-trunk/org/jboss/jbossorg-fonts/1.0.0/jbossorg-fonts-1.0.0.jdocbook-style
>>>>>>>>
>>>>>>>>
>>>>>>>> into
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target/docbook/staging
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] Expanding:
>>>>>>>> /home/gbadner/NotBackedUp/.m2/repository-trunk/org/hibernate/hibernate-jdocbook-style/2.0.1/hibernate-jdocbook-style-2.0.1.jdocbook-style
>>>>>>>>
>>>>>>>>
>>>>>>>> into
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target/docbook/staging
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] Expanding:
>>>>>>>> /home/gbadner/NotBackedUp/.m2/repository-trunk/org/jboss/jbossorg-jdocbook-style/1.1.0/jbossorg-jdocbook-style-1.1.0.jdocbook-style
>>>>>>>>
>>>>>>>>
>>>>>>>> into
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target/docbook/staging
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] Expanding:
>>>>>>>> /home/gbadner/NotBackedUp/.m2/repository-trunk/org/jboss/jbossorg-fonts/1.0.0/jbossorg-fonts-1.0.0.jdocbook-style
>>>>>>>>
>>>>>>>>
>>>>>>>> into
>>>>>>>> /NotBackedUp/gbadner/hibernate-core/trunk-before-3.5.0-CR-3/documentation/manual/target/docbook/staging
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO] [jdocbook:translate {execution: default}]
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Gail Badner wrote:
>>>>>>>>> Just to let you know, I'm making preparations for 3.5.0-CR-3.
>>>>>>>>> -- Gail
>>>>>>>>> Hardy Ferentschik wrote:
>>>>>>>>>
>>>>>>>>>> Well, there are still a few code changes and if you tar up all
>>>>>>>>>> the
>>>>>>>>>> different documentation
>>>>>>>>>> bundles and attach them to a helpdesk request you get them
>>>>>>>>>> uploaded quite
>>>>>>>>>> quickly (and yes
>>>>>>>>>> an automated upload would be nice!)
>>>>>>>>>>
>>>>>>>>>> If the majority of people is for a delay then that's fine with
>>>>>>>>>> me, but I
>>>>>>>>>> just wanted to
>>>>>>>>>> remind how you yourself said how important it is to stick to the
>>>>>>>>>> boxed
>>>>>>>>>> releases.
>>>>>>>>>>
>>>>>>>>>> --Hardy
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, 10 Mar 2010 19:02:46 -0300, Steve
>>>>>>>>>> Ebersole<steve at hibernate.org>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> I agree in theory. But here we have very little actual code
>>>>>>>>>>> changes:
>>>>>>>>>>> http://opensource.atlassian.com/projects/hibernate/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+HHH+AND+fixVersion+%3D+%223.5.0.Next%22+AND+status+in+%28Resolved%2C+Closed%29+ORDER+BY+priority+DESC
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> That coupled with the fact the uploading docs is still painful
>>>>>>>>>>> is it
>>>>>>>>>>> worth it?
>>>>>>>>>>>
>>>>>>>>>>> On 03/10/2010 02:33 PM, Hardy Ferentschik wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Given the discussion we had the other day about boxed
>>>>>>>>>>>> releases, we
>>>>>>>>>>>> should have another CR candidate
>>>>>>>>>>>> in this case.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, 10 Mar 2010 17:27:05 -0300, Steve
>>>>>>>>>>>> Ebersole<steve at hibernate.org>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I want to push the release originally scheduled for today to
>>>>>>>>>>>>> next week.
>>>>>>>>>>>>> We are down to docs and website.
>>>>>>>>>>>>>
>>>>>>>>>>>>> There are still a few issues with the docs. After implementing
>>>>>>>>>>>>> the
>>>>>>>>>>>>> monospace fonts for programlistigns I am now noticing that the
>>>>>>>>>>>>> callouts
>>>>>>>>>>>>> are all no longer aligned properly (and actually its been
>>>>>>>>>>>>> suggested
>>>>>>>>>>>>> many
>>>>>>>>>>>>> of these be migrated away from programlisting/programlistingco
>>>>>>>>>>>>> altogether. So I'd like the get that all cleaned up. There is
>>>>>>>>>>>>> also
>>>>>>>>>>>>> still the minor issue of line spacing for programlisting in
>>>>>>>>>>>>> the pdf.
>>>>>>>>>>>>>
>>>>>>>>>>>>> As for the site we are actually pretty close to done with what
>>>>>>>>>>>>> we need
>>>>>>>>>>>>> to do for the new site.
>>>>>>>>>>>>>
>>>>>>>>>>>>> In total the idea to push back to next week is to tie up those
>>>>>>>>>>>>> loose
>>>>>>>>>>>>> ends and deliver them all at once along with the Final.
>>>>>>>>>>>>>
>>>>>>>>>>>>> +/- ?
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> hibernate-dev mailing list
>>>>>>>>>> hibernate-dev at lists.jboss.org
>>>>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> hibernate-dev mailing list
>>>>>>>>> hibernate-dev at lists.jboss.org
>>>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> hibernate-dev mailing list
>>>>>>>> hibernate-dev at lists.jboss.org
>>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> hibernate-dev mailing list
>>>>>>> hibernate-dev at lists.jboss.org
>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>>>>
>>>>>> --
>>>>>> steve at hibernate.org
>>>>>> http://hibernate.org
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> hibernate-dev mailing list
>>>>> hibernate-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>>
>>>
>>> --
>>> steve at hibernate.org
>>> http://hibernate.org
>>
>
--
steve at hibernate.org
http://hibernate.org
More information about the hibernate-dev
mailing list