[hibernate-dev] Modularization of Search

[Emmanuel Bernard]

On 17 mars 2010, at 10:55, Sanne Grinovero wrote:

> 2010/3/17 Emmanuel Bernard <emmanuel at hibernate.org>:
>> 
>> On 17 mars 2010, at 10:31, Sanne Grinovero wrote:
>> 
>>>> 
>>>> Four options here:
>>>>  - do this -util module
>>>>  - do a -testsuite module
>>>>  - do the test artifact (Sanne's current commit)
>>>>  - do not split the 3 util classes out
>>>> 
>>>> So far I think the last two solutions are the less annoying
>>>> 
>>> 
>>> I don't feel comfortable in having the testing in a different module
>>> than what it's supposed to test, will be hard to prevent circular
>>> dependencies even if it was relating to some utilities.
>>> We don't have that much testing utilities, and as Emmanuel said before
>>> there's the chance of somebody committing without noticing a test
>>> failing in another module.
>>> 
>>>>> 
>>>>>> hibernate-search-testutil
>>>>> 
>>>>> Ok
>>> 
>>> I'm still confused about the differences between a
>>> hibernate-search-testutil and the "-util" module mentioned on the
>>> previous point. ?
>> 
>> 
>> Remember these are options to explore, not a definitive split
>> Basically:
>>  -util is the common classes used by both test and core
>>  -testutil are the test dedicated util classes.
>> 
> 
> I still don't get it, you have an example of what you would put in "-util" ?
> Not afraid of discussions about "where should I put class X" ?

Hardy told me some test util classes had dependencies on some core classes (from org.hibernate.search.util?) but now that I think about it, SearchTestCase does depends on all the HSearch configuration API so this split does not fly.