[hibernate-dev] building core from master

Max Rydahl Andersen max.andersen at redhat.com
Fri Apr 1 01:07:01 EDT 2011


> It's not a configuration issue, rather a preference setting to turn off the warning about cyclic dependencies: Preferences > Java > Compilter > Building > Build Path Problems > Circular Dependencies > Warning

If thats enough thats great....but there is a reason eclipse has that as an Error.

But since we have different opinions on consequences and effects of cyclic dependencies i'll just leave it at that.

/max

> 
> On Mar 31, 2011, at 1:07 PM, Sanne Grinovero wrote:
> 
>> 2011/3/31 Steve Ebersole <steve at hibernate.org>:
>>> 
>>> On Thursday, March 31, 2011, at 11:52 am, Max Rydahl Andersen wrote:
>>>> On Mar 31, 2011, at 15:28, Steve Ebersole wrote:
>>>>> Just because eclipse might not like it does not make it broken ;)
>>>> 
>>>> It's your choice to make it hard to develop on Hibernate core in Eclipse.
>>> 
>>> Thats one way to look at it.  One point of view.  Of course a just as valid
>>> point of view is that Eclipse is making it difficult.
>>> 
>>>> 
>>>> You can fix it on Hibernate side - I can't fix Eclipse core fundamentals.
>>> 
>>> Well as John already said, he was able to verify that it does in fact work in
>>> Eclipse.  So obviously *they* don't think its a broken set up.  Thats just
>>> your opinion.  Perhaps maybe the concern is that it possibly does not work in
>>> JBoss Tools...
>> 
>> It's actually broken on any Eclipse, nothing to do with JBoss Tools.
>> I doubt Max's point of view is "one point", we're scoring at least two already.
>> 
>> Possibly a large part of eclipse users aren't going to be as lucky as John was,
>> I have no idea how comes it works fine for him, whatever trick he's
>> using it would be nice to have gradle generate his configuration.
>> 
>>> 
>>>> 
>>>> /max
>>>> 
>>>>> On Thursday, March 31, 2011, at 05:14 am, Max Rydahl Andersen wrote:
>>>>>>>> 2)Eclipse
>>>>>>>> the configuration files generated by gradle are totally wrong, but I
>>>>>>>> could fix them by hand.
>>>>>>>> Now Eclipse refuses to compile the project as there's a circular
>>>>>>>> dependency: the testsuite from hibernate-core depends on the
>>>>>>>> hibernate-testing module, which in turn depends on hibernate-core.
>>>>>>> 
>>>>>>> This was intentional.  Both gradle and intellij can handle this.  I
>>>>>>> asked max and he said that such a set up was in some way workable.
>>>>>> 
>>>>>> I said it was probably possibly to workaround/hack, but I did not at
>>>>>> all recommend it.
>>>>>> 
>>>>>> It's a broken setup IMO.
>>>>>> 
>>>>>>> I dont understand what is so foreign about this "circularity".  Look
>>>>>>> at it at the task level.  You compile hibernate-core/src/main; you
>>>>>>> compile hibernate- testing/src/main; you compile
>>>>>>> hibernate-core/src/test.  Yes there is "circularity" if you look
>>>>>>> strictly at this in terms of modules.
>>>>>>> 
>>>>>>> But in terms of tasks and source sets there is not.
>>>>>> 
>>>>>> There is of project dependencies - which is the level eclipse is
>>>>>> working on.
>>>>>> 
>>>>>> Just because the compile setup is possible doesn't make it right IMO.
>>>>>> 
>>>>>> /max
>>>>>> http://about.me/maxandersen
>>>>> 
>>>>> ---
>>>>> Steve Ebersole <steve at hibernate.org>
>>>>> http://hibernate.org
>>>> 
>>>> /max
>>>> http://about.me/maxandersen
>>> 
>>> ---
>>> Steve Ebersole <steve at hibernate.org>
>>> http://hibernate.org
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> 
>> 
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> 
> JPAV
> 
> 
> 
> 
> 
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev

/max
http://about.me/maxandersen







More information about the hibernate-dev mailing list