[hibernate-dev] Moving Hibernate Search test packages

[Sanne Grinovero]

2011/4/4 Hardy Ferentschik <hardy at hibernate.org>:
> If I remember right we didn't initially have the additional 'test' level in
> the code.
> I was also a proponent of not having it, but I think the argument was that
> it helps
> to easier distinguish test from production classes. Obviously they are
> structurally
> separated in different directories, but depending on your IDE view this
> separation might
> not be obvious (idea for example has this concept of "view project as
> Packages".
>
> I have no hard feelings against removing the 'test' level again. I just
> wanted to bring up
> the original intentions (afaicr) with introducing it.
>
> I am, however, against a on a "as needed" basis. I think we should go one
> way or the other.
> If we want to drop it, drop it for all tests in one go.
>
> --Hardy

Hi Hardy,
You're likely talking about another project:
http://anonsvn.jboss.org/repos/hibernate/search/tags/v3_0_0_Beta1/src/test/org/hibernate/search/

I remember when I first started looking into the Search sources that I
wished it was different,
I don't need it anymore for myself as I usually know the project well
enough to bend it to my will, but can understand that for an
occasional contributor it's harder to figure out how to test
something.

Cheers,
Sanne


>
>
>
> On Mon, 04 Apr 2011 21:43:14 +0200, Sanne Grinovero <sanne at hibernate.org>
> wrote:
>
>> Hi,
>> it's sometimes useful from the test packages to be able to get
>> package-level visibility to classes in the main code.
>>
>> All Hibernate Search tests are organized in a
>> "org.hibernate.search.test.X" package;
>> I'd like to move them to "org.hibernate.search.X.Y", i.e. give test
>> implementors the freedom to choose any package name.
>>
>> It's of course possible to obtain the same with many clever tricks,
>> but it would make tests easier to write and cleaner to maintain.
>>
>> Main code API is not affected, as obviously our test conventions don't
>> prevent people to do as they wish with their own package names...
>> to the opposite, we might be able to close down more APIs which
>> nowadays need "public" for testing purposes;
>> I'm not sure if there is such a case, just making the point that in theory
>> it
>> A) won't make things worse
>> B) could make things better
>>
>> I could either make a single commit moving them all out, or we can
>> just start making some tests out of the test package on a "as needed"
>> base.
>>
>> WDYT?
>>
>> Cheers,
>> Sanne
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>