[hibernate-dev] classloading issue when trying to add envers to as7

[Emmanuel Bernard]

On 3 août 2011, at 19:13, Scott Marlow wrote:

> On 08/03/2011 01:03 PM, Emmanuel Bernard wrote:
>> 
>> On 3 août 2011, at 18:56, Scott Marlow wrote:
>> 
>>> On 08/03/2011 11:44 AM, Strong Liu wrote:
>>>> Hi there,
>>>> 
>>>> I get envers embedded into as7 :D
>>>> 
>>>> see below:
>>>> 
>>>> https://github.com/stliu/hibernate-core/tree/classloading
>>>> https://github.com/stliu/jboss-as/tree/as7-928-2
>>>> 
>>>> 1. org.hibernate module and org.hibernate.envers module depends on each other.
>>> 
>>> We might make the Hibernate to envers dependency optional in the
>>> org.hibernate module.xml:
>>>    <module name="org.envers" optional="true"/>
>>> So, that it is possible for the envers module to be removed for some
>>> reason (I cannot think of why at the moment but just a thought).
>> 
>> This will not work for any other user provided Hibernate Core integrators I think.
> 
> My reasoning for making it an optional module dependency isn't strong. Its more so that the org.hibernate module can load, even if envers is missing for some reason.  I'm fine with not making it "optional="true"" for now.  :)

optional is good. What I am saying is that any user can write an Hibernate integrator that ought to be started by Hibernate upon SearchFactory or EntityManagerFactory construction. You can't force all these guys to change stuffs in org.hibernate.module.xml