[hibernate-dev] [HSEARCH] Extract core of HSEARCH query engine to be independent of Hibernate Core.

[Sanne Grinovero]

2011/2/23 Emmanuel Bernard <emmanuel at hibernate.org>:
>
> On 23 févr. 2011, at 18:13, Sanne Grinovero wrote:
>
>> I've been trying to port current work in progress as dependency of
>> Infinispan Query,
>> I'm wishing for these changes:
>>
>> 1) TimeoutManager should throw specific exceptions directly, depending
>> on the framework being used
>> (see the pull request I sent you [1], I think it solves the issue, we
>> might want to polish it a bit to have the JPA interface define it's
>> own specific factory.
>
> I'll have a look
>
>>
>> 2) The org.hibernate.search.engine.Loader interface:
>> I'd just remove the init() method from the interface.
>> Infinispan Query needs quite different types and parameters (and
>> definitely not a Session), and I see no reason to have the init method
>> expressed by the interface contract.
>> Each framework should know how to create and initialize his specific loaders.
>
> Loader is not a public API. If we ever expose it, that's going to be fore Hibernate Core's object loading.
> In other words, I have the feeling that Loader cannot be reused between various object sources. Does ISPN's Query module use them? Did you manager to reuse much code in practice?

I could remove almost all code from HSQuery, a huge improvement. About
the Loader, you're right I don't need it - just removed all references
to it. I need something in the same role, but doesn't need to
implement this interface.