[hibernate-dev] [OGM] Issue with accepting mongodb in master

[Guillaume SCHEIBEL]

I'm okay with this approach. Therefore, we have to skip
the hibernate.ogm.mongodb.host and port properties.

2012/4/25 Sanne Grinovero <sanne at hibernate.org>

> The relevant settings I have in ~/.m2/settings.xml :
>
> Working already:
>
> <activeProfiles>
>        <activeProfile>jboss-public-repository</activeProfile>
>        <activeProfile>forceJava6</activeProfile>
>        <activeProfile>mongodb</activeProfile>
> </activeProfiles>
>
> If we add properties for hostname, you could have in the same file as well:
>
> <profiles>
>        <profile>
>            <id>mongodb</id>
>            <properties>
>
> <ogm.mongodb.server.hostname>172.17.130.62</ogm.mongodb.server.hostname>
>            </properties>
>        </profile>
>  [...]
> </profiles>
>
>
> On 25 April 2012 16:01, Sanne Grinovero <sanne at hibernate.org> wrote:
> > In the pull request I've sent the MongoDB tests are disabled, one
> > would need to enable it using the Maven profile
> >
> > example:
> >> mvn clean install -Pmongodb
> >
> > If you run just "mvn clean install", it will skip building the MongoDB
> module.
> >
> > I know it's not ideal as we would like everyone to test for it, but my
> > idea was mostly to have the branch converge in master sooner and work
> > on a better solution later.
> >
> > To change "localhost" to something different I can add some build
> > properties, but this still requires a MongoDB installed somewhere.
> >
> > We could follow this approach:
> >  - we (maintainers) have MongoDB and have the profile enabled by
> > default in our Maven settings, so we always review any change
> > verifying the mongo module isn't broken
> >  - any contributor working on code out-of-mongo could break the mongo
> > module, but this shouldn't happen often, and would be caught by our
> > review
> >  - contributors actively working on MongoDB are expected to have a
> > mongo available, and will have to enable the profile. Frequent
> > contributors could also set it in their maven settings as we do.
> >
> > So I think you can merge it?
> >
> > Sanne
> >
> >
> > On 25 April 2012 15:18, Emmanuel Bernard <emmanuel at hibernate.org> wrote:
> >> I'd like to accept MongoDB's work in OGM's master branch. There is one
> big elephant in the room.
> >> If I don't have MongoDB running in localhost, I can pass the test and
> thus I can't do a release. That's especially a problem for me as my MongoDB
> instance is in a VM and thus not localhost. I can't update the
> hibernate.properties as the release process takes a fork of the repo and
> does not rely on what's not committed yet.
> >>
> >> Does anyone has a solution?
> >>
> >> - we could try and let things be overridden with -D properties
> >> - we could try and simply not run tests if the mongodb instance is not
> up and running
> >>
> >> Any other idea?
> >>
> >> Does anyone has an idea how to implement that? Frankly, we can't really
> accept the work in master until we have a solution for this.
> >>
> >> Emmanuel
> >> _______________________________________________
> >> hibernate-dev mailing list
> >> hibernate-dev at lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>