[hibernate-dev] Unit test failures using the new metamodel

[Hardy Ferentschik]

On 2 Aug 2012, at 07:56, Gail Badner <gbadner at redhat.com> wrote:

> I'm seeing the following failures using hibernate.test.new_metadata_mappings=true that appear to be regressions:
> 
> - org.hibernate.jpa.test.connection.DataSourceInjectionTest fails (also fails using the old metadata);
> - org.hibernate.test.annotations.lob.LobTest.testSerializableToBlob

Don't know anything about the others, but LobTest is no regression. The tests did now work at all before, because building the sources would fail. This works now and now the test fails on the last assert. Some behavior in the engine must have changed. We can annotate this particular test with @FailureExpectedWithNewMetamodel or maybe you know what the problem is directly.

> Also, there were numerous failures in hibernate-core when building with hibernate.test.validatefailureexpected=true, which validates that those tests annotated with @FailureExpected or @FailureExpectedWithNewMetamodel actually fail. If an annotated test does not fail as expected, org.hibernate.testing.junit4.FailureExpectedHandler$FailureExpectedTestPassedException is thrown causing the test to fail.

That flag should be the default. Why is it not turned on? In which case does it make sense to have this flag set to false?

> When hibernate.test.validatefailureexpected is false (the default), the result from FailureExpected tests is simply ignored.

:-(

> I've gone ahead and pushed a fix that removes @FailureExpectedWithNewMetamodel from those tests that succeed without the annotation.
> 
> There are 2 tests where this does not work:
>    org.hibernate.test.annotations.interfaces.InterfacesTest
>    org.hibernate.test.annotations.idmanytoone.alphabetical.AlphabeticalIdManyToOneTest
> 
> These tests fail with org.hibernate.cfg.NotYetImplementedException when the sources are being processed. For some reason. this failure is not recognized as an expected failure. I'm not sure of the reason for this.

Probably because it happens I'm the setup phase and not during the test execution.

> It seems that now would be a good time to make both hibernate.test.new_metadata_mappings=true and hibernate.test.validatefailureexpected=true the default when building.

+1

--hardy