[hibernate-dev] integrate Envers with new metamodel

[Strong Liu]

that part is developed to replace commons-annotations, but it is not designed as a separated module, but part of hibernate-orm.
because of using Jandex, this code is much simpler now, so there is no need to do that.

for modules like h-search which doesn't depend on ORM, maybe it should move to use Jandex as well, but that's another topic, here i'd more focus on hibernate-envers, which directly depends on ORM, so we'd definitely not want to index the annotations again.

I just did the initial work of my propose and pushed it to my repo https://github.com/stliu/hibernate-orm  "integrator" branch


On Aug 1, 2012, at 4:55 AM, Sanne Grinovero <sanne at hibernate.org> wrote:

> Why is the "annotation indexing" discussion part of the metamodel?
> I initially understood that a replacement of commons-annotations was
> being developed, which would be nice for Search too as Search does not
> and should not depend on Hibernate ORM.
> 
> Cheers,
> Sanne
> 
> On 31 July 2012 23:49, Strong Liu <stliu at hibernate.org> wrote:
>> maybe we should move the annotation indexing from
>> org.hibernate.metamodel.internal.source.annotations.AnnotationMetadataSourceProcessorImpl#AnnotationMetadataSourceProcessorImpl
>> into MetadataSources ( for hbm, it can be get by
>> org.hibernate.metamodel.MetadataSources#getJaxbRootList)
>> 
>> and add a new interface MetadataContributingIntegrator and hook this into
>> org.hibernate.metamodel.internal.MetadataImpl#MetadataImpl
>> 
>> 
>> thoughts?
>> 
>> 
>> 
>> On Jul 31, 2012, at 10:51 PM, Sanne Grinovero <sanne at hibernate.org> wrote:
>> 
>> Both Hibernate Search and Hibernate OGM will need to look for custom
>> annotations as well.
>> 
>> 
>> On 30 July 2012 22:59, Strong Liu <stliu at hibernate.org> wrote:
>> 
>> https://hibernate.onjira.com/browse/HHH-7490
>> 
>> the problem is, envers needs to index its own annotations ( @Audited for
>> example ), but the current Integrator api only passes in a Metadata
>> instance.
>> 
>> so, we either pass in the Index or the MetadataImplementor has access to the
>> all mapping entities
>> 
>> thoughts?
>> -------------------------
>> Best Regards,
>> 
>> Strong Liu <stliu at hibernate.org>
>> http://about.me/stliu/bio
>> 
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> 
>> 
>> -------------------------
>> Best Regards,
>> 
>> Strong Liu <stliu at hibernate.org>
>> http://about.me/stliu/bio
>> 

-------------------------
Best Regards,

Strong Liu <stliu at hibernate.org>
http://about.me/stliu/bio