[hibernate-dev] Covariant returns

[Steve Ebersole]

Ah, that was Guenther that reported the problem... Sorry

On Wed 14 Mar 2012 11:51:30 AM CDT, Guillaume Smet wrote:
> Hi Steve,
>
> On Wed, Mar 14, 2012 at 4:46 PM, Steve Ebersole<steve at hibernate.org>  wrote:
>> Was the initial problem you just using SessionImpl directly?  Or is it a
>> problem of particular JDK handling the covariant return differently?  In the
>> latter case we'd need to change the code.  In the former, its a discussion.
>
> I'm not the OP. It works perfectly on my side, as reported yesterday.
>
>> As for why byId is that way, TBH being new to being able to design APIs with
>> Java 5+ features I tend to try things to see how they work.
>
> The new APIs are really nice from a DSL point of view, especially the
> natural id stuff. Thanks for your work on this.
>
> IMHO, even if it's not a problem by itself, I think byId() should be
> consistent with the rest of the API and return an interface. I don't
> see any advantages to return the Impl in this case.
>
> Have a nice day.
>

-- 
steve at hibernate.org
http://hibernate.org