[hibernate-dev] Checkstyle: enforced!

[Davide D'Alto]

I don't have any particular objection to set it on the verify phase. I tend
to always use mvn install anyway.

The argument I can use to promote the compile phase (for sake of discussion
only)
I like the fact that I can check the code writing mvn compile, therefore
without starting any test.
If you think you are going to prototype something big you can always you
can always change the attribute failsOnError to false.




On Thu, Apr 18, 2013 at 4:56 PM, Gunnar Morling <gunnar at hibernate.org>wrote:

> Also you're not always in your IDE. For instance I recently tried to change
> something experimentally in the AS code base, just using my text editor
> (no, it was not vi ;). Then CS can really be in the way for
> compilation/tests. So I think it makes most sense to have it in the
> "verify" phase.
>
>
> 2013/4/18 Hardy Ferentschik <hardy at hibernate.org>
>
> >
> > On 18 Jan 2013, at 5:27 PM, Sanne Grinovero <sanne at hibernate.org> wrote:
> >
> > > On 18 April 2013 16:13, Gunnar Morling <gunnar at hibernate.org> wrote:
> > >> Yeah, I was just about to suggest that :)
> > >
> > > Good idea, but isn't it true that if your IDE is correctly setup it
> > doesn't matter?
> >
> > True, but sometimes you might want to ignore the rules.
> >
> > > I'm not sure about IDEA, but Eclipse detects the checkstyle rules and
> > > shows violations right away.
> >
> > Not sure, I don't have any check style plugin enabled in Idea. And again,
> > it
> > is a question of IDE vs build. Wether and how you configure your IDE to
> > conform to the coding standard is one thing and where and how you check
> > the standard as part of the build is another.
> >
> > --Hardy
> >
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>