[hibernate-dev] Checkstyle: enforced!

[Hardy Ferentschik]

On 18 Jan 2013, at 6:15 PM, Sanne Grinovero <sanne at hibernate.org> wrote:

> On 18 April 2013 17:12, Davide D'Alto <daltodavide at gmail.com> wrote:
>> I don't have any particular objection to set it on the verify phase. I tend
>> to always use mvn install anyway.
>> 
>> The argument I can use to promote the compile phase (for sake of discussion
>> only)
>> I like the fact that I can check the code writing mvn compile, therefore
>> without starting any test.
>> If you think you are going to prototype something big you can always you
>> can always change the attribute failsOnError to false.
> 
> right but if this motivates people to hardcode -DfailsOnError-false in
> their scripts, we're back to square one ;-)

bottom line is that one of the core devs will integrate the pull request and as part
of it verify/test it. If the contributor did fail to match the style we can respond and 
hopefully we even automate the pull request build. 

--Hardy